47f262c970
# Introduction At the moment when updating any record cache occurence, we will build a fragment that will expect all of the object metadata item fields to be provided. Which result in the following traces: ( in the video companies aren't fetch with companyId and other missing fields ) https://github.com/user-attachments/assets/56eab7c1-8f01-45ff-8f5d-78737b788b92 By definition as we're using graphql we might not request every record's fields each time we wanna consume them. In this way we will now dynamically compute or expect depending on the CRUD operation specific fields to be written in the cache, and not all of them Tested all optimistic and failure management use cases ## Covering cache Added coverage only for the `deleteOne` and `deleteMany` hooks, it cover only the record record cache and not its relations hydratation ( for the moment ) ## Why not closing #9927 Unless I'm mistaken everything done here have fixed the same logs/traces issue for updates and deletion but not creation. Which means we still need to investigate the mass upload from import and prefillRecord behavior In a nutshell: went over each `updateRecordFromCache` calls, still need to do all `createRecordInCache` calls related to #9927 ## Conlusion Sorry for the big PR should have ejected into a specific one for the `MinimalRecord` refactor Will also continue covering others hooks later in my week as for the `deleteOne` As always any suggestions are welcomed !
69 lines
2.3 KiB
TypeScript
69 lines
2.3 KiB
TypeScript
import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
|
|
import { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';
|
|
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
|
|
import { useGetRecordFromCache } from '@/object-record/cache/hooks/useGetRecordFromCache';
|
|
import { updateRecordFromCache } from '@/object-record/cache/utils/updateRecordFromCache';
|
|
import { DELETE_WORKFLOW_VERSION_STEP } from '@/workflow/graphql/mutations/deleteWorkflowVersionStep';
|
|
import { WorkflowVersion } from '@/workflow/types/Workflow';
|
|
import { useApolloClient, useMutation } from '@apollo/client';
|
|
import { isDefined } from 'twenty-shared';
|
|
import {
|
|
DeleteWorkflowVersionStepInput,
|
|
DeleteWorkflowVersionStepMutation,
|
|
DeleteWorkflowVersionStepMutationVariables,
|
|
WorkflowAction,
|
|
} from '~/generated/graphql';
|
|
|
|
export const useDeleteWorkflowVersionStep = () => {
|
|
const apolloClient = useApolloClient();
|
|
const { objectMetadataItems } = useObjectMetadataItems();
|
|
const { objectMetadataItem } = useObjectMetadataItem({
|
|
objectNameSingular: CoreObjectNameSingular.WorkflowVersion,
|
|
});
|
|
const getRecordFromCache = useGetRecordFromCache({
|
|
objectNameSingular: CoreObjectNameSingular.WorkflowVersion,
|
|
});
|
|
const [mutate] = useMutation<
|
|
DeleteWorkflowVersionStepMutation,
|
|
DeleteWorkflowVersionStepMutationVariables
|
|
>(DELETE_WORKFLOW_VERSION_STEP, {
|
|
client: apolloClient,
|
|
});
|
|
const deleteWorkflowVersionStep = async (
|
|
input: DeleteWorkflowVersionStepInput,
|
|
) => {
|
|
const result = await mutate({ variables: { input } });
|
|
const deletedStep = result?.data?.deleteWorkflowVersionStep;
|
|
if (!isDefined(deletedStep)) {
|
|
return;
|
|
}
|
|
|
|
const cachedRecord = getRecordFromCache<WorkflowVersion>(
|
|
input.workflowVersionId,
|
|
);
|
|
if (!isDefined(cachedRecord)) {
|
|
return;
|
|
}
|
|
|
|
const newCachedRecord = {
|
|
...cachedRecord,
|
|
steps: (cachedRecord.steps || []).filter(
|
|
(step: WorkflowAction) => step.id !== deletedStep.id,
|
|
),
|
|
};
|
|
|
|
const recordGqlFields = {
|
|
steps: true,
|
|
};
|
|
updateRecordFromCache({
|
|
objectMetadataItems,
|
|
objectMetadataItem,
|
|
cache: apolloClient.cache,
|
|
record: newCachedRecord,
|
|
recordGqlFields,
|
|
});
|
|
};
|
|
|
|
return { deleteWorkflowVersionStep };
|
|
};
|