Something changed, which affected the Favorite folder picker checkbox styles -- fixed it! Cleaned up code in `CurrentWorkspaceMemberFavoritesFolders` - removed redundant filtering since favorites are already filtered in `usePrefetchedFavoritesData`. Regarding issue #8569 - I am not sure what to do in this case. Since Folders data is gated by a feature flag, we can't use it in `CurrentWorkspaceMemberFavoritesFolders` to ensure the favorite section renders with empty folders. Currently, the section only appears when at least one favorite exists - may be leave this section open at all times or fix this bug after removal of the feature flag? --------- Co-authored-by: Nitin Koche <nitinkoche@Nitins-MacBook-Pro.local> Co-authored-by: Charles Bochet <charles@twenty.com>
31 lines
1013 B
TypeScript
31 lines
1013 B
TypeScript
import { sortFavorites } from '@/favorites/utils/sortFavorites';
|
|
import { useFavoritesMetadata } from './useFavoritesMetadata';
|
|
import { usePrefetchedFavoritesData } from './usePrefetchedFavoritesData';
|
|
import { usePrefetchedFavoritesFoldersData } from './usePrefetchedFavoritesFoldersData';
|
|
|
|
export const useFavoritesByFolder = () => {
|
|
const { favorites } = usePrefetchedFavoritesData();
|
|
const { favoriteFolders } = usePrefetchedFavoritesFoldersData();
|
|
const {
|
|
views,
|
|
objectMetadataItems,
|
|
getObjectRecordIdentifierByNameSingular,
|
|
favoriteRelationFields,
|
|
} = useFavoritesMetadata();
|
|
|
|
const favoritesByFolder = favoriteFolders.map((folder) => ({
|
|
folderId: folder.id,
|
|
folderName: folder.name,
|
|
favorites: sortFavorites(
|
|
favorites.filter((favorite) => favorite.favoriteFolderId === folder.id),
|
|
favoriteRelationFields,
|
|
getObjectRecordIdentifierByNameSingular,
|
|
true,
|
|
views,
|
|
objectMetadataItems,
|
|
),
|
|
}));
|
|
|
|
return { favoritesByFolder };
|
|
};
|