5946b37712
This PR refactors the generic module object dropdown filter input. We have multiple components for each filter type and each one was using selectedFilterState and the applyRecordFilter hook to read and set its value. The main issue was that each component was forced to pass every property of a RecordFilter to applyRecordFilter to only modify the value property, thus creating a lot of unnecessary dependencies and tight coupling between every component and hook that used the record filters. Now we have each component only reading from a new objectFilterDropdownCurrentRecordFilterComponentState, scoped to a ObjectFilterDropdownComponentInstanceContext, thus whether we're in a view bar dropdown, an editable filter chip dropdown or an advanced filter dropdown, we know where to read the filter value from. This component state might even be simplified by only storing the record filter id, thus avoiding having to synchronize this state with its counterpart in currentRecordFilterComponentState, but we should try after the main refactor effort, as those two states aren't in the same instance context. We implement a new applyObjectFilterDropdownFilterValue hook to handle the value setting from an object filter dropdown input component. There's also a new useApplyObjectFilterDropdownOperand for doing the same but for operand. Another important thing that had to be done to keep a synchronous code path was to set the states of each advanced filter row at the advanced filter dropdown onOpen event, using useSetAdvancedFilterDropdownStates. Finally we remove : useApplyRecordFilter, useSelectFilterUsedInDropdown and selectedFilterComponentState which were making all of this zone difficult to work with. Closes https://github.com/twentyhq/core-team-issues/issues/718 Closes https://github.com/twentyhq/core-team-issues/issues/720
Run yarn dev while server running on port 3000