- Clean Playwright's configuration:
- Remove artificial 500ms delay between each step
- Group all tests under a `chrome` project relying on a `setup` project
to get an authentication state which all tests can reuse
- Changes on the `Sign up with invite link via email` test:
- Generate a new email for each test trial, as previously it was failing
when run many times
- Make deleting the account part of the test; if we write other tests
for account sign-up, we'll prefer to delete the accounts with an HTTP
call to speed up things
- Added some assertions to ensure we reached steps when expected, as we
removed the 500ms delay between each step, and it made some assertions
fail
- Wrote new tests for workflows:
- Created `Create workflow`, a test asserting we can create a workflow
from the record table
- Created `Create simple workflow`, a test asserting we can create a
simple flow; I will add more assertions to this test and write other
tests once this first PR is approved
- I make HTTP calls to delete and destroy workflows after they run to
keep the database clean
- Added a data-testid to ensure we focus elements from the Cmd+K; our
selectors are not strong – see `getByRole('textbox')` – and I preferred
to scope them to a root element
- Added an `aria-label` to a button
---------
Co-authored-by: prastoin <paul@twenty.com>
70 lines
1.8 KiB
TypeScript
70 lines
1.8 KiB
TypeScript
import { test as base, expect, Page } from '@playwright/test';
|
|
import { randomUUID } from 'node:crypto';
|
|
import { createWorkflow } from '../requests/create-workflow';
|
|
import { deleteWorkflow } from '../requests/delete-workflow';
|
|
import { destroyWorkflow } from '../requests/destroy-workflow';
|
|
|
|
export class WorkflowVisualizerPage {
|
|
#page: Page;
|
|
|
|
workflowId: string;
|
|
workflowName: string;
|
|
|
|
constructor({ page, workflowName }: { page: Page; workflowName: string }) {
|
|
this.#page = page;
|
|
this.workflowName = workflowName;
|
|
}
|
|
|
|
async createOneWorkflow() {
|
|
const id = randomUUID();
|
|
|
|
const response = await createWorkflow({
|
|
page: this.#page,
|
|
workflowId: id,
|
|
workflowName: this.workflowName,
|
|
});
|
|
|
|
expect(response.status()).toBe(200);
|
|
|
|
const responseBody = await response.json();
|
|
expect(responseBody.data.createWorkflow.id).toBe(id);
|
|
|
|
this.workflowId = id;
|
|
}
|
|
|
|
async goToWorkflowVisualizerPage() {
|
|
await this.#page.goto(`/object/workflow/${this.workflowId}`);
|
|
|
|
const workflowName = this.#page.getByRole('button', {
|
|
name: this.workflowName,
|
|
});
|
|
|
|
await expect(workflowName).toBeVisible();
|
|
}
|
|
}
|
|
|
|
export const test = base.extend<{ workflowVisualizer: WorkflowVisualizerPage }>(
|
|
{
|
|
workflowVisualizer: async ({ page }, use) => {
|
|
const workflowVisualizer = new WorkflowVisualizerPage({
|
|
page,
|
|
workflowName: 'Test Workflow',
|
|
});
|
|
|
|
await workflowVisualizer.createOneWorkflow();
|
|
await workflowVisualizer.goToWorkflowVisualizerPage();
|
|
|
|
await use(workflowVisualizer);
|
|
|
|
await deleteWorkflow({
|
|
page,
|
|
workflowId: workflowVisualizer.workflowId,
|
|
});
|
|
await destroyWorkflow({
|
|
page,
|
|
workflowId: workflowVisualizer.workflowId,
|
|
});
|
|
},
|
|
},
|
|
);
|