9ad8287dbc
# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
38 lines
1.6 KiB
TypeScript
38 lines
1.6 KiB
TypeScript
import { useEffect } from 'react';
|
|
import { useNavigation } from 'react-router-dom';
|
|
|
|
import { scrollWrapperInstanceComponentState } from '@/ui/utilities/scroll/states/scrollWrapperInstanceComponentState';
|
|
import { scrollWrapperScrollTopComponentState } from '@/ui/utilities/scroll/states/scrollWrapperScrollTopComponentState';
|
|
import { useRecoilComponentStateV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentStateV2';
|
|
import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
/**
|
|
* @deprecated We should now use useScrollToPosition instead
|
|
* Note that `location.key` is used in the cache key, not `location.pathname`,
|
|
* so the same path navigated to at different points in the history stack will
|
|
* not share the same scroll position.
|
|
*/
|
|
export const useScrollRestoration = (viewportHeight?: number) => {
|
|
const { state } = useNavigation();
|
|
|
|
const [scrollTop, setScrollTop] = useRecoilComponentStateV2(
|
|
scrollWrapperScrollTopComponentState,
|
|
);
|
|
|
|
const overlayScrollbars = useRecoilComponentValueV2(
|
|
scrollWrapperInstanceComponentState,
|
|
);
|
|
|
|
const scrollWrapper = overlayScrollbars?.elements().viewport;
|
|
const skip = isDefined(viewportHeight) && scrollTop > viewportHeight;
|
|
|
|
useEffect(() => {
|
|
if (state === 'loading') {
|
|
setScrollTop(scrollWrapper?.scrollTop ?? 0);
|
|
} else if (state === 'idle' && isDefined(scrollWrapper) && !skip) {
|
|
scrollWrapper.scrollTo({ top: scrollTop });
|
|
}
|
|
}, [state, scrollWrapper, skip, scrollTop, setScrollTop]);
|
|
};
|