# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
79 lines
2.4 KiB
TypeScript
79 lines
2.4 KiB
TypeScript
import { useRecoilState, useRecoilValue } from 'recoil';
|
|
|
|
import { useCreateActivityInDB } from '@/activities/hooks/useCreateActivityInDB';
|
|
import { useRefreshShowPageFindManyActivitiesQueries } from '@/activities/hooks/useRefreshShowPageFindManyActivitiesQueries';
|
|
import { isActivityInCreateModeState } from '@/activities/states/isActivityInCreateModeState';
|
|
import { isUpsertingActivityInDBState } from '@/activities/states/isCreatingActivityInDBState';
|
|
import { objectShowPageTargetableObjectState } from '@/activities/timeline-activities/states/objectShowPageTargetableObjectIdState';
|
|
import { Note } from '@/activities/types/Note';
|
|
import { Task } from '@/activities/types/Task';
|
|
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
|
|
import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
export const useUpsertActivity = ({
|
|
activityObjectNameSingular,
|
|
}: {
|
|
activityObjectNameSingular:
|
|
| CoreObjectNameSingular.Task
|
|
| CoreObjectNameSingular.Note;
|
|
}) => {
|
|
const [isActivityInCreateMode] = useRecoilState(isActivityInCreateModeState);
|
|
|
|
const { updateOneRecord: updateOneActivity } = useUpdateOneRecord<
|
|
Task | Note
|
|
>({
|
|
objectNameSingular: activityObjectNameSingular,
|
|
});
|
|
|
|
const { createActivityInDB } = useCreateActivityInDB({
|
|
activityObjectNameSingular,
|
|
});
|
|
|
|
const [, setIsUpsertingActivityInDB] = useRecoilState(
|
|
isUpsertingActivityInDBState,
|
|
);
|
|
|
|
const objectShowPageTargetableObject = useRecoilValue(
|
|
objectShowPageTargetableObjectState,
|
|
);
|
|
|
|
const { refreshShowPageFindManyActivitiesQueries } =
|
|
useRefreshShowPageFindManyActivitiesQueries({
|
|
activityObjectNameSingular,
|
|
});
|
|
|
|
const upsertActivity = async ({
|
|
activity,
|
|
input,
|
|
}: {
|
|
activity: Task | Note;
|
|
input: Partial<Task | Note>;
|
|
}) => {
|
|
setIsUpsertingActivityInDB(true);
|
|
if (isActivityInCreateMode) {
|
|
const activityToCreate: Partial<Task | Note> = {
|
|
...activity,
|
|
...input,
|
|
};
|
|
|
|
if (isDefined(objectShowPageTargetableObject)) {
|
|
refreshShowPageFindManyActivitiesQueries();
|
|
}
|
|
|
|
await createActivityInDB(activityToCreate);
|
|
} else {
|
|
await updateOneActivity?.({
|
|
idToUpdate: activity.id,
|
|
updateOneRecordInput: input,
|
|
});
|
|
}
|
|
|
|
setIsUpsertingActivityInDB(false);
|
|
};
|
|
|
|
return {
|
|
upsertActivity,
|
|
};
|
|
};
|