9ad8287dbc
# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
49 lines
1.5 KiB
TypeScript
49 lines
1.5 KiB
TypeScript
import { Company } from '@/companies/types/Company';
|
|
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
|
|
import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
|
|
import { getCompanyDomainName } from '@/object-metadata/utils/getCompanyDomainName';
|
|
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
|
|
import { REACT_APP_SERVER_BASE_URL } from '~/config';
|
|
import { getImageIdentifierFieldValue } from './getImageIdentifierFieldValue';
|
|
import {
|
|
getImageAbsoluteURI,
|
|
getLogoUrlFromDomainName,
|
|
isDefined,
|
|
} from 'twenty-shared/utils';
|
|
|
|
export const getAvatarUrl = (
|
|
objectNameSingular: string,
|
|
record: ObjectRecord,
|
|
imageIdentifierFieldMetadataItem: FieldMetadataItem | undefined,
|
|
) => {
|
|
if (objectNameSingular === CoreObjectNameSingular.WorkspaceMember) {
|
|
return record.avatarUrl ?? undefined;
|
|
}
|
|
|
|
if (objectNameSingular === CoreObjectNameSingular.Company) {
|
|
return getLogoUrlFromDomainName(
|
|
getCompanyDomainName(record as Company) ?? '',
|
|
);
|
|
}
|
|
|
|
if (objectNameSingular === CoreObjectNameSingular.Person) {
|
|
return isDefined(record.avatarUrl)
|
|
? getImageAbsoluteURI({
|
|
imageUrl: record.avatarUrl,
|
|
baseUrl: REACT_APP_SERVER_BASE_URL,
|
|
})
|
|
: '';
|
|
}
|
|
|
|
const imageIdentifierFieldValue = getImageIdentifierFieldValue(
|
|
record,
|
|
imageIdentifierFieldMetadataItem,
|
|
);
|
|
|
|
if (isDefined(imageIdentifierFieldValue)) {
|
|
return imageIdentifierFieldValue;
|
|
}
|
|
|
|
return '';
|
|
};
|