# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
143 lines
3.7 KiB
TypeScript
143 lines
3.7 KiB
TypeScript
import styled from '@emotion/styled';
|
|
import React, { useMemo } from 'react';
|
|
import { RoundedLink, THEME_COMMON } from 'twenty-ui';
|
|
|
|
import { FieldPhonesValue } from '@/object-record/record-field/types/FieldMetadata';
|
|
import { ExpandableList } from '@/ui/layout/expandable-list/components/ExpandableList';
|
|
|
|
import { DEFAULT_PHONE_CALLING_CODE } from '@/object-record/record-field/meta-types/input/components/PhonesFieldInput';
|
|
import { parsePhoneNumber } from 'libphonenumber-js';
|
|
import { logError } from '~/utils/logError';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
type PhonesDisplayProps = {
|
|
value?: FieldPhonesValue;
|
|
isFocused?: boolean;
|
|
onPhoneNumberClick?: (
|
|
phoneNumber: string,
|
|
event: React.MouseEvent<HTMLElement>,
|
|
) => void;
|
|
};
|
|
|
|
const themeSpacing = THEME_COMMON.spacingMultiplicator;
|
|
|
|
const StyledContainer = styled.div`
|
|
align-items: center;
|
|
display: flex;
|
|
gap: ${themeSpacing * 1}px;
|
|
justify-content: flex-start;
|
|
|
|
max-width: 100%;
|
|
|
|
overflow: hidden;
|
|
|
|
width: 100%;
|
|
`;
|
|
|
|
export const PhonesDisplay = ({
|
|
value,
|
|
isFocused,
|
|
onPhoneNumberClick,
|
|
}: PhonesDisplayProps) => {
|
|
const phones = useMemo(
|
|
() =>
|
|
[
|
|
value?.primaryPhoneNumber
|
|
? {
|
|
number: value.primaryPhoneNumber,
|
|
callingCode:
|
|
value.primaryPhoneCallingCode ||
|
|
value.primaryPhoneCountryCode ||
|
|
`+${DEFAULT_PHONE_CALLING_CODE}`,
|
|
}
|
|
: null,
|
|
...parseAdditionalPhones(value?.additionalPhones),
|
|
]
|
|
.filter(isDefined)
|
|
.map(({ number, callingCode }) => {
|
|
return {
|
|
number,
|
|
callingCode,
|
|
};
|
|
}),
|
|
[
|
|
value?.primaryPhoneNumber,
|
|
value?.primaryPhoneCallingCode,
|
|
value?.primaryPhoneCountryCode,
|
|
value?.additionalPhones,
|
|
],
|
|
);
|
|
const parsePhoneNumberOrReturnInvalidValue = (number: string) => {
|
|
try {
|
|
return { parsedPhone: parsePhoneNumber(number) };
|
|
} catch (e) {
|
|
return { invalidPhone: number };
|
|
}
|
|
};
|
|
|
|
const handleClick = (
|
|
number: string,
|
|
event: React.MouseEvent<HTMLElement>,
|
|
) => {
|
|
onPhoneNumberClick?.(number, event);
|
|
};
|
|
|
|
return isFocused ? (
|
|
<ExpandableList isChipCountDisplayed>
|
|
{phones.map(({ number, callingCode }, index) => {
|
|
const { parsedPhone, invalidPhone } =
|
|
parsePhoneNumberOrReturnInvalidValue(callingCode + number);
|
|
const URI = parsedPhone?.getURI();
|
|
return (
|
|
<RoundedLink
|
|
key={index}
|
|
href={URI || ''}
|
|
label={
|
|
parsedPhone ? parsedPhone.formatInternational() : invalidPhone
|
|
}
|
|
onClick={(event) => handleClick(callingCode + number, event)}
|
|
/>
|
|
);
|
|
})}
|
|
</ExpandableList>
|
|
) : (
|
|
<StyledContainer>
|
|
{phones.map(({ number, callingCode }, index) => {
|
|
const { parsedPhone, invalidPhone } =
|
|
parsePhoneNumberOrReturnInvalidValue(callingCode + number);
|
|
const URI = parsedPhone?.getURI();
|
|
return (
|
|
<RoundedLink
|
|
key={index}
|
|
href={URI || ''}
|
|
label={
|
|
parsedPhone ? parsedPhone.formatInternational() : invalidPhone
|
|
}
|
|
onClick={(event) => handleClick(callingCode + number, event)}
|
|
/>
|
|
);
|
|
})}
|
|
</StyledContainer>
|
|
);
|
|
};
|
|
|
|
const parseAdditionalPhones = (additionalPhones?: any) => {
|
|
if (!additionalPhones) {
|
|
return [];
|
|
}
|
|
|
|
if (typeof additionalPhones === 'object') {
|
|
return additionalPhones;
|
|
}
|
|
|
|
if (typeof additionalPhones === 'string') {
|
|
try {
|
|
return JSON.parse(additionalPhones);
|
|
} catch (error) {
|
|
logError(`Error parsing additional phones' : ` + error);
|
|
}
|
|
}
|
|
|
|
return [];
|
|
};
|