# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
90 lines
2.0 KiB
TypeScript
90 lines
2.0 KiB
TypeScript
import { Injectable } from '@nestjs/common';
|
|
|
|
import { plainToInstance } from 'class-transformer';
|
|
import {
|
|
IsEnum,
|
|
IsInt,
|
|
IsOptional,
|
|
Max,
|
|
Min,
|
|
validateOrReject,
|
|
} from 'class-validator';
|
|
import { FieldMetadataType } from 'twenty-shared/types';
|
|
|
|
import { FieldMetadataSettings } from 'src/engine/metadata-modules/field-metadata/interfaces/field-metadata-settings.interface';
|
|
|
|
import {
|
|
FieldMetadataException,
|
|
FieldMetadataExceptionCode,
|
|
} from 'src/engine/metadata-modules/field-metadata/field-metadata.exception';
|
|
|
|
enum ValueType {
|
|
PERCENTAGE = 'percentage',
|
|
NUMBER = 'number',
|
|
}
|
|
|
|
class NumberSettingsValidation {
|
|
@IsOptional()
|
|
@IsInt()
|
|
@Min(0)
|
|
decimals?: number;
|
|
|
|
@IsOptional()
|
|
@IsEnum(ValueType)
|
|
type?: 'percentage' | 'number';
|
|
}
|
|
|
|
class TextSettingsValidation {
|
|
@IsOptional()
|
|
@IsInt()
|
|
@Min(0)
|
|
@Max(100)
|
|
displayedMaxRows?: number;
|
|
}
|
|
|
|
@Injectable()
|
|
export class FieldMetadataValidationService<
|
|
T extends FieldMetadataType = FieldMetadataType,
|
|
> {
|
|
constructor() {}
|
|
|
|
async validateSettingsOrThrow({
|
|
fieldType,
|
|
settings,
|
|
}: {
|
|
fieldType: FieldMetadataType;
|
|
settings: FieldMetadataSettings<T>;
|
|
}) {
|
|
switch (fieldType) {
|
|
case FieldMetadataType.NUMBER:
|
|
await this.validateSettings(NumberSettingsValidation, settings);
|
|
break;
|
|
case FieldMetadataType.TEXT:
|
|
await this.validateSettings(TextSettingsValidation, settings);
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
private async validateSettings(validator: any, settings: any) {
|
|
try {
|
|
const settingsInstance = plainToInstance(validator, settings);
|
|
|
|
await validateOrReject(settingsInstance);
|
|
} catch (error) {
|
|
const errorMessages = Array.isArray(error)
|
|
? error
|
|
.map((err: any) => Object.values(err.constraints))
|
|
.flat()
|
|
.join(', ')
|
|
: error.message;
|
|
|
|
throw new FieldMetadataException(
|
|
`Value for settings is invalid: ${errorMessages}`,
|
|
FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
|
|
);
|
|
}
|
|
}
|
|
}
|