# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
264 lines
7.2 KiB
TypeScript
264 lines
7.2 KiB
TypeScript
import { computeInputFields } from '../../utils/computeInputFields';
|
||
import { InputField } from '../../utils/data.types';
|
||
import { FieldMetadataType } from 'twenty-shared/types';
|
||
|
||
describe('computeInputFields', () => {
|
||
test('should create Person input fields properly', () => {
|
||
const personNode = {
|
||
nameSingular: 'person',
|
||
namePlural: 'people',
|
||
labelSingular: 'Person',
|
||
fields: {
|
||
edges: [
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.RELATION,
|
||
name: 'favorites',
|
||
label: 'Favorites',
|
||
description: 'Favorites linked to the contact',
|
||
isNullable: true,
|
||
defaultValue: null,
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.CURRENCY,
|
||
name: 'annualSalary',
|
||
label: 'Annual Salary',
|
||
description: 'Annual Salary of the Person',
|
||
isNullable: true,
|
||
defaultValue: null,
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.TEXT,
|
||
name: 'jobTitle',
|
||
label: 'Job Title',
|
||
description: 'Contact’s job title',
|
||
isNullable: false,
|
||
defaultValue: {
|
||
value: '',
|
||
},
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.DATE_TIME,
|
||
name: 'updatedAt',
|
||
label: 'Update date',
|
||
description: null,
|
||
isNullable: false,
|
||
defaultValue: {
|
||
type: 'now',
|
||
},
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.FULL_NAME,
|
||
name: 'name',
|
||
label: 'Name',
|
||
description: 'Contact’s name',
|
||
isNullable: true,
|
||
defaultValue: {
|
||
lastName: '',
|
||
firstName: '',
|
||
},
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.UUID,
|
||
name: 'id',
|
||
label: 'Id',
|
||
description: null,
|
||
icon: null,
|
||
isNullable: false,
|
||
defaultValue: {
|
||
type: 'uuid',
|
||
},
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.NUMBER,
|
||
name: 'recordPosition',
|
||
label: 'RecordPosition',
|
||
description: 'Record Position',
|
||
isNullable: true,
|
||
defaultValue: null,
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.LINKS,
|
||
name: 'whatsapp',
|
||
label: 'Whatsapp',
|
||
description: 'Contact’s Whatsapp account',
|
||
isNullable: true,
|
||
defaultValue: null,
|
||
},
|
||
},
|
||
{
|
||
node: {
|
||
type: FieldMetadataType.UUID,
|
||
name: 'companyId',
|
||
label: 'Company id (foreign key)',
|
||
description: 'Contact’s company id foreign key',
|
||
isNullable: true,
|
||
defaultValue: null,
|
||
},
|
||
},
|
||
],
|
||
},
|
||
};
|
||
const baseExpectedResult: InputField[] = [
|
||
{
|
||
key: 'annualSalary__amountMicros',
|
||
label: 'Annual Salary: Amount Micros',
|
||
type: 'integer',
|
||
helpText:
|
||
'Annual Salary of the Person: Amount Micros. eg: set 3210000 for 3.21$',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'annualSalary__currencyCode',
|
||
label: 'Annual Salary: Currency Code',
|
||
type: 'string',
|
||
helpText:
|
||
'Annual Salary of the Person: Currency Code. eg: USD, EUR, etc...',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'jobTitle',
|
||
label: 'Job Title',
|
||
type: 'string',
|
||
helpText: 'Contact’s job title',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'updatedAt',
|
||
label: 'Update date',
|
||
type: 'datetime',
|
||
helpText: null,
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'name__firstName',
|
||
label: 'Name: First Name',
|
||
type: 'string',
|
||
helpText: 'Contact’s name: First Name',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'name__lastName',
|
||
label: 'Name: Last Name',
|
||
type: 'string',
|
||
helpText: 'Contact’s name: Last Name',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'recordPosition',
|
||
label: 'RecordPosition',
|
||
type: 'integer',
|
||
helpText: 'Record Position',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'xLink__url',
|
||
label: 'X: Url',
|
||
type: 'string',
|
||
helpText: 'Contact’s X/Twitter account: Link Url',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'xLink__label',
|
||
label: 'X: Label',
|
||
type: 'string',
|
||
helpText: 'Contact’s X/Twitter account: Link Label',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'whatsapp__primaryLinkLabel',
|
||
label: 'Whatsapp: Primary Link Label',
|
||
type: 'string',
|
||
helpText: 'Contact’s Whatsapp account: Primary Link Label',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'whatsapp__primaryLinkUrl',
|
||
label: 'Whatsapp: Primary Link Url',
|
||
type: 'string',
|
||
helpText: 'Contact’s Whatsapp account: Primary Link Url',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'whatsapp__secondaryLinks',
|
||
label: 'Whatsapp: Secondary Links',
|
||
type: 'string',
|
||
helpText: 'Contact’s Whatsapp account: Secondary Links',
|
||
required: false,
|
||
list: true,
|
||
placeholder: '{ url: "", label: "" }',
|
||
},
|
||
{
|
||
key: 'email',
|
||
label: 'Email',
|
||
type: 'string',
|
||
helpText: 'Contact’s Email',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
{
|
||
key: 'companyId',
|
||
label: 'Company id (foreign key)',
|
||
type: 'string',
|
||
helpText: 'Contact’s company id foreign key',
|
||
required: false,
|
||
list: false,
|
||
placeholder: undefined,
|
||
},
|
||
];
|
||
const idInputField: InputField = {
|
||
key: 'id',
|
||
label: 'Id',
|
||
type: 'string',
|
||
helpText: null,
|
||
list: false,
|
||
placeholder: undefined,
|
||
required: false,
|
||
};
|
||
const expectedResult = [idInputField].concat(baseExpectedResult);
|
||
expect(computeInputFields(personNode)).toEqual(expectedResult);
|
||
idInputField.required = true;
|
||
const idRequiredExpectedResult = [idInputField].concat(baseExpectedResult);
|
||
expect(computeInputFields(personNode, true)).toEqual(
|
||
idRequiredExpectedResult,
|
||
);
|
||
});
|
||
});
|