1c64b7b072
### Primary Changes: Dynamic Driver Configuration Refactors FileStorageService and EmailSenderService to support dynamic driver configuration changes at runtime without requiring application restarts. **Key Architectural Change**: Instead of conditionally registering drivers at build time based on configuration, we now **register all possible drivers eagerly** and select the appropriate one at runtime. ### What Changed: - **Before**: Modules conditionally registered only the configured driver (e.g., only S3Driver if STORAGE_TYPE=S3) - **After**: All drivers (LocalDriver, S3Driver, SmtpDriver, LoggerDriver) are registered at startup - **Runtime Selection**: Services dynamically choose and instantiate the correct driver based on current configuration ### Secondary Fix: Integration Test Log Cleanup Addresses ConfigStorageService error logs appearing in integration test output by using injected LoggerService for consistent log handling.
52 lines
1.6 KiB
TypeScript
52 lines
1.6 KiB
TypeScript
import { danger, markdown, schedule, warn } from 'danger';
|
|
import todos from 'danger-plugin-todos';
|
|
|
|
function getMdSection(category: string, message: string) {
|
|
return `# ${category} <br>${message}`;
|
|
}
|
|
|
|
// Check if package.json was changed, but not yarn.lock
|
|
const packageChanged = danger.git.modified_files.find((x) =>
|
|
x.includes('package.json'),
|
|
);
|
|
const lockfileChanged = danger.git.modified_files.find((x) =>
|
|
x.includes('yarn.lock'),
|
|
);
|
|
if (packageChanged && !lockfileChanged) {
|
|
const message = 'Changes were made to package.json, but not to yarn.lock';
|
|
const idea = 'Perhaps you need to run `yarn install`?';
|
|
warn(`${message} - <i>${idea}</i>`);
|
|
}
|
|
|
|
// Check environment configuration changes
|
|
const envExampleChanged = danger.git.modified_files.find((x) =>
|
|
x.includes('.env.example')
|
|
);
|
|
|
|
// Check if .env.example was changed
|
|
if (envExampleChanged) {
|
|
const message = 'Changes were made to .env.example';
|
|
const idea = 'Please make sure any new environment variables are properly documented with metadata in config-variables.ts';
|
|
warn(`${message} - <i>${idea}</i>`);
|
|
}
|
|
|
|
// CLA alert if first time contributor
|
|
if (
|
|
danger.github &&
|
|
danger.github.pr &&
|
|
(danger.github.pr.author_association === 'FIRST_TIME_CONTRIBUTOR' ||
|
|
danger.github.pr.author_association === 'NONE')
|
|
) {
|
|
markdown(
|
|
getMdSection(
|
|
'Welcome!',
|
|
`
|
|
Hello there, congrats on your first PR! We're excited to have you contributing to this project.
|
|
By submitting your Pull Request, you acknowledge that you agree with the terms of our [Contributor License Agreement](https://github.com/twentyhq/twenty/blob/main/.github/CLA.md).`,
|
|
),
|
|
);
|
|
}
|
|
|
|
// TODOS / Fixme
|
|
schedule(todos());
|