fb42046033
In this huge (sorry!) PR: - introducing objectMetadataItem in contextStore instead of objectMetadataId which is more convenient - splitting some big hooks into smaller parts to avoid re-renders - removing Effects to avoid re-renders (especially onViewChange) - making the view prefetch separate from favorites to avoid re-renders - making the view prefetch load a state and add selectors on top of it to avoir re-renders As a result, the performance is WAY better (I suspect the favorite implementation to trigger a lot of re-renders unfortunately). However, we are still facing a random app freeze on view creation. I could not investigate the root cause. As this seems to be already there in the precedent release, we can move forward but this seems a urgent follow up to me ==> EDIT: I've found the root cause after a few ours of deep dive... an infinite loop in RecordTableNoRecordGroupBodyEffect... prastoin edit: close https://github.com/twentyhq/twenty/issues/10253 --------- Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> Co-authored-by: prastoin <paul@twenty.com>
34 lines
1.2 KiB
TypeScript
34 lines
1.2 KiB
TypeScript
import { sortFavorites } from '@/favorites/utils/sortFavorites';
|
|
import { prefetchViewsState } from '@/prefetch/states/prefetchViewsState';
|
|
import { useRecoilValue } from 'recoil';
|
|
import { useFavoritesMetadata } from './useFavoritesMetadata';
|
|
import { usePrefetchedFavoritesData } from './usePrefetchedFavoritesData';
|
|
import { usePrefetchedFavoritesFoldersData } from './usePrefetchedFavoritesFoldersData';
|
|
|
|
export const useFavoritesByFolder = () => {
|
|
const { favorites } = usePrefetchedFavoritesData();
|
|
const { favoriteFolders } = usePrefetchedFavoritesFoldersData();
|
|
const {
|
|
objectMetadataItems,
|
|
getObjectRecordIdentifierByNameSingular,
|
|
favoriteRelationFields,
|
|
} = useFavoritesMetadata();
|
|
|
|
const prefetchViews = useRecoilValue(prefetchViewsState);
|
|
|
|
const favoritesByFolder = favoriteFolders.map((folder) => ({
|
|
folderId: folder.id,
|
|
folderName: folder.name,
|
|
favorites: sortFavorites(
|
|
favorites.filter((favorite) => favorite.favoriteFolderId === folder.id),
|
|
favoriteRelationFields,
|
|
getObjectRecordIdentifierByNameSingular,
|
|
true,
|
|
prefetchViews,
|
|
objectMetadataItems,
|
|
),
|
|
}));
|
|
|
|
return { favoritesByFolder };
|
|
};
|