Fix https://github.com/twentyhq/core-team-issues/issues/330#issue-2827026606 and https://github.com/twentyhq/core-team-issues/issues/327#issue-2827001814 What this PR does when `isNewRelationEnabled` is set to `true`: - [x] Drop the creation of the foreign key as a `FieldMetadata` - [x] Stop creating `RelationMetadata` - [x] Properly fill `FieldMetadata` of type `RELATION` during the sync command - [x] Use new relation settings in TwentyORM - [x] Properly create `FieldMetadata` relations when we create a new object - [x] Handle `database:reset` with new relations --------- Co-authored-by: Charles Bochet <charles@twenty.com> Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
85 lines
3.1 KiB
TypeScript
85 lines
3.1 KiB
TypeScript
import { RelationType } from 'src/engine/metadata-modules/field-metadata/interfaces/relation-type.interface';
|
|
import { WorkspaceJoinColumnsMetadataArgs } from 'src/engine/twenty-orm/interfaces/workspace-join-columns-metadata-args.interface';
|
|
import { WorkspaceRelationMetadataArgs } from 'src/engine/twenty-orm/interfaces/workspace-relation-metadata-args.interface';
|
|
|
|
import { metadataArgsStorage } from 'src/engine/twenty-orm/storage/metadata-args.storage';
|
|
|
|
export const getJoinColumn = (
|
|
joinColumnsMetadataArgsCollection: WorkspaceJoinColumnsMetadataArgs[],
|
|
relationMetadataArgs: WorkspaceRelationMetadataArgs,
|
|
opposite = false,
|
|
): string | null => {
|
|
if (relationMetadataArgs.type === RelationType.ONE_TO_MANY) {
|
|
return null;
|
|
}
|
|
|
|
const inverseSideTarget = relationMetadataArgs.inverseSideTarget();
|
|
const inverseSideJoinColumnsMetadataArgsCollection =
|
|
metadataArgsStorage.filterJoinColumns(inverseSideTarget);
|
|
const filteredJoinColumnsMetadataArgsCollection =
|
|
joinColumnsMetadataArgsCollection.filter(
|
|
(joinColumnsMetadataArgs) =>
|
|
joinColumnsMetadataArgs.relationName === relationMetadataArgs.name,
|
|
);
|
|
const oppositeFilteredJoinColumnsMetadataArgsCollection =
|
|
inverseSideJoinColumnsMetadataArgsCollection.filter(
|
|
(joinColumnsMetadataArgs) =>
|
|
joinColumnsMetadataArgs.relationName === relationMetadataArgs.name,
|
|
);
|
|
|
|
if (
|
|
filteredJoinColumnsMetadataArgsCollection.length > 0 &&
|
|
oppositeFilteredJoinColumnsMetadataArgsCollection.length > 0
|
|
) {
|
|
throw new Error(
|
|
`Join column for ${relationMetadataArgs.name} relation is present on both sides`,
|
|
);
|
|
}
|
|
|
|
// If we're in a ONE_TO_ONE relation and there are no join columns, we need to find the join column on the inverse side
|
|
if (
|
|
relationMetadataArgs.type === RelationType.ONE_TO_ONE &&
|
|
filteredJoinColumnsMetadataArgsCollection.length === 0 &&
|
|
!opposite
|
|
) {
|
|
const inverseSideRelationMetadataArgsCollection =
|
|
metadataArgsStorage.filterRelations(inverseSideTarget);
|
|
const inverseSideRelationMetadataArgs =
|
|
inverseSideRelationMetadataArgsCollection.find(
|
|
(inverseSideRelationMetadataArgs) =>
|
|
inverseSideRelationMetadataArgs.inverseSideFieldKey ===
|
|
relationMetadataArgs.name,
|
|
);
|
|
|
|
if (!inverseSideRelationMetadataArgs) {
|
|
throw new Error(
|
|
`Inverse side join column of relation ${relationMetadataArgs.name} is missing`,
|
|
);
|
|
}
|
|
|
|
return getJoinColumn(
|
|
inverseSideJoinColumnsMetadataArgsCollection,
|
|
inverseSideRelationMetadataArgs,
|
|
// Avoid infinite recursion
|
|
true,
|
|
);
|
|
}
|
|
|
|
// Check if there are multiple join columns for the relation
|
|
if (filteredJoinColumnsMetadataArgsCollection.length > 1) {
|
|
throw new Error(
|
|
`Multiple join columns found for relation ${relationMetadataArgs.name}`,
|
|
);
|
|
}
|
|
|
|
const joinColumnsMetadataArgs = filteredJoinColumnsMetadataArgsCollection[0];
|
|
|
|
if (!joinColumnsMetadataArgs) {
|
|
throw new Error(
|
|
`Join column is missing for relation ${relationMetadataArgs.name}`,
|
|
);
|
|
}
|
|
|
|
return joinColumnsMetadataArgs.joinColumn;
|
|
};
|