03b3c8a67a
This PR is the second part of https://github.com/twentyhq/twenty/pull/5693. It optimizes all remaining field types. The observed improvements are : - x2 loading time improvement on table rows - more consistent render time Here's a summary of measured improvements, what's given here is the average of hundreds of renders with a React Profiler component. (in our Storybook performance stories) | Component | Before (µs) | After (µs) | | ----- | ------------- | --- | | TextFieldDisplay | 127 | 83 | | EmailFieldDisplay | 117 | 83 | | NumberFieldDisplay | 97 | 56 | | DateFieldDisplay | 240 | 52 | | CurrencyFieldDisplay | 236 | 110 | | FullNameFieldDisplay | 131 | 85 | | AddressFieldDisplay | 118 | 81 | | BooleanFieldDisplay | 130 | 100 | | JSONFieldDisplay | 248 | 49 | | LinksFieldDisplay | 1180 | 140 | | LinkFieldDisplay | 140 | 78 | | MultiSelectFieldDisplay | 770 | 130 | | SelectFieldDisplay | 230 | 87 |
26 lines
638 B
TypeScript
26 lines
638 B
TypeScript
import * as React from 'react';
|
|
|
|
import { getDisplayValueByUrlType } from '~/utils/getDisplayValueByUrlType';
|
|
|
|
import { RoundedLink } from './RoundedLink';
|
|
|
|
export enum LinkType {
|
|
Url = 'url',
|
|
LinkedIn = 'linkedin',
|
|
Twitter = 'twitter',
|
|
}
|
|
|
|
type SocialLinkProps = {
|
|
label: string;
|
|
href: string;
|
|
type: LinkType;
|
|
onClick?: (event: React.MouseEvent<HTMLElement>) => void;
|
|
};
|
|
|
|
export const SocialLink = ({ label, href, onClick, type }: SocialLinkProps) => {
|
|
const displayValue =
|
|
getDisplayValueByUrlType({ type: type, href: href }) ?? label;
|
|
|
|
return <RoundedLink href={href} onClick={onClick} label={displayValue} />;
|
|
};
|