4a4e65fe4a
# Introduction closes https://github.com/twentyhq/core-team-issues/issues/591 Same than for `twenty-shared` made in https://github.com/twentyhq/twenty/pull/11083. ## TODO - [x] Manual migrate twenty-website twenty-ui imports ## What's next: - Generate barrel and migration script factorization within own package + tests - Refactoring using preconstruct ? TimeBox - Lint circular dependencies - Lint import from barrel and forbid them ### Preconstruct We need custom rollup plugins addition, but preconstruct does not expose its rollup configuration. It might be possible to handle this using the babel overrides. But was a big tunnel. We could give it a try afterwards ! ( allowing cjs interop and stuff like that ) Stuck to vite lib app Closed related PRs: - https://github.com/twentyhq/twenty/pull/11294 - https://github.com/twentyhq/twenty/pull/11203
16 lines
480 B
TypeScript
16 lines
480 B
TypeScript
import { isDefined } from 'twenty-shared/utils';
|
|
import { Nullable } from 'twenty-ui/utilities';
|
|
|
|
// TODO: we should create a custom eslint rule that enforces the use of this function
|
|
// instead of using the `===` operator where a and b are | undefined | null
|
|
export const compareStrictlyExceptForNullAndUndefined = <A, B>(
|
|
valueA: Nullable<A>,
|
|
valueB: Nullable<B>,
|
|
) => {
|
|
if (!isDefined(valueA) && !isDefined(valueB)) {
|
|
return true;
|
|
}
|
|
|
|
return valueA === valueB;
|
|
};
|