In this PR, I'm fixing a bug introduced in recent performance work on the cache. Bug context: https://github.com/twentyhq/twenty/issues/12865 Related PR opened by a contributor: https://github.com/twentyhq/twenty/pull/13003 ## Root cause We cache all objectMetadataItems at graphql level : see `useCachedMetadata` hook: - instead of going through the regular resolvers, we direlcty load data from the cache. However this data must be localized regarding labels and descriptions In a precedent refactoring, we introduced the notion of locale in the cache key. However, the user locale was not properly taken into account as we did not have the information in this hook. ## Fix 1. **Introduce locale in userWorkspace entity**. The locale is stored on workspaceMember in each postgres workspaceSchema (workspace_xxx) which is the alter ego of userWorkspace in postgres core schema. Note that we can't store it in user as a user can be part of multiple workspaces (the locale already there must be seen as a default for this user), and we cannot rely on workspaceMember as we would need to query the workspaceSchema in the authentication layer which we want to avoid for performance reasons. 2. During request hydration from token (containing the userWorkspaceId), we fetch the userWorkspace and store it in the Request (this impact both AuthContext and Request interface) 3. Leverage userWorkspace.locale in the useCachedMetadata hook ## Additional notes There is no need to change the way we store and retrieve the object-metadata-maps object itself which is different from the graphql layer cache. object-metadadata-maps are not localized
176 lines
5.9 KiB
TypeScript
176 lines
5.9 KiB
TypeScript
import { Injectable } from '@nestjs/common';
|
|
|
|
import { Request, Response } from 'express';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
|
|
import { AuthGraphqlApiExceptionFilter } from 'src/engine/core-modules/auth/filters/auth-graphql-api-exception.filter';
|
|
import { AccessTokenService } from 'src/engine/core-modules/auth/token/services/access-token.service';
|
|
import { AuthContext } from 'src/engine/core-modules/auth/types/auth-context.type';
|
|
import { getAuthExceptionRestStatus } from 'src/engine/core-modules/auth/utils/get-auth-exception-rest-status.util';
|
|
import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
|
|
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
|
|
import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
|
|
import { DataSourceService } from 'src/engine/metadata-modules/data-source/data-source.service';
|
|
import { WorkspaceMetadataCacheService } from 'src/engine/metadata-modules/workspace-metadata-cache/services/workspace-metadata-cache.service';
|
|
import { INTERNAL_SERVER_ERROR } from 'src/engine/middlewares/constants/default-error-message.constant';
|
|
import {
|
|
handleException,
|
|
handleExceptionAndConvertToGraphQLError,
|
|
} from 'src/engine/utils/global-exception-handler.util';
|
|
import { WorkspaceCacheStorageService } from 'src/engine/workspace-cache-storage/workspace-cache-storage.service';
|
|
import { CustomException } from 'src/utils/custom-exception';
|
|
|
|
@Injectable()
|
|
export class MiddlewareService {
|
|
constructor(
|
|
private readonly accessTokenService: AccessTokenService,
|
|
private readonly workspaceStorageCacheService: WorkspaceCacheStorageService,
|
|
private readonly workspaceMetadataCacheService: WorkspaceMetadataCacheService,
|
|
private readonly dataSourceService: DataSourceService,
|
|
private readonly exceptionHandlerService: ExceptionHandlerService,
|
|
private readonly jwtWrapperService: JwtWrapperService,
|
|
) {}
|
|
|
|
public isTokenPresent(request: Request): boolean {
|
|
const token = this.jwtWrapperService.extractJwtFromRequest()(request);
|
|
|
|
return !!token;
|
|
}
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
public writeRestResponseOnExceptionCaught(res: Response, error: any) {
|
|
const statusCode = this.getStatus(error);
|
|
|
|
// capture and handle custom exceptions
|
|
handleException({
|
|
exception: error as CustomException,
|
|
exceptionHandlerService: this.exceptionHandlerService,
|
|
statusCode,
|
|
});
|
|
|
|
res.writeHead(statusCode, { 'Content-Type': 'application/json' });
|
|
res.write(
|
|
JSON.stringify({
|
|
statusCode,
|
|
messages: [error?.message || INTERNAL_SERVER_ERROR],
|
|
error: error?.code || ErrorCode.INTERNAL_SERVER_ERROR,
|
|
}),
|
|
);
|
|
|
|
res.end();
|
|
}
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
public writeGraphqlResponseOnExceptionCaught(res: Response, error: any) {
|
|
let errors;
|
|
|
|
if (error instanceof AuthException) {
|
|
try {
|
|
const authFilter = new AuthGraphqlApiExceptionFilter();
|
|
|
|
authFilter.catch(error);
|
|
} catch (transformedError) {
|
|
errors = [transformedError];
|
|
}
|
|
} else {
|
|
errors = [
|
|
handleExceptionAndConvertToGraphQLError(
|
|
error as Error,
|
|
this.exceptionHandlerService,
|
|
),
|
|
];
|
|
}
|
|
|
|
const statusCode = 200;
|
|
|
|
res.writeHead(statusCode, {
|
|
'Content-Type': 'application/json',
|
|
});
|
|
|
|
res.write(
|
|
JSON.stringify({
|
|
errors,
|
|
}),
|
|
);
|
|
|
|
res.end();
|
|
}
|
|
|
|
public async hydrateRestRequest(request: Request) {
|
|
const data = await this.accessTokenService.validateTokenByRequest(request);
|
|
const metadataVersion = data.workspace
|
|
? await this.workspaceStorageCacheService.getMetadataVersion(
|
|
data.workspace.id,
|
|
)
|
|
: undefined;
|
|
|
|
if (metadataVersion === undefined && isDefined(data.workspace)) {
|
|
await this.workspaceMetadataCacheService.recomputeMetadataCache({
|
|
workspaceId: data.workspace.id,
|
|
});
|
|
throw new Error('Metadata cache version not found');
|
|
}
|
|
|
|
const dataSourcesMetadata = data.workspace
|
|
? await this.dataSourceService.getDataSourcesMetadataFromWorkspaceId(
|
|
data.workspace.id,
|
|
)
|
|
: undefined;
|
|
|
|
if (!dataSourcesMetadata || dataSourcesMetadata.length === 0) {
|
|
throw new Error('No data sources found');
|
|
}
|
|
|
|
this.bindDataToRequestObject(data, request, metadataVersion);
|
|
}
|
|
|
|
public async hydrateGraphqlRequest(request: Request) {
|
|
if (!this.isTokenPresent(request)) {
|
|
return;
|
|
}
|
|
|
|
const data = await this.accessTokenService.validateTokenByRequest(request);
|
|
const metadataVersion = data.workspace
|
|
? await this.workspaceStorageCacheService.getMetadataVersion(
|
|
data.workspace.id,
|
|
)
|
|
: undefined;
|
|
|
|
this.bindDataToRequestObject(data, request, metadataVersion);
|
|
}
|
|
|
|
private hasErrorStatus(error: unknown): error is { status: number } {
|
|
return isDefined((error as { status: number })?.status);
|
|
}
|
|
|
|
private bindDataToRequestObject(
|
|
data: AuthContext,
|
|
request: Request,
|
|
metadataVersion: number | undefined,
|
|
) {
|
|
request.user = data.user;
|
|
request.apiKey = data.apiKey;
|
|
request.userWorkspace = data.userWorkspace;
|
|
request.workspace = data.workspace;
|
|
request.workspaceId = data.workspace?.id;
|
|
request.workspaceMetadataVersion = metadataVersion;
|
|
request.workspaceMemberId = data.workspaceMemberId;
|
|
request.userWorkspaceId = data.userWorkspaceId;
|
|
request.authProvider = data.authProvider;
|
|
}
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
private getStatus(error: any): number {
|
|
if (this.hasErrorStatus(error)) {
|
|
return error.status;
|
|
}
|
|
|
|
if (error instanceof AuthException) {
|
|
return getAuthExceptionRestStatus(error);
|
|
}
|
|
|
|
return 500;
|
|
}
|
|
}
|