fb42046033
In this huge (sorry!) PR: - introducing objectMetadataItem in contextStore instead of objectMetadataId which is more convenient - splitting some big hooks into smaller parts to avoid re-renders - removing Effects to avoid re-renders (especially onViewChange) - making the view prefetch separate from favorites to avoid re-renders - making the view prefetch load a state and add selectors on top of it to avoir re-renders As a result, the performance is WAY better (I suspect the favorite implementation to trigger a lot of re-renders unfortunately). However, we are still facing a random app freeze on view creation. I could not investigate the root cause. As this seems to be already there in the precedent release, we can move forward but this seems a urgent follow up to me ==> EDIT: I've found the root cause after a few ours of deep dive... an infinite loop in RecordTableNoRecordGroupBodyEffect... prastoin edit: close https://github.com/twentyhq/twenty/issues/10253 --------- Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> Co-authored-by: prastoin <paul@twenty.com>
31 lines
823 B
TypeScript
31 lines
823 B
TypeScript
import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
|
|
import { View } from '@/views/types/View';
|
|
import { isDefined } from 'twenty-shared';
|
|
|
|
type ReturnType = {
|
|
labelPlural: string;
|
|
view: Pick<View, 'id' | 'name' | 'objectMetadataId'>;
|
|
};
|
|
|
|
export const getObjectMetadataLabelPluralFromViewId = (
|
|
view: Pick<View, 'id' | 'name' | 'objectMetadataId'>,
|
|
objectMetadataItems: ObjectMetadataItem[],
|
|
): ReturnType => {
|
|
const objectMetadataItem = objectMetadataItems.find(
|
|
(objectMetadataItem) => objectMetadataItem.id === view.objectMetadataId,
|
|
);
|
|
|
|
if (!isDefined(objectMetadataItem)) {
|
|
throw new Error(
|
|
`Object metadata item not found for id ${view.objectMetadataId}`,
|
|
);
|
|
}
|
|
|
|
const { labelPlural } = objectMetadataItem;
|
|
|
|
return {
|
|
labelPlural,
|
|
view,
|
|
};
|
|
};
|