Remove overlay-scroll-bar (#11258)

## What

- Deprecate overlayscrollbars as we decided to follow the native
behavior
- rework on performances (avoid calling recoil states too much at field
level which is quite expensive)
- Also implements:
https://github.com/twentyhq/core-team-issues/issues/569

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>

packages/twenty-front/src/modules/activities/hooks/useActivityTargetObjectRecords.ts

@@ -1,14 +1,12 @@
 import { useRecoilValue } from 'recoil';
 
-import { ActivityTargetWithTargetRecord } from '@/activities/types/ActivityTargetObject';
 import { Note } from '@/activities/types/Note';
 import { NoteTarget } from '@/activities/types/NoteTarget';
 import { Task } from '@/activities/types/Task';
 import { TaskTarget } from '@/activities/types/TaskTarget';
+import { getActivityTargetObjectRecords } from '@/activities/utils/getActivityTargetObjectRecords';
 import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadataItemsState';
-import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
-import { ObjectRecord } from '@/object-record/types/ObjectRecord';
 import { isDefined } from 'twenty-shared/utils';
 
 export const useActivityTargetObjectRecords = (
@@ -25,49 +23,11 @@ export const useActivityTargetObjectRecords = (
     return { activityTargetObjectRecords: [] };
   }
 
-  const targets = activityTargets
-    ? activityTargets
-    : activity && 'noteTargets' in activity && activity.noteTargets
-      ? activity.noteTargets
-      : activity && 'taskTargets' in activity && activity.taskTargets
-        ? activity.taskTargets
-        : [];
-
-  const activityTargetObjectRecords = targets
-    .map<ActivityTargetWithTargetRecord | undefined>((activityTarget) => {
-      if (!isDefined(activityTarget)) {
-        throw new Error(`Cannot find activity target`);
-      }
-
-      const correspondingObjectMetadataItem = objectMetadataItems.find(
-        (objectMetadataItem) =>
-          isDefined(activityTarget[objectMetadataItem.nameSingular]) &&
-          ![CoreObjectNameSingular.Note, CoreObjectNameSingular.Task].includes(
-            objectMetadataItem.nameSingular as CoreObjectNameSingular,
-          ),
-      );
-
-      if (!correspondingObjectMetadataItem) {
-        return undefined;
-      }
-
-      const targetObjectRecord = activityTarget[
-        correspondingObjectMetadataItem.nameSingular
-      ] as ObjectRecord | undefined;
-
-      if (!isDefined(targetObjectRecord)) {
-        throw new Error(
-          `Cannot find target object record of type ${correspondingObjectMetadataItem.nameSingular}, make sure the request for activities eagerly loads for the target objects on activity target relation.`,
-        );
-      }
-
-      return {
-        activityTarget,
-        targetObject: targetObjectRecord,
-        targetObjectMetadataItem: correspondingObjectMetadataItem,
-      };
-    })
-    .filter(isDefined);
+  const activityTargetObjectRecords = getActivityTargetObjectRecords({
+    activityRecord: activity as Note | Task,
+    objectMetadataItems,
+    activityTargets,
+  });
 
   return {
     activityTargetObjectRecords,