Fix view deletion (#2314)

* fix view deletion

* fix view deletion bugs

* improve code readability
This commit is contained in:
bosiraphael
2023-11-02 12:17:50 +01:00
committed by GitHub
parent 8080353075
commit 27b451ee56
4 changed files with 27 additions and 19 deletions

View File

@ -227,20 +227,22 @@ export const useView = (props?: UseViewProps) => {
const removeView = useRecoilCallback(
({ set, snapshot }) =>
async (viewId: string) => {
async (viewIdToDelete: string) => {
const currentViewId = await snapshot.getPromise(
currentViewIdScopedState({ scopeId }),
);
if (currentViewId === viewId)
if (currentViewId === viewIdToDelete)
set(currentViewIdScopedState({ scopeId }), undefined);
set(viewsScopedState({ scopeId }), (previousViews) =>
previousViews.filter((view) => view.id !== viewId),
previousViews.filter((view) => view.id !== viewIdToDelete),
);
internalDeleteView(viewId);
internalDeleteView(viewIdToDelete);
if (currentViewId === viewIdToDelete) setSearchParams();
},
[internalDeleteView, scopeId],
[internalDeleteView, scopeId, setSearchParams],
);
const handleViewNameSubmit = useRecoilCallback(