mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: unexpected behavior when deleting Option A and renaming Option B with Option A's value. (#13204)

Browse Source 
resolve #12345
The issue was caused by the delete running after the update, which led
to both the old and new options being deleted when they shared the same
value.

---------

Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu>
This commit is contained in:
Naifer
2025-07-15 15:06:27 +01:00
committed by GitHub
parent df9d2b57f9
commit 2c7a459634
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-server/src/engine/metadata-modules/field-metadata/services/field-metadata-related-records.service.ts
View File

@ -71,7 +71,12 @@ export class FieldMetadataRelatedRecordsService {
if (view.viewGroups.length === 0) {
continue;
}
const valuesToDelete = deleted.map((option) => option.value);
await viewGroupRepository.delete({
fieldMetadataId: newFieldMetadata.id,
fieldValue: In(valuesToDelete),
});
const maxPosition = this.getMaxPosition(view.viewGroups);
const viewGroupsToCreate = created.map((option, index) =>
@ -103,13 +108,6 @@ export class FieldMetadataRelatedRecordsService {
);
}
const valuesToDelete = deleted.map((option) => option.value);
await viewGroupRepository.delete({
fieldMetadataId: newFieldMetadata.id,
fieldValue: In(valuesToDelete),
});
await this.syncNoValueViewGroup(
newFieldMetadata,
view,

6
packages/twenty-server/src/engine/workspace-manager/workspace-migration-runner/services/workspace-migration-enum.service.ts
View File

@ -139,8 +139,14 @@ export class WorkspaceMigrationEnumService {
}
if (allEnumValues?.includes(value)) {
const isDestinationOfRename = renamedEnumValues?.some(
(enumVal) => enumVal.to === value,
);
if (!isDestinationOfRename) {
return value;
}
}
if (isDefined(defaultValueFallback)) {
return defaultValueFallback;