fix: impact too many records (#3993)

* fix: impact too many records

* fix: change env name

* fix: remove env name from error

packages/twenty-server/src/workspace/workspace-query-runner/utils/compute-pg-graphql-error.util.ts

@@ -0,0 +1,34 @@
+import {
+  BadRequestException,
+  HttpException,
+  InternalServerErrorException,
+} from '@nestjs/common';
+
+interface PgGraphQLErrorMapping {
+  [key: string]: (command: string, objectName: string) => HttpException;
+}
+
+const pgGraphQLErrorMapping: PgGraphQLErrorMapping = {
+  'delete impacts too many records': (command, objectName) =>
+    new BadRequestException(
+      `Cannot ${command} ${objectName} because it impacts too many records.`,
+    ),
+};
+
+export const computePgGraphQLError = (
+  command: string,
+  objectName: string,
+  errors: any[],
+) => {
+  const error = errors[0];
+  const errorMessage = error?.message;
+  const mappedError = pgGraphQLErrorMapping[errorMessage];
+
+  if (mappedError) {
+    return mappedError(command, objectName);
+  }
+
+  return new InternalServerErrorException(
+    `GraphQL errors on ${command}${objectName}: ${JSON.stringify(error)}`,
+  );
+};

packages/twenty-server/src/workspace/workspace-query-runner/workspace-query-runner.service.ts

@@ -1,9 +1,4 @@
-import {
-  BadRequestException,
-  Inject,
-  Injectable,
-  InternalServerErrorException,
-} from '@nestjs/common';
+import { BadRequestException, Inject, Injectable } from '@nestjs/common';
 import { EventEmitter2 } from '@nestjs/event-emitter';
 
 import { IConnection } from 'src/utils/pagination/interfaces/connection.interface';
@@ -39,12 +34,14 @@ import { ObjectRecordDeleteEvent } from 'src/integrations/event-emitter/types/ob
 import { ObjectRecordCreateEvent } from 'src/integrations/event-emitter/types/object-record-create.event';
 import { ObjectRecordUpdateEvent } from 'src/integrations/event-emitter/types/object-record-update.event';
 import { WorkspacePreQueryHookService } from 'src/workspace/workspace-query-runner/workspace-pre-query-hook/workspace-pre-query-hook.service';
+import { EnvironmentService } from 'src/integrations/environment/environment.service';
 
 import { WorkspaceQueryRunnerOptions } from './interfaces/query-runner-option.interface';
 import {
   PGGraphQLMutation,
   PGGraphQLResult,
 } from './interfaces/pg-graphql.interface';
+import { computePgGraphQLError } from './utils/compute-pg-graphql-error.util';
 
 @Injectable()
 export class WorkspaceQueryRunnerService {
@@ -55,6 +52,7 @@ export class WorkspaceQueryRunnerService {
     private readonly messageQueueService: MessageQueueService,
     private readonly eventEmitter: EventEmitter2,
     private readonly workspacePreQueryHookService: WorkspacePreQueryHookService,
+    private readonly environmentService: EnvironmentService,
   ) {}
 
   async findMany<
@@ -218,10 +216,12 @@ export class WorkspaceQueryRunnerService {
     options: WorkspaceQueryRunnerOptions,
   ): Promise<Record[] | undefined> {
     const { workspaceId, objectMetadataItem } = options;
-    const query = await this.workspaceQueryBuilderFactory.updateMany(
-      args,
-      options,
-    );
+    const maximumRecordAffected =
+      this.environmentService.getMutationMaximumRecordAffected();
+    const query = await this.workspaceQueryBuilderFactory.updateMany(args, {
+      ...options,
+      atMost: maximumRecordAffected,
+    });
 
     const result = await this.execute(query, workspaceId);
 
@@ -248,10 +248,12 @@ export class WorkspaceQueryRunnerService {
     options: WorkspaceQueryRunnerOptions,
   ): Promise<Record[] | undefined> {
     const { workspaceId, objectMetadataItem } = options;
-    const query = await this.workspaceQueryBuilderFactory.deleteMany(
-      args,
-      options,
-    );
+    const maximumRecordAffected =
+      this.environmentService.getMutationMaximumRecordAffected();
+    const query = await this.workspaceQueryBuilderFactory.deleteMany(args, {
+      ...options,
+      atMost: maximumRecordAffected,
+    });
 
     const result = await this.execute(query, workspaceId);
 
@@ -337,16 +339,16 @@ export class WorkspaceQueryRunnerService {
       );
 
     await workspaceDataSource?.query(`
-      SET search_path TO ${this.workspaceDataSourceService.getSchemaName(
-        workspaceId,
-      )};
-    `);
+        SET search_path TO ${this.workspaceDataSourceService.getSchemaName(
+          workspaceId,
+        )};
+      `);
 
     const results = await workspaceDataSource?.query<PGGraphQLResult>(`
-      SELECT graphql.resolve($$
-        ${query}
-      $$);
-    `);
+        SELECT graphql.resolve($$
+          ${query}
+        $$);
+      `);
 
     return results;
   }
@@ -363,11 +365,13 @@ export class WorkspaceQueryRunnerService {
     const errors = graphqlResult?.[0]?.resolve?.errors;
 
     if (errors && errors.length > 0) {
-      throw new InternalServerErrorException(
-        `GraphQL errors on ${command}${
-          objectMetadataItem.nameSingular
-        }: ${JSON.stringify(errors)}`,
+      const error = computePgGraphQLError(
+        command,
+        objectMetadataItem.nameSingular,
+        errors,
       );
+
+      throw error;
     }
 
     return parseResult(result);