Remove old relations (#11993)

This is a first PR to remove old relation logic

Next steps:
- remove relationMetadata from cache
- remove relationMetadata table content and structure
- refactor relationDefinition to leverage field.settings instead

packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts

@@ -10,8 +10,6 @@ import { FindManyOptions, FindOneOptions, In, Not, Repository } from 'typeorm';
 
 import { ObjectMetadataStandardIdToIdMap } from 'src/engine/metadata-modules/object-metadata/interfaces/object-metadata-standard-id-to-id-map';
 
-import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
 import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';
 import { DataSourceService } from 'src/engine/metadata-modules/data-source/data-source.service';
 import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
@@ -29,7 +27,6 @@ import {
 import { ObjectMetadataFieldRelationService } from 'src/engine/metadata-modules/object-metadata/services/object-metadata-field-relation.service';
 import { ObjectMetadataMigrationService } from 'src/engine/metadata-modules/object-metadata/services/object-metadata-migration.service';
 import { ObjectMetadataRelatedRecordsService } from 'src/engine/metadata-modules/object-metadata/services/object-metadata-related-records.service';
-import { ObjectMetadataRelationService } from 'src/engine/metadata-modules/object-metadata/services/object-metadata-relation.service';
 import { buildDefaultFieldsForCustomObject } from 'src/engine/metadata-modules/object-metadata/utils/build-default-fields-for-custom-object.util';
 import {
   validateLowerCasedAndTrimmedStringsAreDifferentOrThrow,
@@ -64,13 +61,11 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
     private readonly workspaceMigrationRunnerService: WorkspaceMigrationRunnerService,
     private readonly workspaceMetadataVersionService: WorkspaceMetadataVersionService,
     private readonly searchVectorService: SearchVectorService,
-    private readonly objectMetadataRelationService: ObjectMetadataRelationService,
     private readonly objectMetadataFieldRelationService: ObjectMetadataFieldRelationService,
     private readonly objectMetadataMigrationService: ObjectMetadataMigrationService,
     private readonly objectMetadataRelatedRecordsService: ObjectMetadataRelatedRecordsService,
     private readonly indexMetadataService: IndexMetadataService,
     private readonly workspacePermissionsCacheService: WorkspacePermissionsCacheService,
-    private readonly featureFlagService: FeatureFlagService,
   ) {
     super(objectMetadataRepository);
   }
@@ -188,33 +183,12 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
         createdObjectMetadata.fields,
       );
 
-      const isNewRelationEnabled =
-        await this.featureFlagService.isFeatureEnabled(
-          FeatureFlagKey.IsNewRelationEnabled,
+      const createdRelatedObjectMetadataCollection =
+        await this.objectMetadataFieldRelationService.createRelationsAndForeignKeysMetadata(
           objectMetadataInput.workspaceId,
+          createdObjectMetadata,
         );
 
-      let createdRelatedObjectMetadataCollection: ObjectMetadataEntity[];
-
-      if (isNewRelationEnabled) {
-        createdRelatedObjectMetadataCollection =
-          await this.objectMetadataFieldRelationService.createRelationsAndForeignKeysMetadata(
-            objectMetadataInput.workspaceId,
-            createdObjectMetadata,
-          );
-      } else {
-        createdRelatedObjectMetadataCollection =
-          await this.objectMetadataRelationService.createRelationsAndForeignKeysMetadata(
-            objectMetadataInput.workspaceId,
-            createdObjectMetadata,
-            {
-              primaryKeyFieldMetadataSettings:
-                objectMetadataInput.primaryKeyFieldMetadataSettings,
-              primaryKeyColumnType: objectMetadataInput.primaryKeyColumnType,
-            },
-          );
-      }
-
       await this.objectMetadataMigrationService.createRelationMigrations(
         createdObjectMetadata,
         createdRelatedObjectMetadataCollection,
@@ -316,27 +290,12 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
 
     const updatedObject = await super.updateOne(inputId, inputPayload);
 
-    const isNewRelationEnabled = await this.featureFlagService.isFeatureEnabled(
-      FeatureFlagKey.IsNewRelationEnabled,
-      workspaceId,
-    );
-
     await this.handleObjectNameAndLabelUpdates(
       existingObjectMetadata,
       existingObjectMetadataCombinedWithUpdateInput,
       inputPayload,
     );
 
-    if (inputPayload.isActive !== undefined) {
-      // For new relation system, the active status is stitched to the field metadata
-      if (!isNewRelationEnabled) {
-        await this.objectMetadataRelationService.updateObjectRelationshipsActivationStatus(
-          inputId,
-          inputPayload.isActive,
-        );
-      }
-    }
-
     await this.workspaceMigrationRunnerService.executeMigrationFromPendingMigrations(
       workspaceId,
     );
@@ -377,11 +336,6 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
     input: DeleteOneObjectInput,
     workspaceId: string,
   ): Promise<ObjectMetadataEntity> {
-    const isNewRelationEnabled = await this.featureFlagService.isFeatureEnabled(
-      FeatureFlagKey.IsNewRelationEnabled,
-      workspaceId,
-    );
-
     const objectMetadata = await this.objectMetadataRepository.findOne({
       relations: [
         'fields',
@@ -419,7 +373,6 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
       await this.objectMetadataMigrationService.deleteAllRelationsAndDropTable(
         objectMetadata,
         workspaceId,
-        isNewRelationEnabled,
       );
     }
 
@@ -536,11 +489,6 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
     objectMetadataForUpdate: ObjectMetadataEntity,
     inputPayload: UpdateObjectPayload,
   ) {
-    const isNewRelationEnabled = await this.featureFlagService.isFeatureEnabled(
-      FeatureFlagKey.IsNewRelationEnabled,
-      objectMetadataForUpdate.workspaceId,
-    );
-
     const newTargetTableName = computeObjectTargetTable(
       objectMetadataForUpdate,
     );
@@ -555,33 +503,18 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
         objectMetadataForUpdate.workspaceId,
       );
 
-      if (isNewRelationEnabled) {
-        const relationMetadataCollection =
-          await this.objectMetadataFieldRelationService.updateRelationsAndForeignKeysMetadata(
-            objectMetadataForUpdate.workspaceId,
-            objectMetadataForUpdate,
-          );
-
-        await this.objectMetadataMigrationService.updateRelationMigrations(
-          existingObjectMetadata,
-          objectMetadataForUpdate,
-          relationMetadataCollection,
+      const relationMetadataCollection =
+        await this.objectMetadataFieldRelationService.updateRelationsAndForeignKeysMetadata(
           objectMetadataForUpdate.workspaceId,
-        );
-      } else {
-        const relationsAndForeignKeysMetadata =
-          await this.objectMetadataRelationService.updateRelationsAndForeignKeysMetadata(
-            objectMetadataForUpdate.workspaceId,
-            objectMetadataForUpdate,
-          );
-
-        await this.objectMetadataMigrationService.createUpdateForeignKeysMigrations(
-          existingObjectMetadata,
           objectMetadataForUpdate,
-          relationsAndForeignKeysMetadata,
-          objectMetadataForUpdate.workspaceId,
         );
-      }
+
+      await this.objectMetadataMigrationService.updateRelationMigrations(
+        existingObjectMetadata,
+        objectMetadataForUpdate,
+        relationMetadataCollection,
+        objectMetadataForUpdate.workspaceId,
+      );
 
       await this.objectMetadataMigrationService.recomputeEnumNames(
         objectMetadataForUpdate,