From 48c9ea855abefb5ae2fff4bb9833706b65aa7ec2 Mon Sep 17 00:00:00 2001
From: Charles Bochet <charles@twenty.com>
Date: Tue, 24 Oct 2023 17:13:50 +0200
Subject: [PATCH] Improve tests

---
 front/src/modules/favorites/components/Favorites.tsx       | 3 +--
 .../src/modules/ui/layout/dropdown/components/Dropdown.tsx | 3 +--
 .../data-model/__stories__/SettingsNewObject.stories.tsx   | 7 ++++++-
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/front/src/modules/favorites/components/Favorites.tsx b/front/src/modules/favorites/components/Favorites.tsx
index 971c43750..91f3ed254 100644
--- a/front/src/modules/favorites/components/Favorites.tsx
+++ b/front/src/modules/favorites/components/Favorites.tsx
@@ -60,7 +60,7 @@ export const Favorites = () => {
         draggableItems={
           <>
             {favorites.map((favorite, index) => {
-              const { id, person, company, position } = favorite;
+              const { id, person, company } = favorite;
               return (
                 <DraggableItem
                   key={id}
@@ -68,7 +68,6 @@ export const Favorites = () => {
                   index={index}
                   itemComponent={
                     <>
-                      {position}
                       {person && (
                         <NavItem
                           key={id}
diff --git a/front/src/modules/ui/layout/dropdown/components/Dropdown.tsx b/front/src/modules/ui/layout/dropdown/components/Dropdown.tsx
index 9bd883498..17f701a28 100644
--- a/front/src/modules/ui/layout/dropdown/components/Dropdown.tsx
+++ b/front/src/modules/ui/layout/dropdown/components/Dropdown.tsx
@@ -53,7 +53,6 @@ export const Dropdown = ({
   const { isDropdownOpen, toggleDropdown, closeDropdown, dropdownWidth } =
     useDropdown();
 
-  const dropdownWidthState = dropdownMenuWidth ?? dropdownWidth;
   const offsetMiddlewares = [];
   if (dropdownOffset.x) {
     offsetMiddlewares.push(offset({ crossAxis: dropdownOffset.x }));
@@ -112,7 +111,7 @@ export const Dropdown = ({
       )}
       {isDropdownOpen && (
         <DropdownMenu
-          width={dropdownWidthState}
+          width={dropdownMenuWidth ?? dropdownWidth}
           data-select-disable
           ref={refs.setFloating}
           style={floatingStyles}
diff --git a/front/src/pages/settings/data-model/__stories__/SettingsNewObject.stories.tsx b/front/src/pages/settings/data-model/__stories__/SettingsNewObject.stories.tsx
index 78f0e5092..dbe54c960 100644
--- a/front/src/pages/settings/data-model/__stories__/SettingsNewObject.stories.tsx
+++ b/front/src/pages/settings/data-model/__stories__/SettingsNewObject.stories.tsx
@@ -5,6 +5,7 @@ import {
   PageDecoratorArgs,
 } from '~/testing/decorators/PageDecorator';
 import { graphqlMocks } from '~/testing/graphqlMocks';
+import { sleep } from '~/testing/sleep';
 
 import { SettingsNewObject } from '../SettingsNewObject';
 
@@ -24,4 +25,8 @@ export default meta;
 
 export type Story = StoryObj<typeof SettingsNewObject>;
 
-export const Default: Story = {};
+export const Default: Story = {
+  play: async ({}) => {
+    await sleep(100);
+  },
+};