mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: improve SingleEntitySelect empty option (#1543)

Browse Source 
Closes #1331

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Thaïs
2023-09-12 02:27:17 +02:00
committed by GitHub
parent a766c60aa5
commit 564a7c97b1
17 changed files with 297 additions and 444 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
front/src/modules/ui/table/editable-cell/type/components/GenericEditableRelationCellEditMode.tsx
View File

@ -35,9 +35,6 @@ export function GenericEditableRelationCellEditMode({
const updateEntityField = useUpdateEntityField();
function updateCachedPersonField(newFieldEntity: EntityForSelect | null) {
if (newFieldEntity === null) {
return;
}
setFieldValueEntity({
avatarUrl: newFieldEntity?.avatarUrl ?? '',
entityType: Entity.Company,
@ -49,10 +46,6 @@ export function GenericEditableRelationCellEditMode({
function updateCachedCompanyField(
newFieldEntity: CompanyPickerSelectedCompany | null,
) {
if (newFieldEntity === null) {
return;
}
setFieldValueEntity({
id: newFieldEntity?.id ?? '',
name: newFieldEntity?.name ?? '',
@ -64,7 +57,6 @@ export function GenericEditableRelationCellEditMode({
newFieldEntity: CompanyPickerSelectedCompany | null,
) {
if (
newFieldEntity &&
newFieldEntity?.id !== fieldValueEntity?.id &&
currentRowEntityId &&
updateEntityField