Fix optimistic rendering issues on board and table (#2846)

* Fix optimistic rendering issues on board and table

* Remove dead code

* Improve re-renders of Table

* Remove re-renders on board

front/src/modules/apollo/optimistic-effect/hooks/useOptimisticEffect.ts

@@ -49,12 +49,14 @@ export const useOptimisticEffect = ({
         const optimisticEffectWriter = ({
           cache,
           newData,
+          deletedRecordIds,
           query,
           variables,
           objectMetadataItem,
         }: {
           cache: ApolloCache<unknown>;
           newData: unknown;
+          deletedRecordIds?: string[];
           variables: OperationVariables;
           query: DocumentNode;
           isUsingFlexibleBackend?: boolean;
@@ -79,6 +81,7 @@ export const useOptimisticEffect = ({
                     objectMetadataItem.namePlural
                   ],
                   newData,
+                  deletedRecordIds,
                   variables,
                 }),
               },
@@ -116,7 +119,7 @@ export const useOptimisticEffect = ({
 
   const triggerOptimisticEffects = useRecoilCallback(
     ({ snapshot }) =>
-      (typename: string, newData: unknown) => {
+      (typename: string, newData: unknown, deletedRecordIds?: string[]) => {
         const optimisticEffects = snapshot
           .getLoadable(optimisticEffectState)
           .getValue();
@@ -135,6 +138,7 @@ export const useOptimisticEffect = ({
               cache: apolloClient.cache,
               query: optimisticEffect.query ?? ({} as DocumentNode),
               newData: formattedNewData,
+              deletedRecordIds,
               variables: optimisticEffect.variables,
               isUsingFlexibleBackend: optimisticEffect.isUsingFlexibleBackend,
               objectMetadataItem: optimisticEffect.objectMetadataItem,

front/src/modules/apollo/optimistic-effect/types/OptimisticEffectResolver.ts

@@ -3,9 +3,11 @@ import { OperationVariables } from '@apollo/client';
 export type OptimisticEffectResolver = ({
   currentData,
   newData,
+  deletedRecordIds,
   variables,
 }: {
   currentData: any; //TODO: Change when decommissioning v1
   newData: any; //TODO:   Change when decommissioning v1
+  deletedRecordIds?: string[];
   variables: OperationVariables;
 }) => void;

front/src/modules/apollo/optimistic-effect/types/internal/OptimisticEffect.ts

@@ -11,6 +11,7 @@ type OptimisticEffectWriter<T> = ({
   cache: ApolloCache<T>;
   query: DocumentNode;
   newData: T;
+  deletedRecordIds?: string[];
   variables: OperationVariables;
   objectMetadataItem?: ObjectMetadataItem;
   isUsingFlexibleBackend?: boolean;