Frontend tests improvements (#13115)

Fix warnings and lower coverage by 0.1%
2025-07-09 09:23:26 +02:00
parent 6057bdd389
commit 6ba6860e1c
29 changed files with 435 additions and 237 deletions
--- a/packages/twenty-front/src/modules/object-record/graphql/utils/tests/computeDepthOneRecordGqlFieldsFromRecord.test.ts
+++ b/packages/twenty-front/src/modules/object-record/graphql/utils/tests/computeDepthOneRecordGqlFieldsFromRecord.test.ts
@ -15,7 +15,7 @@ describe('computeDepthOneRecordGqlFieldsFromRecord', () => {
    expect(result).toMatchInlineSnapshot(`
 {
  "attachments": false,
-  "avatarUrl": false,
+  "avatarUrl": true,
  "calendarEventParticipants": false,
  "city": true,
  "company": true,
@ -23,25 +23,25 @@ describe('computeDepthOneRecordGqlFieldsFromRecord', () => {
  "createdAt": true,
  "createdBy": true,
  "deletedAt": true,
-  "emails": false,
+  "emails": true,
  "favorites": false,
  "id": true,
-  "intro": false,
+  "intro": true,
  "jobTitle": true,
  "linkedinLink": true,
  "messageParticipants": false,
  "name": true,
  "noteTargets": true,
-  "performanceRating": false,
+  "performanceRating": true,
  "phones": true,
  "pointOfContactForOpportunities": false,
  "position": true,
  "searchVector": false,
  "taskTargets": true,
  "timelineActivities": false,
-  "updatedAt": false,
-  "whatsapp": false,
-  "workPreference": false,
+  "updatedAt": true,
+  "whatsapp": true,
+  "workPreference": true,
  "xLink": true,
 }
 `);
--- a/packages/twenty-front/src/modules/object-record/hooks/tests/snapshots/useDeleteOneRecord.test.tsx.snap
+++ b/packages/twenty-front/src/modules/object-record/hooks/tests/snapshots/useDeleteOneRecord.test.tsx.snap
@ -11,6 +11,7 @@ exports[`useDeleteOneRecord A. Starting from empty cache 1. Should successfully
 exports[`useDeleteOneRecord B. Starting from filled cache 1. Should handle successfull record deletion 1`] = `
 {
  "__typename": "Person",
+  "avatarUrl": null,
  "city": "ASd",
  "company": {
    "__typename": "Company",
@ -54,12 +55,18 @@ exports[`useDeleteOneRecord B. Starting from filled cache 1. Should handle succe
  "createdAt": "2025-01-02T09:52:46.814Z",
  "createdBy": {
    "__typename": "Actor",
+    "context": null,
    "name": "Tim Apple",
    "source": "MANUAL",
    "workspaceMemberId": "20202020-0687-4c41-b707-ed1bfca972a7",
  },
  "deletedAt": "2024-02-14T09:45:00Z",
+  "emails": {
+    "additionalEmails": [],
+    "primaryEmail": "asd.com",
+  },
  "id": "da3c2c4b-da01-4b81-9734-226069eb4cd0",
+  "intro": "",
  "jobTitle": "",
  "linkedinLink": {
    "__typename": "Links",
@ -73,13 +80,23 @@ exports[`useDeleteOneRecord B. Starting from filled cache 1. Should handle succe
    "lastName": "Test",
  },
  "noteTargets": [],
+  "performanceRating": null,
  "phones": {
+    "additionalPhones": [],
    "primaryPhoneCallingCode": "+33",
    "primaryPhoneCountryCode": "FR",
    "primaryPhoneNumber": "781234562",
  },
  "position": 0,
  "taskTargets": [],
+  "updatedAt": "2025-01-02T09:52:46.814Z",
+  "whatsapp": {
+    "additionalPhones": [],
+    "primaryPhoneCallingCode": "",
+    "primaryPhoneCountryCode": "",
+    "primaryPhoneNumber": "",
+  },
+  "workPreference": null,
  "xLink": {
    "__typename": "Links",
    "primaryLinkLabel": "",
@ -135,16 +152,23 @@ exports[`useDeleteOneRecord B. Starting from filled cache 1. Should handle succe
  "people": [
    {
      "__typename": "Person",
+      "avatarUrl": null,
      "city": "Seattle",
      "createdAt": "2025-01-01T09:50:00.000Z",
      "createdBy": {
        "__typename": "Actor",
+        "context": null,
        "name": "Tim Apple",
        "source": "MANUAL",
        "workspaceMemberId": "20202020-0687-4c41-b707-ed1bfca972a7",
      },
      "deletedAt": null,
+      "emails": {
+        "additionalEmails": [],
+        "primaryEmail": "christoph.calisto@linkedin.com",
+      },
      "id": "20202020-1c0e-494c-a1b6-85b1c6fefaa5",
+      "intro": "",
      "jobTitle": "",
      "linkedinLink": {
        "__typename": "Links",
@ -157,12 +181,22 @@ exports[`useDeleteOneRecord B. Starting from filled cache 1. Should handle succe
        "firstName": "Christoph",
        "lastName": "Callisto",
      },
+      "performanceRating": null,
      "phones": {
+        "additionalPhones": [],
        "primaryPhoneCallingCode": "+33",
        "primaryPhoneCountryCode": "FR",
        "primaryPhoneNumber": "781234562",
      },
      "position": 1,
+      "updatedAt": "2025-01-01T09:50:00.000Z",
+      "whatsapp": {
+        "additionalPhones": [],
+        "primaryPhoneCallingCode": "",
+        "primaryPhoneCountryCode": "",
+        "primaryPhoneNumber": "",
+      },
+      "workPreference": null,
      "xLink": {
        "__typename": "Links",
        "primaryLinkLabel": "",
@ -195,6 +229,7 @@ exports[`useDeleteOneRecord B. Starting from filled cache 1. Should handle succe
        "lastName": "Palmer",
      },
      "phones": {
+        "additionalPhones": [],
        "primaryPhoneCallingCode": "+33",
        "primaryPhoneCountryCode": "FR",
        "primaryPhoneNumber": "781234576",
@ -216,6 +251,7 @@ exports[`useDeleteOneRecord B. Starting from filled cache 1. Should handle succe
 exports[`useDeleteOneRecord B. Starting from filled cache 2. Should handle optimistic cache on record deletion 1`] = `
 {
  "__typename": "Person",
+  "avatarUrl": null,
  "city": "ASd",
  "company": {
    "__typename": "Company",
@ -259,12 +295,18 @@ exports[`useDeleteOneRecord B. Starting from filled cache 2. Should handle optim
  "createdAt": "2025-01-02T09:52:46.814Z",
  "createdBy": {
    "__typename": "Actor",
+    "context": null,
    "name": "Tim Apple",
    "source": "MANUAL",
    "workspaceMemberId": "20202020-0687-4c41-b707-ed1bfca972a7",
  },
  "deletedAt": Any<String>,
+  "emails": {
+    "additionalEmails": [],
+    "primaryEmail": "asd.com",
+  },
  "id": "da3c2c4b-da01-4b81-9734-226069eb4cd0",
+  "intro": "",
  "jobTitle": "",
  "linkedinLink": {
    "__typename": "Links",
@ -278,13 +320,23 @@ exports[`useDeleteOneRecord B. Starting from filled cache 2. Should handle optim
    "lastName": "Test",
  },
  "noteTargets": [],
+  "performanceRating": null,
  "phones": {
+    "additionalPhones": [],
    "primaryPhoneCallingCode": "+33",
    "primaryPhoneCountryCode": "FR",
    "primaryPhoneNumber": "781234562",
  },
  "position": 0,
  "taskTargets": [],
+  "updatedAt": "2025-01-02T09:52:46.814Z",
+  "whatsapp": {
+    "additionalPhones": [],
+    "primaryPhoneCallingCode": "",
+    "primaryPhoneCountryCode": "",
+    "primaryPhoneNumber": "",
+  },
+  "workPreference": null,
  "xLink": {
    "__typename": "Links",
    "primaryLinkLabel": "",
@ -340,16 +392,23 @@ exports[`useDeleteOneRecord B. Starting from filled cache 2. Should handle optim
  "people": [
    {
      "__typename": "Person",
+      "avatarUrl": null,
      "city": "Seattle",
      "createdAt": "2025-01-01T09:50:00.000Z",
      "createdBy": {
        "__typename": "Actor",
+        "context": null,
        "name": "Tim Apple",
        "source": "MANUAL",
        "workspaceMemberId": "20202020-0687-4c41-b707-ed1bfca972a7",
      },
      "deletedAt": null,
+      "emails": {
+        "additionalEmails": [],
+        "primaryEmail": "christoph.calisto@linkedin.com",
+      },
      "id": "20202020-1c0e-494c-a1b6-85b1c6fefaa5",
+      "intro": "",
      "jobTitle": "",
      "linkedinLink": {
        "__typename": "Links",
@ -362,12 +421,22 @@ exports[`useDeleteOneRecord B. Starting from filled cache 2. Should handle optim
        "firstName": "Christoph",
        "lastName": "Callisto",
      },
+      "performanceRating": null,
      "phones": {
+        "additionalPhones": [],
        "primaryPhoneCallingCode": "+33",
        "primaryPhoneCountryCode": "FR",
        "primaryPhoneNumber": "781234562",
      },
      "position": 1,
+      "updatedAt": "2025-01-01T09:50:00.000Z",
+      "whatsapp": {
+        "additionalPhones": [],
+        "primaryPhoneCallingCode": "",
+        "primaryPhoneCountryCode": "",
+        "primaryPhoneNumber": "",
+      },
+      "workPreference": null,
      "xLink": {
        "__typename": "Links",
        "primaryLinkLabel": "",
@ -400,6 +469,7 @@ exports[`useDeleteOneRecord B. Starting from filled cache 2. Should handle optim
        "lastName": "Palmer",
      },
      "phones": {
+        "additionalPhones": [],
        "primaryPhoneCallingCode": "+33",
        "primaryPhoneCountryCode": "FR",
        "primaryPhoneNumber": "781234576",
@ -421,6 +491,7 @@ exports[`useDeleteOneRecord B. Starting from filled cache 2. Should handle optim
 exports[`useDeleteOneRecord B. Starting from filled cache 3. Should handle optimistic cache rollback on record deletion failure 1`] = `
 {
  "__typename": "Person",
+  "avatarUrl": null,
  "city": "ASd",
  "company": {
    "__typename": "Company",
@ -464,12 +535,18 @@ exports[`useDeleteOneRecord B. Starting from filled cache 3. Should handle optim
  "createdAt": "2025-01-02T09:52:46.814Z",
  "createdBy": {
    "__typename": "Actor",
+    "context": null,
    "name": "Tim Apple",
    "source": "MANUAL",
    "workspaceMemberId": "20202020-0687-4c41-b707-ed1bfca972a7",
  },
  "deletedAt": null,
+  "emails": {
+    "additionalEmails": [],
+    "primaryEmail": "asd.com",
+  },
  "id": "da3c2c4b-da01-4b81-9734-226069eb4cd0",
+  "intro": "",
  "jobTitle": "",
  "linkedinLink": {
    "__typename": "Links",
@ -483,13 +560,23 @@ exports[`useDeleteOneRecord B. Starting from filled cache 3. Should handle optim
    "lastName": "Test",
  },
  "noteTargets": [],
+  "performanceRating": null,
  "phones": {
+    "additionalPhones": [],
    "primaryPhoneCallingCode": "+33",
    "primaryPhoneCountryCode": "FR",
    "primaryPhoneNumber": "781234562",
  },
  "position": 0,
  "taskTargets": [],
+  "updatedAt": "2025-01-02T09:52:46.814Z",
+  "whatsapp": {
+    "additionalPhones": [],
+    "primaryPhoneCallingCode": "",
+    "primaryPhoneCountryCode": "",
+    "primaryPhoneNumber": "",
+  },
+  "workPreference": null,
  "xLink": {
    "__typename": "Links",
    "primaryLinkLabel": "",
@ -545,16 +632,23 @@ exports[`useDeleteOneRecord B. Starting from filled cache 3. Should handle optim
  "people": [
    {
      "__typename": "Person",
+      "avatarUrl": null,
      "city": "Seattle",
      "createdAt": "2025-01-01T09:50:00.000Z",
      "createdBy": {
        "__typename": "Actor",
+        "context": null,
        "name": "Tim Apple",
        "source": "MANUAL",
        "workspaceMemberId": "20202020-0687-4c41-b707-ed1bfca972a7",
      },
      "deletedAt": null,
+      "emails": {
+        "additionalEmails": [],
+        "primaryEmail": "christoph.calisto@linkedin.com",
+      },
      "id": "20202020-1c0e-494c-a1b6-85b1c6fefaa5",
+      "intro": "",
      "jobTitle": "",
      "linkedinLink": {
        "__typename": "Links",
@ -567,12 +661,22 @@ exports[`useDeleteOneRecord B. Starting from filled cache 3. Should handle optim
        "firstName": "Christoph",
        "lastName": "Callisto",
      },
+      "performanceRating": null,
      "phones": {
+        "additionalPhones": [],
        "primaryPhoneCallingCode": "+33",
        "primaryPhoneCountryCode": "FR",
        "primaryPhoneNumber": "781234562",
      },
      "position": 1,
+      "updatedAt": "2025-01-01T09:50:00.000Z",
+      "whatsapp": {
+        "additionalPhones": [],
+        "primaryPhoneCallingCode": "",
+        "primaryPhoneCountryCode": "",
+        "primaryPhoneNumber": "",
+      },
+      "workPreference": null,
      "xLink": {
        "__typename": "Links",
        "primaryLinkLabel": "",
@ -605,6 +709,7 @@ exports[`useDeleteOneRecord B. Starting from filled cache 3. Should handle optim
        "lastName": "Palmer",
      },
      "phones": {
+        "additionalPhones": [],
        "primaryPhoneCallingCode": "+33",
        "primaryPhoneCountryCode": "FR",
        "primaryPhoneNumber": "781234576",
--- a/packages/twenty-front/src/modules/object-record/hooks/tests/useFindManyRecords.test.tsx
+++ b/packages/twenty-front/src/modules/object-record/hooks/tests/useFindManyRecords.test.tsx
@ -1,58 +1,35 @@
 import { renderHook } from '@testing-library/react';
-import { useSetRecoilState } from 'recoil';

 import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
 import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadataItemsState';
-import {
-  query,
-  responseData,
-  variables,
-} from '@/object-record/hooks/__mocks__/useFindManyRecords';
 import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
 import { getJestMetadataAndApolloMocksWrapper } from '~/testing/jest/getJestMetadataAndApolloMocksWrapper';
 import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems';

-const mocks = [
-  {
-    request: {
-      query,
-      variables,
-    },
-    result: jest.fn(() => ({
-      data: {
-        deletePeople: responseData,
-      },
-    })),
-  },
-];
-
 const Wrapper = getJestMetadataAndApolloMocksWrapper({
-  apolloMocks: mocks,
+  apolloMocks: [],
+  onInitializeRecoilSnapshot: (snapshot) => {
+    snapshot.set(currentWorkspaceMemberState, {
+      id: '32219445-f587-4c40-b2b1-6d3205ed96da',
+      name: { firstName: 'John', lastName: 'Connor' },
+      locale: 'en',
+      colorScheme: 'Light',
+      userEmail: 'userEmail',
+    });
+    snapshot.set(objectMetadataItemsState, generatedMockObjectMetadataItems);
+  },
 });
+
 describe('useFindManyRecords', () => {
  it('should work as expected', async () => {
    const onCompleted = jest.fn();

    const { result } = renderHook(
      () => {
-        const setCurrentWorkspaceMember = useSetRecoilState(
-          currentWorkspaceMemberState,
-        );
-        setCurrentWorkspaceMember({
-          id: '32219445-f587-4c40-b2b1-6d3205ed96da',
-          name: { firstName: 'John', lastName: 'Connor' },
-          locale: 'en',
-          colorScheme: 'Light',
-          userEmail: 'userEmail',
-        });
-
-        const setMetadataItems = useSetRecoilState(objectMetadataItemsState);
-
-        setMetadataItems(generatedMockObjectMetadataItems);
-
        return useFindManyRecords({
          objectNameSingular: 'person',
          onCompleted,
+          skip: true,
        });
      },
      {
@ -60,8 +37,9 @@ describe('useFindManyRecords', () => {
      },
    );

-    expect(result.current.loading).toBe(true);
+    expect(result.current.loading).toBe(false);
    expect(result.current.error).toBeUndefined();
    expect(result.current.records.length).toBe(0);
+    expect(result.current.objectMetadataItem).toBeDefined();
  });
 });
--- a/packages/twenty-front/src/modules/object-record/record-field/hooks/tests/usePersistField.test.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-field/hooks/tests/usePersistField.test.tsx
@ -1,5 +1,6 @@
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS } from '@/object-record/hooks/__mocks__/personFragments';
+import { responseData } from '@/object-record/hooks/__mocks__/useUpdateOneRecord';
 import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
 import {
  phonesFieldDefinition,
@ -36,6 +37,8 @@ const phoneMock = {
  additionalPhones: [],
 };

+const mockPersonResponse = { ...responseData, id: 'recordId' };
+
 const mocks: MockedResponse[] = [
  {
    request: {
@ -49,9 +52,7 @@ const mocks: MockedResponse[] = [
    },
    result: jest.fn(() => ({
      data: {
-        updatePerson: {
-          id: 'recordId',
-        },
+        updatePerson: mockPersonResponse,
      },
    })),
  },
@ -65,9 +66,7 @@ const mocks: MockedResponse[] = [
    },
    result: jest.fn(() => ({
      data: {
-        updatePerson: {
-          id: 'recordId',
-        },
+        updatePerson: mockPersonResponse,
      },
    })),
  },