mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Revert "Connect - Relation on FE Importer (#13213)" (#13313)

Browse Source 
This reverts commit cc71394863.

Regression introduced in https://github.com/twentyhq/twenty/pull/13213
The import/export use an upsert logic and when it goes through the
"update" path it fails due to the connect not being implemented yet
(should be in https://github.com/twentyhq/core-team-issues/issues/1230)

---------

Co-authored-by: prastoin <paul@twenty.com>
This commit is contained in:
Weiko
2025-07-21 17:03:42 +02:00
committed by GitHub
parent f6aa556a16
commit 79f3fbb016
90 changed files with 1159 additions and 1572 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/twenty-shared/src/utils/index.ts
View File

@ -15,7 +15,6 @@ export {
sanitizeURL,
getLogoUrlFromDomainName,
} from './image/getLogoUrlFromDomainName';
export { getUniqueConstraintsFields } from './indexMetadata/getUniqueConstraintsFields';
export { parseJson } from './parseJson';
export { removeUndefinedFields } from './removeUndefinedFields';
export { getGenericOperationName } from './sentry/getGenericOperationName';

139
packages/twenty-shared/src/utils/indexMetadata/__tests__/getUniqueConstraintsFields.test.ts
View File

@ -1,139 +0,0 @@
import { FieldMetadataType } from '@/types';
import { getUniqueConstraintsFields } from '../getUniqueConstraintsFields';
describe('getUniqueConstraintsFields', () => {
const mockIdField = {
id: 'field-id-1',
name: 'id',
label: 'ID',
type: FieldMetadataType.UUID,
objectMetadataId: 'object-id-1',
isNullable: false,
isUnique: false,
isCustom: false,
isSystem: true,
isActive: true,
isLabelSyncedWithName: false,
createdAt: new Date('2024-01-01'),
updatedAt: new Date('2024-01-01'),
};
const mockEmailField = {
id: 'field-id-2',
name: 'email',
label: 'Email',
type: FieldMetadataType.EMAILS,
objectMetadataId: 'object-id-1',
isNullable: true,
isUnique: true,
isCustom: false,
isSystem: false,
isActive: true,
isLabelSyncedWithName: false,
createdAt: new Date('2024-01-01'),
updatedAt: new Date('2024-01-01'),
};
const mockNameField = {
id: 'field-id-3',
name: 'name',
label: 'Name',
type: FieldMetadataType.TEXT,
objectMetadataId: 'object-id-1',
isNullable: true,
isUnique: false,
isCustom: false,
isSystem: false,
isActive: true,
isLabelSyncedWithName: false,
createdAt: new Date('2024-01-01'),
updatedAt: new Date('2024-01-01'),
};
const createMockIndexFieldMetadata = (
fieldMetadataId: string,
indexMetadataId: string,
order = 0,
) => ({
id: `index-field-${fieldMetadataId}-${indexMetadataId}`,
indexMetadataId,
fieldMetadataId,
order,
createdAt: new Date('2024-01-01'),
updatedAt: new Date('2024-01-01'),
});
const createMockIndexMetadata = (
id: string,
name: string,
isUnique: boolean,
indexFieldMetadatas: any,
) => ({
id,
name,
isUnique,
indexFieldMetadatas,
createdAt: new Date('2024-01-01'),
updatedAt: new Date('2024-01-01'),
indexWhereClause: null,
});
const createMockObjectMetadata = (fields: any, indexMetadatas: any) => ({
id: 'object-id-1',
workspaceId: 'workspace-id-1',
nameSingular: 'person',
namePlural: 'people',
labelSingular: 'Person',
labelPlural: 'People',
description: 'A person object',
icon: 'IconUser',
targetTableName: 'person',
fields,
indexMetadatas,
isSystem: false,
isCustom: false,
isActive: true,
isRemote: false,
isAuditLogged: true,
isSearchable: true,
});
it('should return the primary key constraint field if no unique indexes are present', () => {
const objectMetadata = createMockObjectMetadata(
[mockIdField, mockNameField],
[],
);
const result = getUniqueConstraintsFields(objectMetadata);
expect(result).toHaveLength(1);
expect(result[0]).toHaveLength(1);
expect(result[0][0]).toEqual(mockIdField);
});
it('should return the primary key constraint field and the unique indexes fields if unique indexes are present', () => {
const emailIndexFieldMetadata = createMockIndexFieldMetadata(
'field-id-2',
'index-id-1',
);
const emailIndex = createMockIndexMetadata(
'index-id-1',
'unique_email_index',
true,
[emailIndexFieldMetadata],
);
const objectMetadata = createMockObjectMetadata(
[mockIdField, mockEmailField, mockNameField],
[emailIndex],
);
const result = getUniqueConstraintsFields(objectMetadata);
expect(result).toHaveLength(2);
expect(result[0]).toHaveLength(1);
expect(result[0][0]).toEqual(mockIdField);
expect(result[1]).toHaveLength(1);
expect(result[1][0]).toEqual(mockEmailField);
});
});

53
packages/twenty-shared/src/utils/indexMetadata/getUniqueConstraintsFields.ts
View File

@ -1,53 +0,0 @@
import { isDefined } from '@/utils/validation/isDefined';
export const getUniqueConstraintsFields = <
K extends {
id: string;
name: string;
},
T extends {
id: string;
indexMetadatas: {
id: string;
isUnique: boolean;
indexFieldMetadatas: { fieldMetadataId: string }[];
}[];
fields: K[];
},
>(
objectMetadata: T,
): K[][] => {
const uniqueIndexes = objectMetadata.indexMetadatas.filter(
(index) => index.isUnique,
);
const fieldsMapById = new Map(
objectMetadata.fields.map((field) => [field.id, field]),
);
const primaryKeyConstraintField = objectMetadata.fields.find(
(field) => field.name === 'id',
);
if (!isDefined(primaryKeyConstraintField)) {
throw new Error(
`Primary key constraint field not found for object metadata ${objectMetadata.id}`,
);
}
const otherUniqueConstraintsFields = uniqueIndexes.map((index) =>
index.indexFieldMetadatas.map((field) => {
const indexField = fieldsMapById.get(field.fieldMetadataId);
if (!isDefined(indexField)) {
throw new Error(
`Index field not found for field id ${field.fieldMetadataId} in index metadata ${index.id}`,
);
}
return indexField;
}),
);
return [[primaryKeyConstraintField], ...otherUniqueConstraintsFields];
};

1
packages/twenty-shared/src/utils/indexMetadata/index.ts
View File

@ -1 +0,0 @@
export * from './getUniqueConstraintsFields';