mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: improve IconButtonGroup and FloatingIconButtonGroup (#1518)

Browse Source 
Closes #1411
This commit is contained in:
Thaïs
2023-09-08 17:16:27 +02:00
committed by GitHub
parent df17da80fc
commit 86ff522e74
6 changed files with 101 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
front/src/modules/ui/menu-item/components/MenuItem.tsx
View File

@ -1,7 +1,5 @@
import { MouseEvent } from 'react';
import { useTheme } from '@emotion/react';
import type { MouseEvent } from 'react';
import { FloatingIconButton } from '@/ui/button/components/FloatingIconButton';
import { FloatingIconButtonGroup } from '@/ui/button/components/FloatingIconButtonGroup';
import { IconComponent } from '@/ui/icon/types/IconComponent';
@ -33,8 +31,6 @@ export function MenuItem({
testId,
onClick,
}: MenuItemProps) {
const theme = useTheme();
const showIconButtons = Array.isArray(iconButtons) && iconButtons.length > 0;
return (
@ -45,17 +41,7 @@ export function MenuItem({
accent={accent}
>
<MenuItemLeftContent LeftIcon={LeftIcon ?? undefined} text={text} />
{showIconButtons && (
<FloatingIconButtonGroup>
{iconButtons?.map(({ Icon, onClick }, index) => (
<FloatingIconButton
icon={<Icon size={theme.icon.size.sm} />}
key={index}
onClick={onClick}
/>
))}
</FloatingIconButtonGroup>
)}
{showIconButtons && <FloatingIconButtonGroup iconButtons={iconButtons} />}
</StyledMenuItemBase>
);
}