mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

1880 Refactored Dropdown components (#1884)

Browse Source 
* updated DropdownButton props

* refactoring in progress

* working but layout is wrong

* fixed bug

* wip on ColumnHeadWithDropdown

* fix bug

* fix bug

* remove unused styled component

* fix z-index bug

* add an optional argument to DropdownMenu to control the offset of the menu

* add an optional argument to DropdownMenu to control the offset of the menu

* modify files after PR comments

* clean the way the offset is handled

* fix lint
This commit is contained in:
bosiraphael
2023-10-05 18:11:54 +02:00
committed by GitHub
parent b8282e6789
commit 922f8eca0e
23 changed files with 213 additions and 182 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
front/src/modules/ui/data-table/options/components/TableOptionsDropdownContent.tsx
View File

@ -9,7 +9,7 @@ import { DropdownMenuInputContainer } from '@/ui/dropdown/components/DropdownMen
import { StyledDropdownMenu } from '@/ui/dropdown/components/StyledDropdownMenu';
import { StyledDropdownMenuItemsContainer } from '@/ui/dropdown/components/StyledDropdownMenuItemsContainer';
import { StyledDropdownMenuSeparator } from '@/ui/dropdown/components/StyledDropdownMenuSeparator';
import { useDropdownButton } from '@/ui/dropdown/hooks/useDropdownButton';
import { useDropdown } from '@/ui/dropdown/hooks/useDropdown';
import { IconChevronLeft, IconFileImport, IconTag } from '@/ui/icon';
import { MenuItem } from '@/ui/menu-item/components/MenuItem';
import { useScopedHotkeys } from '@/ui/utilities/hotkey/hooks/useScopedHotkeys';
@ -37,7 +37,7 @@ export const TableOptionsDropdownContent = () => {
const scopeId = useRecoilScopeId(TableRecoilScopeContext);
const { onImport } = useContext(ViewBarContext);
const { closeDropdownButton } = useDropdownButton({
const { closeDropdown } = useDropdown({
dropdownId: TableOptionsDropdownId,
});
@ -114,7 +114,7 @@ export const TableOptionsDropdownContent = () => {
Key.Escape,
() => {
resetViewEditMode();
closeDropdownButton();
closeDropdown();
},
TableOptionsHotkeyScope.Dropdown,
);
@ -125,7 +125,7 @@ export const TableOptionsDropdownContent = () => {
handleViewNameSubmit();
resetMenu();
resetViewEditMode();
closeDropdownButton();
closeDropdown();
},
TableOptionsHotkeyScope.Dropdown,
);