feat: manually implement joinColumn (#6022)

This PR introduce a new decorator named `@WorkspaceJoinColumn`, the goal
of this one is to manually declare the join columns inside the workspace
entities, so we don't have to rely on `ObjectRecord` type.

This decorator can be used that way:

```typescript
  @WorkspaceRelation({
    standardId: ACTIVITY_TARGET_STANDARD_FIELD_IDS.company,
    type: RelationMetadataType.MANY_TO_ONE,
    label: 'Company',
    description: 'ActivityTarget company',
    icon: 'IconBuildingSkyscraper',
    inverseSideTarget: () => CompanyWorkspaceEntity,
    inverseSideFieldKey: 'activityTargets',
  })
  @WorkspaceIsNullable()
  company: Relation<CompanyWorkspaceEntity> | null;

  // The argument is the name of the relation above
  @WorkspaceJoinColumn('company')
  companyId: string | null;
```

packages/twenty-server/src/modules/messaging/common/services/messaging-error-handling.service.ts

@@ -3,7 +3,6 @@ import { Injectable } from '@nestjs/common';
 import snakeCase from 'lodash.snakecase';
 
 import { InjectObjectMetadataRepository } from 'src/engine/object-metadata-repository/object-metadata-repository.decorator';
-import { ObjectRecord } from 'src/engine/workspace-manager/workspace-sync-metadata/types/object-record';
 import { ConnectedAccountRepository } from 'src/modules/connected-account/repositories/connected-account.repository';
 import { ConnectedAccountWorkspaceEntity } from 'src/modules/connected-account/standard-objects/connected-account.workspace-entity';
 import { MessagingTelemetryService } from 'src/modules/messaging/common/services/messaging-telemetry.service';
@@ -36,7 +35,7 @@ export class MessagingErrorHandlingService {
   public async handleGmailError(
     error: GmailError,
     syncStep: SyncStep,
-    messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
+    messageChannel: MessageChannelWorkspaceEntity,
     workspaceId: string,
   ): Promise<void> {
     const { code, reason } = error;
@@ -156,7 +155,7 @@ export class MessagingErrorHandlingService {
   private async handleRateLimitExceeded(
     error: GmailError,
     syncStep: SyncStep,
-    messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
+    messageChannel: MessageChannelWorkspaceEntity,
     workspaceId: string,
   ): Promise<void> {
     await this.messagingTelemetryService.track({
@@ -190,7 +189,7 @@ export class MessagingErrorHandlingService {
   private async handleInsufficientPermissions(
     error: GmailError,
     syncStep: SyncStep,
-    messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
+    messageChannel: MessageChannelWorkspaceEntity,
     workspaceId: string,
   ): Promise<void> {
     await this.messagingTelemetryService.track({
@@ -221,7 +220,7 @@ export class MessagingErrorHandlingService {
   private async handleNotFound(
     error: GmailError,
     syncStep: SyncStep,
-    messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
+    messageChannel: MessageChannelWorkspaceEntity,
     workspaceId: string,
   ): Promise<void> {
     if (syncStep === 'messages-import') {
@@ -288,7 +287,7 @@ export class MessagingErrorHandlingService {
   }
 
   private async throttle(
-    messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
+    messageChannel: MessageChannelWorkspaceEntity,
     workspaceId: string,
   ): Promise<void> {
     await this.messageChannelRepository.incrementThrottleFailureCount(

packages/twenty-server/src/modules/messaging/common/services/messaging-message-participant.service.ts

@@ -9,7 +9,6 @@ import { PersonWorkspaceEntity } from 'src/modules/person/standard-objects/perso
 import { WorkspaceDataSourceService } from 'src/engine/workspace-datasource/workspace-datasource.service';
 import { getFlattenedValuesAndValuesStringForBatchRawQuery } from 'src/modules/calendar/utils/get-flattened-values-and-values-string-for-batch-raw-query.util';
 import { AddPersonIdAndWorkspaceMemberIdService } from 'src/modules/calendar-messaging-participant/services/add-person-id-and-workspace-member-id/add-person-id-and-workspace-member-id.service';
-import { ObjectRecord } from 'src/engine/workspace-manager/workspace-sync-metadata/types/object-record';
 import { MessageParticipantRepository } from 'src/modules/messaging/common/repositories/message-participant.repository';
 import { MessageParticipantWorkspaceEntity } from 'src/modules/messaging/common/standard-objects/message-participant.workspace-entity';
 import { ParticipantWithMessageId } from 'src/modules/messaging/message-import-manager/drivers/gmail/types/gmail-message';
@@ -29,10 +28,10 @@ export class MessagingMessageParticipantService {
   ) {}
 
   public async updateMessageParticipantsAfterPeopleCreation(
-    createdPeople: ObjectRecord<PersonWorkspaceEntity>[],
+    createdPeople: PersonWorkspaceEntity[],
     workspaceId: string,
     transactionManager?: EntityManager,
-  ): Promise<ObjectRecord<MessageParticipantWorkspaceEntity>[]> {
+  ): Promise<MessageParticipantWorkspaceEntity[]> {
     const participants = await this.messageParticipantRepository.getByHandles(
       createdPeople.map((person) => person.email),
       workspaceId,
@@ -87,7 +86,7 @@ export class MessagingMessageParticipantService {
     participants: ParticipantWithMessageId[],
     workspaceId: string,
     transactionManager?: EntityManager,
-  ): Promise<ObjectRecord<MessageParticipantWorkspaceEntity>[]> {
+  ): Promise<MessageParticipantWorkspaceEntity[]> {
     if (!participants) return [];
 
     const dataSourceSchema =

packages/twenty-server/src/modules/messaging/common/services/messaging-message.service.ts

@@ -4,7 +4,6 @@ import { DataSource, EntityManager } from 'typeorm';
 import { v4 } from 'uuid';
 
 import { WorkspaceDataSourceService } from 'src/engine/workspace-datasource/workspace-datasource.service';
-import { ObjectRecord } from 'src/engine/workspace-manager/workspace-sync-metadata/types/object-record';
 import { InjectObjectMetadataRepository } from 'src/engine/object-metadata-repository/object-metadata-repository.decorator';
 import { ConnectedAccountWorkspaceEntity } from 'src/modules/connected-account/standard-objects/connected-account.workspace-entity';
 import { MessageChannelMessageAssociationRepository } from 'src/modules/messaging/common/repositories/message-channel-message-association.repository';
@@ -39,7 +38,7 @@ export class MessagingMessageService {
 
   public async saveMessagesWithinTransaction(
     messages: GmailMessage[],
-    connectedAccount: ObjectRecord<ConnectedAccountWorkspaceEntity>,
+    connectedAccount: ConnectedAccountWorkspaceEntity,
     gmailMessageChannelId: string,
     workspaceId: string,
     transactionManager: EntityManager,
@@ -68,6 +67,12 @@ export class MessagingMessageService {
           transactionManager,
         );
 
+      if (!savedOrExistingMessageThreadId) {
+        throw new Error(
+          `No message thread found for message ${message.headerMessageId} in workspace ${workspaceId} in saveMessages`,
+        );
+      }
+
       const savedOrExistingMessageId =
         await this.saveMessageOrReturnExistingMessage(
           message,
@@ -99,7 +104,7 @@ export class MessagingMessageService {
   public async saveMessages(
     messages: GmailMessage[],
     workspaceDataSource: DataSource,
-    connectedAccount: ObjectRecord<ConnectedAccountWorkspaceEntity>,
+    connectedAccount: ConnectedAccountWorkspaceEntity,
     gmailMessageChannelId: string,
     workspaceId: string,
   ): Promise<Map<string, string>> {
@@ -153,6 +158,12 @@ export class MessagingMessageService {
                 manager,
               );
 
+            if (!savedOrExistingMessageThreadId) {
+              throw new Error(
+                `No message thread found for message ${message.headerMessageId} in workspace ${workspaceId} in saveMessages`,
+              );
+            }
+
             const savedOrExistingMessageId =
               await this.saveMessageOrReturnExistingMessage(
                 message,
@@ -191,7 +202,7 @@ export class MessagingMessageService {
   private async saveMessageOrReturnExistingMessage(
     message: GmailMessage,
     messageThreadId: string,
-    connectedAccount: ObjectRecord<ConnectedAccountWorkspaceEntity>,
+    connectedAccount: ConnectedAccountWorkspaceEntity,
     workspaceId: string,
     manager: EntityManager,
   ): Promise<string> {

packages/twenty-server/src/modules/messaging/common/services/messaging-save-messages-and-enqueue-contact-creation.service.ts

@@ -7,7 +7,6 @@ import { EntityManager, Repository } from 'typeorm';
 import { MessageQueue } from 'src/engine/integrations/message-queue/message-queue.constants';
 import { MessageQueueService } from 'src/engine/integrations/message-queue/services/message-queue.service';
 import { WorkspaceDataSourceService } from 'src/engine/workspace-datasource/workspace-datasource.service';
-import { ObjectRecord } from 'src/engine/workspace-manager/workspace-sync-metadata/types/object-record';
 import { ConnectedAccountWorkspaceEntity } from 'src/modules/connected-account/standard-objects/connected-account.workspace-entity';
 import {
   CreateCompanyAndContactJobData,
@@ -43,8 +42,8 @@ export class MessagingSaveMessagesAndEnqueueContactCreationService {
 
   async saveMessagesAndEnqueueContactCreationJob(
     messagesToSave: GmailMessage[],
-    messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
-    connectedAccount: ObjectRecord<ConnectedAccountWorkspaceEntity>,
+    messageChannel: MessageChannelWorkspaceEntity,
+    connectedAccount: ConnectedAccountWorkspaceEntity,
     workspaceId: string,
   ) {
     const workspaceDataSource =
@@ -62,8 +61,7 @@ export class MessagingSaveMessagesAndEnqueueContactCreationService {
     const isContactCreationForSentAndReceivedEmailsEnabled =
       isContactCreationForSentAndReceivedEmailsEnabledFeatureFlag?.value;
 
-    let savedMessageParticipants: ObjectRecord<MessageParticipantWorkspaceEntity>[] =
-      [];
+    let savedMessageParticipants: MessageParticipantWorkspaceEntity[] = [];
 
     const participantsWithMessageId = await workspaceDataSource?.transaction(
       async (transactionManager: EntityManager) => {