Remove useless columns (#13312)

packages/twenty-server/src/database/commands/upgrade-version-command/1-1/1-1-migrate-workflow-run-state.command.ts

@@ -95,11 +95,12 @@ export class MigrateWorkflowRunStatesCommand extends ActiveOrSuspendedWorkspaces
         ? { where: { startedAt: MoreThan(this.afterDate) } }
         : {};
 
-      const workflowRuns = await workflowRunRepository.find({
+      const workflowRuns = (await workflowRunRepository.find({
         ...findOption,
         skip: offset * this.chunkSize,
         take: this.chunkSize,
-      });
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      })) as any[]; // We type as any as workflowRun output has been removed since 1.1.0 release
 
       for (const workflowRun of workflowRuns) {
         const output = workflowRun.output;

packages/twenty-server/src/database/commands/upgrade-version-command/1-2/1-2-remove-workflow-runs-without-state.command.ts

@@ -0,0 +1,39 @@
+import { InjectRepository } from '@nestjs/typeorm';
+
+import { Command } from 'nest-commander';
+import { IsNull, Repository } from 'typeorm';
+
+import {
+  ActiveOrSuspendedWorkspacesMigrationCommandRunner,
+  RunOnWorkspaceArgs,
+} from 'src/database/commands/command-runners/active-or-suspended-workspaces-migration.command-runner';
+import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
+import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
+import { WorkflowRunWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-run.workspace-entity';
+
+@Command({
+  name: 'migrate:1-2:remove-workflow-runs-without-state',
+  description: 'Remove workflow runs without state.',
+})
+export class RemoveWorkflowRunsWithoutState extends ActiveOrSuspendedWorkspacesMigrationCommandRunner {
+  constructor(
+    @InjectRepository(Workspace, 'core')
+    protected readonly workspaceRepository: Repository<Workspace>,
+    protected readonly twentyORMGlobalManager: TwentyORMGlobalManager,
+  ) {
+    super(workspaceRepository, twentyORMGlobalManager);
+  }
+
+  override async runOnWorkspace({
+    workspaceId,
+  }: RunOnWorkspaceArgs): Promise<void> {
+    const workflowRunRepository =
+      await this.twentyORMGlobalManager.getRepositoryForWorkspace<WorkflowRunWorkspaceEntity>(
+        workspaceId,
+        'workflowRun',
+        { shouldBypassPermissionChecks: true },
+      );
+
+    await workflowRunRepository.delete({ state: IsNull() });
+  }
+}

packages/twenty-server/src/database/commands/upgrade-version-command/1-2/1-2-upgrade-version-command.module.ts

@@ -1,8 +1,12 @@
 import { Module } from '@nestjs/common';
+import { TypeOrmModule } from '@nestjs/typeorm';
+
+import { RemoveWorkflowRunsWithoutState } from 'src/database/commands/upgrade-version-command/1-2/1-2-remove-workflow-runs-without-state.command';
+import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 
 @Module({
-  imports: [],
-  providers: [],
-  exports: [],
+  imports: [TypeOrmModule.forFeature([Workspace], 'core')],
+  providers: [RemoveWorkflowRunsWithoutState],
+  exports: [RemoveWorkflowRunsWithoutState],
 })
 export class V1_2_UpgradeVersionCommandModule {}

packages/twenty-server/src/database/commands/upgrade-version-command/upgrade.command.ts

@@ -31,6 +31,7 @@ import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
 import { SyncWorkspaceMetadataCommand } from 'src/engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command';
 import { compareVersionMajorAndMinor } from 'src/utils/version/compare-version-minor-and-major';
+import { RemoveWorkflowRunsWithoutState } from 'src/database/commands/upgrade-version-command/1-2/1-2-remove-workflow-runs-without-state.command';
 
 const execPromise = promisify(exec);
 
@@ -149,6 +150,7 @@ export class UpgradeCommand extends UpgradeCommandRunner {
     protected readonly addEnqueuedStatusToWorkflowRunCommand: AddEnqueuedStatusToWorkflowRunCommand,
 
     // 1.2 Commands
+    protected readonly removeWorkflowRunsWithoutState: RemoveWorkflowRunsWithoutState,
 
     // 1.3 Commands
   ) {
@@ -202,7 +204,7 @@ export class UpgradeCommand extends UpgradeCommandRunner {
     };
 
     const commands_120: VersionCommands = {
-      beforeSyncMetadata: [],
+      beforeSyncMetadata: [this.removeWorkflowRunsWithoutState],
       afterSyncMetadata: [],
     };