From 9bd6d26d5337fc167578a5eac96b0faa789bfd1a Mon Sep 17 00:00:00 2001 From: Kanav Arora Date: Mon, 6 Nov 2023 22:28:03 +0530 Subject: [PATCH] 2299 fix(frontend): corrected tag spacing in settings object item table row (#2302) * fix(frontend): corrected tag spacing in settings object item table row * 2299-fix(front): pr requested changes * 2299 fix(front): PR requested changes - 2 --- .../components/SettingsObjectItemTableRow.tsx | 9 ++------- front/src/modules/ui/display/tag/components/Tag.tsx | 3 +-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/front/src/modules/settings/data-model/object-details/components/SettingsObjectItemTableRow.tsx b/front/src/modules/settings/data-model/object-details/components/SettingsObjectItemTableRow.tsx index d4ce5d90a..12c4990ae 100644 --- a/front/src/modules/settings/data-model/object-details/components/SettingsObjectItemTableRow.tsx +++ b/front/src/modules/settings/data-model/object-details/components/SettingsObjectItemTableRow.tsx @@ -24,11 +24,6 @@ const StyledNameTableCell = styled(TableCell)` gap: ${({ theme }) => theme.spacing(2)}; `; -const StyledTag = styled(Tag)` - box-sizing: border-box; - height: ${({ theme }) => theme.spacing(4)}; -`; - const StyledActionTableCell = styled(TableCell)` justify-content: center; padding-right: ${({ theme }) => theme.spacing(1)}; @@ -55,9 +50,9 @@ export const SettingsObjectItemTableRow = ({ {objectItem.isCustom ? ( - + ) : ( - + )} {objectItem.fields.length} diff --git a/front/src/modules/ui/display/tag/components/Tag.tsx b/front/src/modules/ui/display/tag/components/Tag.tsx index 7bd0548b6..63868b059 100644 --- a/front/src/modules/ui/display/tag/components/Tag.tsx +++ b/front/src/modules/ui/display/tag/components/Tag.tsx @@ -33,11 +33,10 @@ const StyledTag = styled.h3<{ font-style: normal; font-weight: ${({ theme }) => theme.font.weight.medium}; gap: ${({ theme }) => theme.spacing(2)}; + height: ${({ theme }) => theme.spacing(5)}; margin: 0; - padding-bottom: ${({ theme }) => theme.spacing(1)}; padding-left: ${({ theme }) => theme.spacing(2)}; padding-right: ${({ theme }) => theme.spacing(2)}; - padding-top: ${({ theme }) => theme.spacing(1)}; `; export type TagProps = {