feat: better server lint (#2850)

* feat: add stylistic eslint plugin

* feat: add missing line return

* feat: secure line-break style

* feat: disallow break before else

* feat: line between class members

* feat: better new line lint rule

server/src/metadata/field-metadata/field-metadata.service.ts

@@ -129,6 +129,7 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit
         if (position > acc) {
           return position;
         }
+
         return acc;
       }, -1);
 

server/src/metadata/field-metadata/hooks/before-create-one-field.hook.ts

@@ -16,11 +16,13 @@ export class BeforeCreateOneField<T extends CreateFieldInput>
     context: any,
   ): Promise<CreateOneInputType<T>> {
     const workspaceId = context?.req?.user?.workspace?.id;
+
     if (!workspaceId) {
       throw new UnauthorizedException();
     }
 
     instance.input.workspaceId = workspaceId;
+
     return instance;
   }
 }

server/src/metadata/field-metadata/utils/__tests__/generate-target-column-map.spec.ts

@@ -10,6 +10,7 @@ describe('generateTargetColumnMap', () => {
       false,
       'name',
     );
+
     expect(textMap).toEqual({ value: 'name' });
 
     const linkMap = generateTargetColumnMap(
@@ -17,6 +18,7 @@ describe('generateTargetColumnMap', () => {
       false,
       'website',
     );
+
     expect(linkMap).toEqual({ label: 'websiteLabel', url: 'websiteUrl' });
 
     const currencyMap = generateTargetColumnMap(
@@ -24,6 +26,7 @@ describe('generateTargetColumnMap', () => {
       true,
       'price',
     );
+
     expect(currencyMap).toEqual({
       amountMicros: '_priceAmountMicros',
       currencyCode: '_priceCurrencyCode',

server/src/metadata/field-metadata/utils/__tests__/serialize-default-value.spec.ts

@@ -40,6 +40,7 @@ describe('serializeDefaultValue', () => {
 
   it('should handle Date static default value', () => {
     const date = new Date('2023-01-01');
+
     expect(serializeDefaultValue(date)).toBe(`'${date.toISOString()}'`);
   });
 });

server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts

@@ -36,6 +36,7 @@ export class BeforeCreateOneObject<T extends CreateObjectInput>
       );
     }
     instance.input.workspaceId = workspaceId;
+
     return instance;
   }
 }

server/src/metadata/object-metadata/object-metadata.service.ts

@@ -197,6 +197,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
           if (fieldMetadata.type === FieldMetadataType.RELATION) {
             acc[fieldMetadata.objectMetadataId] = fieldMetadata;
           }
+
           return acc;
         },
         {},
@@ -282,6 +283,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
       ("objectMetadataId", "type", "name")
       VALUES ('${createdObjectMetadata.id}', 'table', 'All ${createdObjectMetadata.namePlural}') RETURNING *`,
     );
+
     createdObjectMetadata.fields.map(async (field, index) => {
       if (field.name === 'id') {
         return;

server/src/metadata/relation-metadata/hooks/before-create-one-relation.hook.ts

@@ -22,6 +22,7 @@ export class BeforeCreateOneRelation<T extends CreateRelationInput>
     }
 
     instance.input.workspaceId = workspaceId;
+
     return instance;
   }
 }

server/src/metadata/relation-metadata/relation-metadata.service.ts

@@ -97,6 +97,7 @@ export class RelationMetadataService extends TypeOrmQueryService<RelationMetadat
 
     const objectMetadataMap = objectMetadataEntries.reduce((acc, curr) => {
       acc[curr.id] = curr;
+
       return acc;
     }, {} as { [key: string]: ObjectMetadataEntity });
 
@@ -169,6 +170,7 @@ export class RelationMetadataService extends TypeOrmQueryService<RelationMetadat
       if (fieldMetadata.type === FieldMetadataType.RELATION) {
         acc[fieldMetadata.objectMetadataId] = fieldMetadata;
       }
+
       return acc;
     }, {});
 

server/src/metadata/workspace-migration/workspace-migration.factory.ts

@@ -94,11 +94,13 @@ export class WorkspaceMigrationFactory {
     action: WorkspaceMigrationColumnActionType.CREATE,
     fieldMetadata: FieldMetadataInterface,
   ): WorkspaceMigrationColumnAction[];
+
   createColumnActions(
     action: WorkspaceMigrationColumnActionType.ALTER,
     previousFieldMetadata: FieldMetadataInterface,
     nextFieldMetadata: FieldMetadataInterface,
   ): WorkspaceMigrationColumnAction[];
+
   createColumnActions(
     action:
       | WorkspaceMigrationColumnActionType.CREATE

server/src/metadata/workspace-migration/workspace-migration.service.ts

@@ -31,6 +31,7 @@ export class WorkspaceMigrationService {
     const insertedStandardMigrationsMapByName =
       insertedStandardMigrations.reduce((acc, migration) => {
         acc[migration.name] = migration;
+
         return acc;
       }, {});