From b1c57edc90fbef45ca0cccabb726fae2ef52b73d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Bosi?=
 <71827178+bosiraphael@users.noreply.github.com>
Date: Fri, 28 Mar 2025 11:01:55 +0100
Subject: [PATCH] Display a tooltip for actions without short labels (#11243)

- Merge `RecordIndexActionMenuButtons` and `RecordShowActionMenuButtons`
into a single component `PageHeaderActionMenuButtons`
- Display tooltip after 1s for actions without short labels


https://github.com/user-attachments/assets/7649bed8-a1a9-4c1d-8fbe-f1bf3a51db56
---
 .../PageHeaderActionMenuButtons.tsx           | 64 +++++++++++++++++
 .../components/RecordIndexActionMenu.tsx      |  4 +-
 .../RecordIndexActionMenuButtons.tsx          | 29 --------
 .../components/RecordShowActionMenu.tsx       |  7 +-
 .../RecordShowActionMenuButtons.tsx           | 46 ------------
 .../components/RecordIndexPageHeader.tsx      |  4 +-
 ... => PageHeaderToggleCommandMenuButton.tsx} | 72 +++++++++++++------
 .../pages/object-record/RecordShowPage.tsx    |  2 +
 .../RecordShowPageBaseHeader.tsx              |  4 +-
 .../src/display/tooltip/AppTooltip.tsx        |  5 +-
 10 files changed, 131 insertions(+), 106 deletions(-)
 create mode 100644 packages/twenty-front/src/modules/action-menu/components/PageHeaderActionMenuButtons.tsx
 delete mode 100644 packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenuButtons.tsx
 delete mode 100644 packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenuButtons.tsx
 rename packages/twenty-front/src/modules/ui/layout/page-header/components/{PageHeaderOpenCommandMenuButton.tsx => PageHeaderToggleCommandMenuButton.tsx} (66%)

diff --git a/packages/twenty-front/src/modules/action-menu/components/PageHeaderActionMenuButtons.tsx b/packages/twenty-front/src/modules/action-menu/components/PageHeaderActionMenuButtons.tsx
new file mode 100644
index 000000000..63bc9cb3c
--- /dev/null
+++ b/packages/twenty-front/src/modules/action-menu/components/PageHeaderActionMenuButtons.tsx
@@ -0,0 +1,64 @@
+import { actionMenuEntriesComponentSelector } from '@/action-menu/states/actionMenuEntriesComponentSelector';
+import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
+import styled from '@emotion/styled';
+import { i18n } from '@lingui/core';
+import {
+  AppTooltip,
+  Button,
+  IconButton,
+  TooltipDelay,
+  TooltipPosition,
+} from 'twenty-ui';
+
+const StyledWrapper = styled.div`
+  font-size: ${({ theme }) => theme.font.size.md};
+`;
+
+export const PageHeaderActionMenuButtons = () => {
+  const actionMenuEntries = useRecoilComponentValueV2(
+    actionMenuEntriesComponentSelector,
+  );
+
+  const pinnedEntries = actionMenuEntries.filter((entry) => entry.isPinned);
+
+  return (
+    <>
+      {pinnedEntries.map((entry) =>
+        entry.shortLabel ? (
+          <Button
+            key={entry.key}
+            Icon={entry.Icon}
+            size="small"
+            variant="secondary"
+            accent="default"
+            title={entry.shortLabel ? i18n._(entry.shortLabel) : ''}
+            onClick={() => entry.onClick?.()}
+            ariaLabel={i18n._(entry.label)}
+          />
+        ) : (
+          <div id={`action-menu-entry-${entry.key}`} key={entry.key}>
+            <IconButton
+              Icon={entry.Icon}
+              size="small"
+              variant="secondary"
+              accent="default"
+              onClick={() => entry.onClick?.()}
+              ariaLabel={i18n._(entry.label)}
+            />
+            <StyledWrapper>
+              <AppTooltip
+                // eslint-disable-next-line
+                anchorSelect={`#action-menu-entry-${entry.key}`}
+                content={i18n._(entry.label)}
+                delay={TooltipDelay.longDelay}
+                place={TooltipPosition.Bottom}
+                offset={5}
+                noArrow
+              />
+            </StyledWrapper>
+          </div>
+        ),
+      )}
+    </>
+  );
+};
diff --git a/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx b/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx
index 5572a6b53..3341080f0 100644
--- a/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx
+++ b/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx
@@ -3,7 +3,7 @@ import { MultipleRecordsActionKeys } from '@/action-menu/actions/record-actions/
 import { RecordAgnosticActionMenuEntriesSetter } from '@/action-menu/actions/record-agnostic-actions/components/RecordAgnosticActionMenuEntriesSetter';
 import { RunWorkflowRecordAgnosticActionMenuEntriesSetter } from '@/action-menu/actions/record-agnostic-actions/components/RunWorkflowRecordAgnosticActionMenuEntriesSetter';
 import { ActionMenuConfirmationModals } from '@/action-menu/components/ActionMenuConfirmationModals';
-import { RecordIndexActionMenuButtons } from '@/action-menu/components/RecordIndexActionMenuButtons';
+import { PageHeaderActionMenuButtons } from '@/action-menu/components/PageHeaderActionMenuButtons';
 import { RecordIndexActionMenuDropdown } from '@/action-menu/components/RecordIndexActionMenuDropdown';
 import { ActionMenuContext } from '@/action-menu/contexts/ActionMenuContext';
 import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataItemIdComponentState';
@@ -48,7 +48,7 @@ export const RecordIndexActionMenu = ({ indexId }: { indexId: string }) => {
             },
           }}
         >
-          {!isMobile && <RecordIndexActionMenuButtons />}
+          {!isMobile && <PageHeaderActionMenuButtons />}
           <RecordIndexActionMenuDropdown />
           <ActionMenuConfirmationModals />
           <RecordActionMenuEntriesSetter />
diff --git a/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenuButtons.tsx b/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenuButtons.tsx
deleted file mode 100644
index 8414af2f4..000000000
--- a/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenuButtons.tsx
+++ /dev/null
@@ -1,29 +0,0 @@
-import { actionMenuEntriesComponentSelector } from '@/action-menu/states/actionMenuEntriesComponentSelector';
-import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
-import { i18n } from '@lingui/core';
-import { Button } from 'twenty-ui';
-
-export const RecordIndexActionMenuButtons = () => {
-  const actionMenuEntries = useRecoilComponentValueV2(
-    actionMenuEntriesComponentSelector,
-  );
-
-  const pinnedEntries = actionMenuEntries.filter((entry) => entry.isPinned);
-
-  return (
-    <>
-      {pinnedEntries.map((entry, index) => (
-        <Button
-          key={index}
-          Icon={entry.Icon}
-          size="small"
-          variant="secondary"
-          accent="default"
-          title={entry.shortLabel ? i18n._(entry.shortLabel) : ''}
-          onClick={entry.onClick}
-          ariaLabel={i18n._(entry.label)}
-        />
-      ))}
-    </>
-  );
-};
diff --git a/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx b/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx
index a3e718eb2..7884d2818 100644
--- a/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx
+++ b/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx
@@ -2,12 +2,13 @@ import { RecordActionMenuEntriesSetter } from '@/action-menu/actions/record-acti
 import { RecordAgnosticActionMenuEntriesSetter } from '@/action-menu/actions/record-agnostic-actions/components/RecordAgnosticActionMenuEntriesSetter';
 import { RunWorkflowRecordAgnosticActionMenuEntriesSetter } from '@/action-menu/actions/record-agnostic-actions/components/RunWorkflowRecordAgnosticActionMenuEntriesSetter';
 import { ActionMenuConfirmationModals } from '@/action-menu/components/ActionMenuConfirmationModals';
-import { RecordShowActionMenuButtons } from '@/action-menu/components/RecordShowActionMenuButtons';
+import { PageHeaderActionMenuButtons } from '@/action-menu/components/PageHeaderActionMenuButtons';
 import { ActionMenuContext } from '@/action-menu/contexts/ActionMenuContext';
 import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataItemIdComponentState';
 import { contextStoreTargetedRecordsRuleComponentState } from '@/context-store/states/contextStoreTargetedRecordsRuleComponentState';
 import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
 import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
+import { useIsMobile } from 'twenty-ui';
 import { FeatureFlagKey } from '~/generated/graphql';
 
 export const RecordShowActionMenu = () => {
@@ -27,6 +28,8 @@ export const RecordShowActionMenu = () => {
     FeatureFlagKey.IsWorkflowEnabled,
   );
 
+  const isMobile = useIsMobile();
+
   return (
     <>
       {hasSelectedRecord && contextStoreCurrentObjectMetadataItemId && (
@@ -36,7 +39,7 @@ export const RecordShowActionMenu = () => {
             onActionExecutedCallback: () => {},
           }}
         >
-          <RecordShowActionMenuButtons />
+          {!isMobile && <PageHeaderActionMenuButtons />}
           <ActionMenuConfirmationModals />
           <RecordActionMenuEntriesSetter />
           <RecordAgnosticActionMenuEntriesSetter />
diff --git a/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenuButtons.tsx b/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenuButtons.tsx
deleted file mode 100644
index ef90193f7..000000000
--- a/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenuButtons.tsx
+++ /dev/null
@@ -1,46 +0,0 @@
-import { actionMenuEntriesComponentSelector } from '@/action-menu/states/actionMenuEntriesComponentSelector';
-import { PageHeaderOpenCommandMenuButton } from '@/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton';
-import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
-import { i18n } from '@lingui/core';
-import { Button, IconButton, useIsMobile } from 'twenty-ui';
-
-export const RecordShowActionMenuButtons = () => {
-  const actionMenuEntries = useRecoilComponentValueV2(
-    actionMenuEntriesComponentSelector,
-  );
-
-  const pinnedEntries = actionMenuEntries.filter((entry) => entry.isPinned);
-
-  const isMobile = useIsMobile();
-
-  return (
-    <>
-      {!isMobile &&
-        pinnedEntries.map((entry) =>
-          entry.shortLabel ? (
-            <Button
-              key={entry.key}
-              Icon={entry.Icon}
-              size="small"
-              variant="secondary"
-              accent="default"
-              title={i18n._(entry.shortLabel)}
-              onClick={() => entry.onClick?.()}
-              ariaLabel={i18n._(entry.label)}
-            />
-          ) : (
-            <IconButton
-              key={entry.key}
-              Icon={entry.Icon}
-              size="small"
-              variant="secondary"
-              accent="default"
-              onClick={() => entry.onClick?.()}
-              ariaLabel={i18n._(entry.label)}
-            />
-          ),
-        )}
-      <PageHeaderOpenCommandMenuButton key="more" />
-    </>
-  );
-};
diff --git a/packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexPageHeader.tsx b/packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexPageHeader.tsx
index ae282f578..3638e96e4 100644
--- a/packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexPageHeader.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexPageHeader.tsx
@@ -2,7 +2,7 @@ import { RecordIndexActionMenu } from '@/action-menu/components/RecordIndexActio
 import { contextStoreNumberOfSelectedRecordsComponentState } from '@/context-store/states/contextStoreNumberOfSelectedRecordsComponentState';
 import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilteredObjectMetadataItems';
 import { useRecordIndexContextOrThrow } from '@/object-record/record-index/contexts/RecordIndexContext';
-import { PageHeaderOpenCommandMenuButton } from '@/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton';
+import { PageHeaderToggleCommandMenuButton } from '@/ui/layout/page-header/components/PageHeaderToggleCommandMenuButton';
 import { PageHeader } from '@/ui/layout/page/components/PageHeader';
 import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
 import styled from '@emotion/styled';
@@ -62,7 +62,7 @@ export const RecordIndexPageHeader = () => {
   return (
     <PageHeader title={pageHeaderTitle} Icon={Icon}>
       <RecordIndexActionMenu indexId={recordIndexId} />
-      <PageHeaderOpenCommandMenuButton />
+      <PageHeaderToggleCommandMenuButton />
     </PageHeader>
   );
 };
diff --git a/packages/twenty-front/src/modules/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton.tsx b/packages/twenty-front/src/modules/ui/layout/page-header/components/PageHeaderToggleCommandMenuButton.tsx
similarity index 66%
rename from packages/twenty-front/src/modules/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton.tsx
rename to packages/twenty-front/src/modules/ui/layout/page-header/components/PageHeaderToggleCommandMenuButton.tsx
index c1e74535c..d8d9ba4bf 100644
--- a/packages/twenty-front/src/modules/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton.tsx
+++ b/packages/twenty-front/src/modules/ui/layout/page-header/components/PageHeaderToggleCommandMenuButton.tsx
@@ -1,9 +1,17 @@
-import { AnimatedButton, getOsControlSymbol, useIsMobile } from 'twenty-ui';
+import {
+  AnimatedButton,
+  AppTooltip,
+  getOsControlSymbol,
+  TooltipDelay,
+  TooltipPosition,
+  useIsMobile,
+} from 'twenty-ui';
 
 import { useCommandMenu } from '@/command-menu/hooks/useCommandMenu';
 import { isCommandMenuOpenedState } from '@/command-menu/states/isCommandMenuOpenedState';
 import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
+import { i18n } from '@lingui/core';
 import { t } from '@lingui/core/macro';
 import { motion } from 'framer-motion';
 import { useRecoilValue } from 'recoil';
@@ -12,6 +20,10 @@ const StyledButtonWrapper = styled.div`
   z-index: 30;
 `;
 
+const StyledTooltipWrapper = styled.div`
+  font-size: ${({ theme }) => theme.font.size.md};
+`;
+
 const xPaths = {
   topLeft: `M12 12 L6 6`,
   topRight: `M12 12 L18 6`,
@@ -98,7 +110,7 @@ const AnimatedIcon = ({
   );
 };
 
-export const PageHeaderOpenCommandMenuButton = () => {
+export const PageHeaderToggleCommandMenuButton = () => {
   const { toggleCommandMenu } = useCommandMenu();
   const isCommandMenuOpened = useRecoilValue(isCommandMenuOpenedState);
 
@@ -111,25 +123,41 @@ export const PageHeaderOpenCommandMenuButton = () => {
   const theme = useTheme();
 
   return (
-    <StyledButtonWrapper>
-      <AnimatedButton
-        animatedSvg={<AnimatedIcon isCommandMenuOpened={isCommandMenuOpened} />}
-        className="page-header-command-menu-button"
-        dataTestId="page-header-command-menu-button"
-        size={isMobile ? 'medium' : 'small'}
-        variant="secondary"
-        accent="default"
-        hotkeys={[getOsControlSymbol(), 'K']}
-        ariaLabel={ariaLabel}
-        onClick={toggleCommandMenu}
-        animate={{
-          rotate: isCommandMenuOpened ? 90 : 0,
-        }}
-        transition={{
-          duration: theme.animation.duration.normal,
-          ease: 'easeInOut',
-        }}
-      />
-    </StyledButtonWrapper>
+    <>
+      <StyledButtonWrapper>
+        <div id="toggle-command-menu-button">
+          <AnimatedButton
+            animatedSvg={
+              <AnimatedIcon isCommandMenuOpened={isCommandMenuOpened} />
+            }
+            className="page-header-command-menu-button"
+            dataTestId="page-header-command-menu-button"
+            size={isMobile ? 'medium' : 'small'}
+            variant="secondary"
+            accent="default"
+            hotkeys={[getOsControlSymbol(), 'K']}
+            ariaLabel={ariaLabel}
+            onClick={toggleCommandMenu}
+            animate={{
+              rotate: isCommandMenuOpened ? 90 : 0,
+            }}
+            transition={{
+              duration: theme.animation.duration.normal,
+              ease: 'easeInOut',
+            }}
+          />
+        </div>
+      </StyledButtonWrapper>
+      <StyledTooltipWrapper>
+        <AppTooltip
+          anchorSelect="#toggle-command-menu-button"
+          content={i18n._(ariaLabel)}
+          delay={TooltipDelay.longDelay}
+          place={TooltipPosition.Bottom}
+          offset={5}
+          noArrow
+        />
+      </StyledTooltipWrapper>
+    </>
   );
 };
diff --git a/packages/twenty-front/src/pages/object-record/RecordShowPage.tsx b/packages/twenty-front/src/pages/object-record/RecordShowPage.tsx
index 9c1dcbb6d..a1be446a7 100644
--- a/packages/twenty-front/src/pages/object-record/RecordShowPage.tsx
+++ b/packages/twenty-front/src/pages/object-record/RecordShowPage.tsx
@@ -13,6 +13,7 @@ import { useRecordShowPage } from '@/object-record/record-show/hooks/useRecordSh
 import { RecordSortsComponentInstanceContext } from '@/object-record/record-sort/states/context/RecordSortsComponentInstanceContext';
 import { RecordValueSetterEffect } from '@/object-record/record-store/components/RecordValueSetterEffect';
 import { RecordFieldValueSelectorContextProvider } from '@/object-record/record-store/contexts/RecordFieldValueSelectorContext';
+import { PageHeaderToggleCommandMenuButton } from '@/ui/layout/page-header/components/PageHeaderToggleCommandMenuButton';
 import { PageBody } from '@/ui/layout/page/components/PageBody';
 import { PageContainer } from '@/ui/layout/page/components/PageContainer';
 import { RecordShowPageHeader } from '~/pages/object-record/RecordShowPageHeader';
@@ -57,6 +58,7 @@ export const RecordShowPage = () => {
                     objectRecordId={objectRecordId}
                   >
                     <RecordShowActionMenu />
+                    <PageHeaderToggleCommandMenuButton />
                   </RecordShowPageHeader>
                   <PageBody>
                     <TimelineActivityContext.Provider
diff --git a/packages/twenty-front/src/pages/object-record/RecordShowPageBaseHeader.tsx b/packages/twenty-front/src/pages/object-record/RecordShowPageBaseHeader.tsx
index 91655d8ac..b9b8710be 100644
--- a/packages/twenty-front/src/pages/object-record/RecordShowPageBaseHeader.tsx
+++ b/packages/twenty-front/src/pages/object-record/RecordShowPageBaseHeader.tsx
@@ -3,7 +3,7 @@ import { PageFavoriteFoldersDropdown } from '@/favorites/components/PageFavorite
 import { FAVORITE_FOLDER_PICKER_DROPDOWN_ID } from '@/favorites/favorite-folder-picker/constants/FavoriteFolderPickerDropdownId';
 import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
 import { ObjectRecord } from '@/object-record/types/ObjectRecord';
-import { PageHeaderOpenCommandMenuButton } from '@/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton';
+import { PageHeaderToggleCommandMenuButton } from '@/ui/layout/page-header/components/PageHeaderToggleCommandMenuButton';
 import { ShowPageAddButton } from '@/ui/layout/show-page/components/ShowPageAddButton';
 import { useIsMobile } from 'twenty-ui';
 
@@ -51,7 +51,7 @@ export const RecordShowPageBaseHeader = ({
           />
         </>
       )}
-      <PageHeaderOpenCommandMenuButton key="more" />
+      <PageHeaderToggleCommandMenuButton key="more" />
     </>
   );
 };
diff --git a/packages/twenty-ui/src/display/tooltip/AppTooltip.tsx b/packages/twenty-ui/src/display/tooltip/AppTooltip.tsx
index 39e0ea251..2cef68f46 100644
--- a/packages/twenty-ui/src/display/tooltip/AppTooltip.tsx
+++ b/packages/twenty-ui/src/display/tooltip/AppTooltip.tsx
@@ -14,6 +14,7 @@ export enum TooltipDelay {
   noDelay = '0ms',
   shortDelay = '300ms',
   mediumDelay = '500ms',
+  longDelay = '1000ms',
 }
 
 const StyledAppTooltip = styled(Tooltip)<{ width?: string }>`
@@ -73,7 +74,9 @@ export const AppTooltip = ({
       ? 0
       : delay === TooltipDelay.shortDelay
         ? 300
-        : 500;
+        : delay === TooltipDelay.mediumDelay
+          ? 500
+          : 1000;
 
   return (
     <StyledAppTooltip