mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix-inline-height (#11608)

Browse Source 
Follow up from inline height #11553 related to PR #11442


we had some issues with hover styles

Fixes
https://github.com/twentyhq/twenty/issues/11442#issuecomment-2805893663

---------

Co-authored-by: etiennejouan <jouan.etienne@gmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Guillim
2025-04-16 17:49:04 +02:00
committed by GitHub
parent e1b99a6f39
commit b6901a49bf
10 changed files with 53 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/FullNameFieldDisplay.tsx
View File

@ -1,7 +1,7 @@
import { isNonEmptyString } from '@sniptt/guards';
import { useFullNameFieldDisplay } from '@/object-record/record-field/meta-types/hooks/useFullNameFieldDisplay';
import { OverflowingTextWithTooltip } from 'twenty-ui/display';
import { TextDisplay } from '@/ui/field/display/components/TextDisplay';
export const FullNameFieldDisplay = () => {
const { fieldValue } = useFullNameFieldDisplay();
@ -10,5 +10,5 @@ export const FullNameFieldDisplay = () => {
.filter(isNonEmptyString)
.join(' ');
return <OverflowingTextWithTooltip text={content} />;
return <TextDisplay text={content} />;
};

2
packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/NumberFieldDisplay.tsx
View File

@ -1,7 +1,7 @@
import { useNumberFieldDisplay } from '@/object-record/record-field/meta-types/hooks/useNumberFieldDisplay';
import { NumberDisplay } from '@/ui/field/display/components/NumberDisplay';
import { formatNumber } from '~/utils/format/number';
import { isDefined } from 'twenty-shared/utils';
import { formatNumber } from '~/utils/format/number';
export const NumberFieldDisplay = () => {
const { fieldValue, fieldDefinition } = useNumberFieldDisplay();

11
packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/TextFieldDisplay.tsx
View File

@ -10,12 +10,11 @@ export const TextFieldDisplay = () => {
? fieldDefinition.metadata?.settings?.displayedMaxRows
: undefined;
const displayMaxRowCalculated = displayedMaxRows
? displayedMaxRows
: displayedMaxRowsFromSettings;
return (
<TextDisplay
text={fieldValue}
displayedMaxRows={
displayedMaxRows ? displayedMaxRows : displayedMaxRowsFromSettings
}
/>
<TextDisplay text={fieldValue} displayedMaxRows={displayMaxRowCalculated} />
);
};

6
packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellDisplayMode.tsx
View File

@ -48,10 +48,16 @@ const StyledRecordInlineCellNormalModeInnerContainer = styled.div`
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
padding-top: 2px;
padding-bottom: 2px;
`;
const StyledEmptyField = styled.div`
color: ${({ theme }) => theme.font.color.light};
height: 20px;
display: flex;
align-items: center;
`;
export const RecordInlineCellDisplayMode = ({

3
packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx
View File

@ -33,10 +33,9 @@ const StyledEmptyText = withTheme(styled.div<{ theme: Theme }>`
export const RecordTitleCellSingleTextDisplayMode = () => {
const { recordId, fieldDefinition } = useContext(FieldContext);
const recordValue = useRecordValue(recordId);
const isEmpty =
recordValue?.[fieldDefinition.metadata.fieldName].trim() === '';
recordValue?.[fieldDefinition.metadata.fieldName]?.trim() === '';
const { openInlineCell } = useInlineCell();