mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Update the frontend to adhere to the custom eslint rule twenty/no-spread-props (#1958)

Browse Source 
* Update the frontend to adhere to the custom eslint rule `twenty/no-spread-props`

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Update the frontend to adhere to the custom eslint rule `twenty/no-spread-props`

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* resolve bug with data-testid

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: bosiraphael <raphael.bosi@gmail.com>
This commit is contained in:
gitstart-twenty
2023-10-10 16:40:49 +03:00
committed by GitHub
parent 5dddd77eb3
commit bf397bc6ec
33 changed files with 276 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
front/src/modules/ui/dialog/components/Dialog.tsx
View File

@ -79,7 +79,7 @@ export const Dialog = ({
allowDismiss = true,
children,
onClose,
...rootProps
id,
}: DialogProps) => {
const closeSnackbar = useCallback(() => {
onClose && onClose();
@ -137,23 +137,20 @@ export const Dialog = ({
<StyledDialogContainer
variants={containerVariants}
transition={{ damping: 15, stiffness: 100 }}
// eslint-disable-next-line twenty/no-spread-props
{...rootProps}
id={id}
>
{title && <StyledDialogTitle>{title}</StyledDialogTitle>}
{message && <StyledDialogMessage>{message}</StyledDialogMessage>}
{children}
{buttons.map((button) => (
{buttons.map(({ accent, onClick, role, title: key, variant }) => (
<StyledDialogButton
key={button.title}
onClick={(event) => {
button?.onClick?.(event);
onClick?.(event);
closeSnackbar();
}}
fullWidth={true}
variant={button.variant ?? 'secondary'}
// eslint-disable-next-line twenty/no-spread-props
{...button}
variant={variant ?? 'secondary'}
{...{ accent, key, role }}
/>
))}
</StyledDialogContainer>