Remove Metadata SoftDelete and page limit size (#2237)

* Remove Metadata SoftDelete and page limit size

* add cascade deletion

* add missing queryRunner release

server/src/metadata/field-metadata/field-metadata.entity.ts

@@ -3,7 +3,6 @@ import { Field, ID, ObjectType } from '@nestjs/graphql';
 import {
   Column,
   CreateDateColumn,
-  DeleteDateColumn,
   Entity,
   JoinColumn,
   ManyToOne,
@@ -35,11 +34,14 @@ export type FieldMetadataTargetColumnMap = {
 })
 @QueryOptions({
   defaultResultSize: 10,
-  maxResultsSize: 100,
   disableFilter: true,
   disableSort: true,
 })
-@Unique('IndexOnNameAndWorkspaceIdUnique', ['name', 'objectId', 'workspaceId'])
+@Unique('IndexOnNameObjectIdAndWorkspaceIdUnique', [
+  'name',
+  'objectId',
+  'workspaceId',
+])
 export class FieldMetadata {
   @IDField(() => ID)
   @PrimaryGeneratedColumn('uuid')
@@ -92,7 +94,9 @@ export class FieldMetadata {
   @Column({ nullable: false, name: 'workspace_id' })
   workspaceId: string;
 
-  @ManyToOne(() => ObjectMetadata, (object) => object.fields)
+  @ManyToOne(() => ObjectMetadata, (object) => object.fields, {
+    onDelete: 'CASCADE',
+  })
   @JoinColumn({ name: 'object_id' })
   object: ObjectMetadata;
 
@@ -103,7 +107,4 @@ export class FieldMetadata {
   @Field()
   @UpdateDateColumn({ name: 'updated_at' })
   updatedAt: Date;
-
-  @DeleteDateColumn({ name: 'deleted_at' })
-  deletedAt?: Date;
 }

server/src/metadata/field-metadata/services/field-metadata.service.ts

@@ -1,4 +1,5 @@
 import {
+  BadRequestException,
   ConflictException,
   Injectable,
   NotFoundException,
@@ -7,6 +8,7 @@ import { InjectRepository } from '@nestjs/typeorm';
 
 import { Repository } from 'typeorm';
 import { TypeOrmQueryService } from '@ptc-org/nestjs-query-typeorm';
+import { DeleteOneOptions } from '@ptc-org/nestjs-query-core';
 
 import { FieldMetadata } from 'src/metadata/field-metadata/field-metadata.entity';
 import {
@@ -28,7 +30,30 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadata> {
     private readonly tenantMigrationService: TenantMigrationService,
     private readonly migrationRunnerService: MigrationRunnerService,
   ) {
-    super(fieldMetadataRepository, { useSoftDelete: true });
+    super(fieldMetadataRepository);
+  }
+
+  override async deleteOne(
+    id: string,
+    opts?: DeleteOneOptions<FieldMetadata> | undefined,
+  ): Promise<FieldMetadata> {
+    const fieldMetadata = await this.fieldMetadataRepository.findOne({
+      where: { id },
+    });
+
+    if (!fieldMetadata) {
+      throw new NotFoundException('Field does not exist');
+    }
+
+    if (!fieldMetadata.isCustom) {
+      throw new BadRequestException("Standard fields can't be deleted");
+    }
+
+    if (fieldMetadata.isActive) {
+      throw new BadRequestException("Active fields can't be deleted");
+    }
+
+    return super.deleteOne(id, opts);
   }
 
   override async createOne(record: FieldMetadata): Promise<FieldMetadata> {