From c2131a29b8e9a99b785c8fcfe0f1b10d6a4bd691 Mon Sep 17 00:00:00 2001 From: Mithra <50359897+GsnMithra@users.noreply.github.com> Date: Thu, 30 Nov 2023 19:11:03 +0530 Subject: [PATCH] Renaming "Experience" to "Appearance" (#2776) * refining settings * Delete .idea/workspace.xml * Update .gitignore --- .gitignore | 3 ++- front/src/App.tsx | 6 +++--- .../src/modules/settings/components/SettingsNavbar.tsx | 6 +++--- front/src/modules/types/SettingsPath.ts | 2 +- .../components/__stories__/SubMenuNavbar.stories.tsx | 4 ++-- .../{SettingsExperience.tsx => SettingsAppearance.tsx} | 6 +++--- ...ence.stories.tsx => SettingsAppearance.stories.tsx} | 10 +++++----- front/src/utils/title-utils.ts | 4 ++-- 8 files changed, 21 insertions(+), 20 deletions(-) rename front/src/pages/settings/{SettingsExperience.tsx => SettingsAppearance.tsx} (88%) rename front/src/pages/settings/__stories__/{SettingsExperience.stories.tsx => SettingsAppearance.stories.tsx} (60%) diff --git a/.gitignore b/.gitignore index 75c8b73ca..4045b6c1d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,6 @@ **/**/.env .DS_Store +.idea/workspace.xml node_modules/ # yarn is the recommended package manager across the project -.package-lock.json \ No newline at end of file +.package-lock.json diff --git a/front/src/App.tsx b/front/src/App.tsx index d0c6f2e6d..f4bd923fe 100644 --- a/front/src/App.tsx +++ b/front/src/App.tsx @@ -22,7 +22,7 @@ import { SettingsObjects } from '~/pages/settings/data-model/SettingsObjects'; import { SettingsDevelopersApiKeyDetail } from '~/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail'; import { SettingsDevelopersApiKeys } from '~/pages/settings/developers/api-keys/SettingsDevelopersApiKeys'; import { SettingsDevelopersApiKeysNew } from '~/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew'; -import { SettingsExperience } from '~/pages/settings/SettingsExperience'; +import { SettingsAppearance } from '~/pages/settings/SettingsAppearance'; import { SettingsProfile } from '~/pages/settings/SettingsProfile'; import { SettingsWorkspace } from '~/pages/settings/SettingsWorkspace'; import { SettingsWorkspaceMembers } from '~/pages/settings/SettingsWorkspaceMembers'; @@ -66,8 +66,8 @@ export const App = () => { element={} /> } + path={SettingsPath.Appearance} + element={} /> { } /> diff --git a/front/src/pages/settings/SettingsExperience.tsx b/front/src/pages/settings/SettingsAppearance.tsx similarity index 88% rename from front/src/pages/settings/SettingsExperience.tsx rename to front/src/pages/settings/SettingsAppearance.tsx index f52ed32c4..02a1735aa 100644 --- a/front/src/pages/settings/SettingsExperience.tsx +++ b/front/src/pages/settings/SettingsAppearance.tsx @@ -13,15 +13,15 @@ const StyledH1Title = styled(H1Title)` margin-bottom: 0; `; -export const SettingsExperience = () => { +export const SettingsAppearance = () => { const { colorScheme, setColorScheme } = useColorScheme(); return ( - +
- +
diff --git a/front/src/pages/settings/__stories__/SettingsExperience.stories.tsx b/front/src/pages/settings/__stories__/SettingsAppearance.stories.tsx similarity index 60% rename from front/src/pages/settings/__stories__/SettingsExperience.stories.tsx rename to front/src/pages/settings/__stories__/SettingsAppearance.stories.tsx index 5f9abc0dd..5bb3a33ea 100644 --- a/front/src/pages/settings/__stories__/SettingsExperience.stories.tsx +++ b/front/src/pages/settings/__stories__/SettingsAppearance.stories.tsx @@ -6,13 +6,13 @@ import { } from '~/testing/decorators/PageDecorator'; import { graphqlMocks } from '~/testing/graphqlMocks'; -import { SettingsExperience } from '../SettingsExperience'; +import { SettingsAppearance } from '../SettingsAppearance'; const meta: Meta = { - title: 'Pages/Settings/SettingsExperience', - component: SettingsExperience, + title: 'Pages/Settings/SettingsAppearance', + component: SettingsAppearance, decorators: [PageDecorator], - args: { routePath: '/settings/experience' }, + args: { routePath: '/settings/appearance' }, parameters: { msw: graphqlMocks, }, @@ -20,6 +20,6 @@ const meta: Meta = { export default meta; -export type Story = StoryObj; +export type Story = StoryObj; export const Default: Story = {}; diff --git a/front/src/utils/title-utils.ts b/front/src/utils/title-utils.ts index ff18aea44..a3de0171c 100644 --- a/front/src/utils/title-utils.ts +++ b/front/src/utils/title-utils.ts @@ -22,8 +22,8 @@ export const getPageTitleFromPath = (pathname: string): string => { return 'Opportunities'; case `${AppBasePath.Settings}/${SettingsPath.ProfilePage}`: return 'Profile'; - case `${AppBasePath.Settings}/${SettingsPath.Experience}`: - return 'Experience'; + case `${AppBasePath.Settings}/${SettingsPath.Appearance}`: + return 'Appearance'; case `${AppBasePath.Settings}/${SettingsPath.WorkspaceMembersPage}`: return 'Workspace Members'; case `${AppBasePath.Settings}/${SettingsPath.Workspace}`: