Add identifier fields to ObjectMetadata (#2616)

* Add indentifier fields to ObjectMetadata

* Add indentifier fields to ObjectMetadata

* Add indentifier fields to ObjectMetadata

* temporarily block name/label edition

server/src/metadata/relation-metadata/dtos/relation-metadata.dto.ts

@@ -9,6 +9,7 @@ import {
 import { CreateDateColumn, UpdateDateColumn } from 'typeorm';
 import {
   Authorize,
+  BeforeDeleteOne,
   IDField,
   QueryOptions,
   Relation,
@@ -16,6 +17,7 @@ import {
 
 import { ObjectMetadataDTO } from 'src/metadata/object-metadata/dtos/object-metadata.dto';
 import { RelationMetadataType } from 'src/metadata/relation-metadata/relation-metadata.entity';
+import { BeforeDeleteOneRelation } from 'src/metadata/relation-metadata/hooks/before-delete-one-field.hook';
 
 registerEnumType(RelationMetadataType, {
   name: 'RelationMetadataType',
@@ -34,6 +36,7 @@ registerEnumType(RelationMetadataType, {
   disableSort: true,
   maxResultsSize: 1000,
 })
+@BeforeDeleteOne(BeforeDeleteOneRelation)
 @Relation('fromObjectMetadata', () => ObjectMetadataDTO)
 @Relation('toObjectMetadata', () => ObjectMetadataDTO)
 export class RelationMetadataDTO {

server/src/metadata/relation-metadata/hooks/before-delete-one-field.hook.ts

@@ -0,0 +1,54 @@
+import {
+  BadRequestException,
+  Injectable,
+  UnauthorizedException,
+} from '@nestjs/common';
+
+import {
+  BeforeDeleteOneHook,
+  DeleteOneInputType,
+} from '@ptc-org/nestjs-query-graphql';
+
+import { RelationMetadataService } from 'src/metadata/relation-metadata/relation-metadata.service';
+
+@Injectable()
+export class BeforeDeleteOneRelation implements BeforeDeleteOneHook<any> {
+  constructor(readonly relationMetadataService: RelationMetadataService) {}
+
+  async run(
+    instance: DeleteOneInputType,
+    context: any,
+  ): Promise<DeleteOneInputType> {
+    const workspaceId = context?.req?.user?.workspace?.id;
+
+    if (!workspaceId) {
+      throw new UnauthorizedException();
+    }
+
+    const relationMetadata =
+      await this.relationMetadataService.findOneWithinWorkspace(
+        instance.id.toString(),
+        workspaceId,
+      );
+
+    if (!relationMetadata) {
+      throw new BadRequestException('Relation does not exist');
+    }
+
+    if (
+      !relationMetadata.toFieldMetadata.isCustom ||
+      !relationMetadata.fromFieldMetadata.isCustom
+    ) {
+      throw new BadRequestException("Standard Relations can't be deleted");
+    }
+
+    if (
+      relationMetadata.toFieldMetadata.isActive ||
+      relationMetadata.fromFieldMetadata.isActive
+    ) {
+      throw new BadRequestException("Active relations can't be deleted");
+    }
+
+    return instance;
+  }
+}

server/src/metadata/relation-metadata/relation-metadata.service.ts

@@ -36,6 +36,7 @@ export class RelationMetadataService extends TypeOrmQueryService<RelationMetadat
   }
 
   override async deleteOne(id: string): Promise<RelationMetadataEntity> {
+    // TODO: This logic is duplicated with the BeforeDeleteOneRelation hook
     const relationMetadata = await this.relationMetadataRepository.findOne({
       where: { id },
       relations: ['fromFieldMetadata', 'toFieldMetadata'],
@@ -45,22 +46,9 @@ export class RelationMetadataService extends TypeOrmQueryService<RelationMetadat
       throw new NotFoundException('Relation does not exist');
     }
 
-    if (
-      !relationMetadata.toFieldMetadata.isCustom ||
-      !relationMetadata.fromFieldMetadata.isCustom
-    ) {
-      throw new BadRequestException("Standard Relations can't be deleted");
-    }
-
-    if (
-      relationMetadata.toFieldMetadata.isActive ||
-      relationMetadata.fromFieldMetadata.isActive
-    ) {
-      throw new BadRequestException("Active relations can't be deleted");
-    }
-
     const deletedRelationMetadata = super.deleteOne(id);
 
+    // TODO: Move to a cdc scheduler
     this.fieldMetadataService.deleteMany({
       id: {
         in: [
@@ -213,4 +201,14 @@ export class RelationMetadataService extends TypeOrmQueryService<RelationMetadat
 
     return createdRelationMetadata;
   }
+
+  public async findOneWithinWorkspace(
+    relationMetadataId: string,
+    workspaceId: string,
+  ) {
+    return this.relationMetadataRepository.findOne({
+      where: { id: relationMetadataId, workspaceId },
+      relations: ['fromFieldMetadata', 'toFieldMetadata'],
+    });
+  }
 }