Refactor Views by cleaning the code, relying on apolloCache and improving performances (#4516)

* Wip refactoring view

* Post merge conflicts

* Fix review

* Add create view capability

* Fix create object missing view

* Fix tests

packages/twenty-front/src/modules/views/scopes/init-effect/ViewScopeInitEffect.tsx

@@ -1,64 +1,24 @@
 import { useEffect } from 'react';
 import { useSetRecoilState } from 'recoil';
 
-import { useViewScopedStates } from '@/views/hooks/internal/useViewScopedStates';
-import { ViewField } from '@/views/types/ViewField';
-import { ViewFilter } from '@/views/types/ViewFilter';
-import { ViewSort } from '@/views/types/ViewSort';
-import { ViewType } from '@/views/types/ViewType';
+import { useViewStates } from '@/views/hooks/internal/useViewStates';
+import { GraphQLView } from '@/views/types/GraphQLView';
 
 type ViewScopeInitEffectProps = {
   viewScopeId: string;
-  onViewSortsChange?: (sorts: ViewSort[]) => void | Promise<void>;
-  onViewFiltersChange?: (filters: ViewFilter[]) => void | Promise<void>;
-  onViewFieldsChange?: (fields: ViewField[]) => void | Promise<void>;
-  onViewTypeChange?: (viewType: ViewType) => void | Promise<void>;
-  onViewCompactModeChange?: (
-    isCompactModeActive: boolean,
-  ) => void | Promise<void>;
+  onCurrentViewChange: (view: GraphQLView | undefined) => void | Promise<void>;
 };
 
 export const ViewScopeInitEffect = ({
-  onViewSortsChange,
-  onViewFiltersChange,
-  onViewFieldsChange,
-  onViewTypeChange,
-  onViewCompactModeChange,
+  onCurrentViewChange,
 }: ViewScopeInitEffectProps) => {
-  const {
-    onViewFieldsChangeState,
-    onViewFiltersChangeState,
-    onViewSortsChangeState,
-    onViewTypeChangeState,
-    onViewCompactModeChangeState,
-  } = useViewScopedStates();
+  const { onCurrentViewChangeState } = useViewStates();
 
-  const setOnViewSortsChange = useSetRecoilState(onViewSortsChangeState);
-  const setOnViewFiltersChange = useSetRecoilState(onViewFiltersChangeState);
-  const setOnViewFieldsChange = useSetRecoilState(onViewFieldsChangeState);
-  const setOnViewTypeChange = useSetRecoilState(onViewTypeChangeState);
-  const setOnViewCompactModeChange = useSetRecoilState(
-    onViewCompactModeChangeState,
-  );
+  const setOnCurrentViewChange = useSetRecoilState(onCurrentViewChangeState);
 
   useEffect(() => {
-    setOnViewSortsChange(() => onViewSortsChange);
-    setOnViewFiltersChange(() => onViewFiltersChange);
-    setOnViewFieldsChange(() => onViewFieldsChange);
-    setOnViewTypeChange(() => onViewTypeChange);
-    setOnViewCompactModeChange(() => onViewCompactModeChange);
-  }, [
-    onViewCompactModeChange,
-    onViewFieldsChange,
-    onViewFiltersChange,
-    onViewSortsChange,
-    onViewTypeChange,
-    setOnViewCompactModeChange,
-    setOnViewFieldsChange,
-    setOnViewFiltersChange,
-    setOnViewSortsChange,
-    setOnViewTypeChange,
-  ]);
+    setOnCurrentViewChange(() => onCurrentViewChange);
+  }, [onCurrentViewChange, setOnCurrentViewChange]);
 
   return <></>;
 };