From dc617177a926b114e80b12848ab14d47bbd11eff Mon Sep 17 00:00:00 2001
From: Lucas Bordeau <bordeau.lucas@gmail.com>
Date: Tue, 22 Jul 2025 17:48:03 +0200
Subject: [PATCH] Fixed critical bug with record title cell opening (#13355)

This PR fixes a critical bug on record title cell opening when there was
no view loaded before.

This happened because the hook that opens the record title cell was
relying on a state that stored field definitions that were computed only
when a view was loaded.

Since there is no view on a record page, this wasn't working.

We should refactor field / column definitions so that they are always
derived from either view fields or an object metadata item's field
metadata items.

Fixes https://github.com/twentyhq/twenty/issues/13347
---
 .../hooks/useRecordTitleCell.tsx              | 26 +++++++++++++------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/packages/twenty-front/src/modules/object-record/record-title-cell/hooks/useRecordTitleCell.tsx b/packages/twenty-front/src/modules/object-record/record-title-cell/hooks/useRecordTitleCell.tsx
index 7490f053f..42c4c5c0c 100644
--- a/packages/twenty-front/src/modules/object-record/record-title-cell/hooks/useRecordTitleCell.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-title-cell/hooks/useRecordTitleCell.tsx
@@ -1,5 +1,6 @@
+import { useContextStoreObjectMetadataItemOrThrow } from '@/context-store/hooks/useContextStoreObjectMetadataItemOrThrow';
+import { formatFieldMetadataItemAsColumnDefinition } from '@/object-metadata/utils/formatFieldMetadataItemAsColumnDefinition';
 import { useInitDraftValueV2 } from '@/object-record/record-field/hooks/useInitDraftValueV2';
-import { recordIndexFieldDefinitionsState } from '@/object-record/record-index/states/recordIndexFieldDefinitionsState';
 import { isInlineCellInEditModeScopedState } from '@/object-record/record-inline-cell/states/isInlineCellInEditModeScopedState';
 import { RecordTitleCellContainerType } from '@/object-record/record-title-cell/types/RecordTitleCellContainerType';
 import { getRecordFieldInputInstanceId } from '@/object-record/utils/getRecordFieldInputId';
@@ -17,6 +18,8 @@ export const useRecordTitleCell = () => {
   const { removeFocusItemFromFocusStackById } =
     useRemoveFocusItemFromFocusStackById();
 
+  const { objectMetadataItem } = useContextStoreObjectMetadataItemOrThrow();
+
   const closeRecordTitleCell = useRecoilCallback(
     ({ set }) =>
       ({
@@ -55,7 +58,7 @@ export const useRecordTitleCell = () => {
   const initFieldInputDraftValue = useInitDraftValueV2();
 
   const openRecordTitleCell = useRecoilCallback(
-    ({ set, snapshot }) =>
+    ({ set }) =>
       ({
         recordId,
         fieldName,
@@ -92,16 +95,23 @@ export const useRecordTitleCell = () => {
         });
         set(isInlineCellInEditModeScopedState(recordTitleCellId), true);
 
-        const recordIndexFieldDefinitions = snapshot
-          .getLoadable(recordIndexFieldDefinitionsState)
-          .getValue();
+        const fieldDefinitions = objectMetadataItem.fields.map(
+          (fieldMetadataItem, index) =>
+            formatFieldMetadataItemAsColumnDefinition({
+              field: fieldMetadataItem,
+              objectMetadataItem,
+              position: index,
+            }),
+        );
 
-        const fieldDefinition = recordIndexFieldDefinitions.find(
+        const fieldDefinition = fieldDefinitions.find(
           (field) => field.metadata.fieldName === fieldName,
         );
 
         if (!fieldDefinition) {
-          return;
+          throw new Error(
+            `Cannot find field definition for field name ${fieldName}, this should not happen.`,
+          );
         }
 
         initFieldInputDraftValue({
@@ -110,7 +120,7 @@ export const useRecordTitleCell = () => {
           fieldComponentInstanceId: recordTitleCellId,
         });
       },
-    [initFieldInputDraftValue, pushFocusItemToFocusStack],
+    [initFieldInputDraftValue, pushFocusItemToFocusStack, objectMetadataItem],
   );
 
   return {