From eed502778af0a91f42e118a4a4d116eb54f396ff Mon Sep 17 00:00:00 2001 From: kahkashan shaik <93042682+kahkashanshaik@users.noreply.github.com> Date: Tue, 15 Jul 2025 15:35:45 +0530 Subject: [PATCH] fix: standardize trigger labels to lowercase (#13140) Updated trigger labels across various components to use lowercase formatting for consistency. This includes changes in the WorkflowVisualizerPage, DatabaseTriggerDefaultLabel, and other related files. The adjustments enhance readability and maintain a uniform style throughout the application. --------- Co-authored-by: martmull --- .../lib/fixtures/blank-workflow.ts | 12 ++++++------ .../utils/getWorkflowDiagramTriggerNode.ts | 4 ++-- .../constants/DatabaseTriggerDefaultLabel.ts | 6 +++--- .../workflow-trigger/constants/OtherTriggerTypes.ts | 2 +- .../__tests__/getTriggerDefaultDefinition.test.ts | 10 +++++----- .../utils/__tests__/getTriggerDefaultLabel.test.ts | 10 +++++----- .../utils/__tests__/getTriggerStepName.test.ts | 2 +- .../workflow-variables/utils/getTriggerStepName.ts | 2 +- 8 files changed, 24 insertions(+), 24 deletions(-) diff --git a/packages/twenty-e2e-testing/lib/fixtures/blank-workflow.ts b/packages/twenty-e2e-testing/lib/fixtures/blank-workflow.ts index cc49feb24..3f02a2a15 100644 --- a/packages/twenty-e2e-testing/lib/fixtures/blank-workflow.ts +++ b/packages/twenty-e2e-testing/lib/fixtures/blank-workflow.ts @@ -46,16 +46,16 @@ export class WorkflowVisualizerPage { }; #triggerNames: Record = { - 'record-created': 'Record is Created', - 'record-updated': 'Record is Updated', - 'record-deleted': 'Record is Deleted', + 'record-created': 'Record is created', + 'record-updated': 'Record is updated', + 'record-deleted': 'Record is deleted', manual: 'Launch manually', }; #createdTriggerNames: Record = { - 'record-created': 'Record is Created', - 'record-updated': 'Record is Updated', - 'record-deleted': 'Record is Deleted', + 'record-created': 'Record is created', + 'record-updated': 'Record is updated', + 'record-deleted': 'Record is deleted', manual: 'Launch manually', }; diff --git a/packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowDiagramTriggerNode.ts b/packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowDiagramTriggerNode.ts index 7f67529ca..d28b516cb 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowDiagramTriggerNode.ts +++ b/packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowDiagramTriggerNode.ts @@ -18,13 +18,13 @@ export const getWorkflowDiagramTriggerNode = ({ switch (trigger.type) { case 'MANUAL': { - triggerDefaultLabel = 'Manual Trigger'; + triggerDefaultLabel = 'Manual trigger'; triggerIcon = getTriggerIcon(trigger); break; } case 'CRON': { - triggerDefaultLabel = 'On a Schedule'; + triggerDefaultLabel = 'On a schedule'; triggerIcon = getTriggerIcon(trigger); break; diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel.ts index e842d79a4..e7bb38d6b 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel.ts +++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel.ts @@ -1,5 +1,5 @@ export enum DatabaseTriggerDefaultLabel { - RECORD_IS_CREATED = 'Record is Created', - RECORD_IS_UPDATED = 'Record is Updated', - RECORD_IS_DELETED = 'Record is Deleted', + RECORD_IS_CREATED = 'Record is created', + RECORD_IS_UPDATED = 'Record is updated', + RECORD_IS_DELETED = 'Record is deleted', } diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/OtherTriggerTypes.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/OtherTriggerTypes.ts index 21d3518ef..8dda4529d 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/OtherTriggerTypes.ts +++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/constants/OtherTriggerTypes.ts @@ -11,7 +11,7 @@ export const OTHER_TRIGGER_TYPES: Array<{ icon: 'IconHandMove', }, { - defaultLabel: 'On a Schedule', + defaultLabel: 'On a schedule', type: 'CRON', icon: 'IconClock', }, diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultDefinition.test.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultDefinition.test.ts index 45e75465f..41a0fa972 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultDefinition.test.ts +++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultDefinition.test.ts @@ -1,7 +1,7 @@ +import { COMMAND_MENU_DEFAULT_ICON } from '@/workflow/workflow-trigger/constants/CommandMenuDefaultIcon'; import { DatabaseTriggerDefaultLabel } from '@/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel'; import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems'; import { getTriggerDefaultDefinition } from '../getTriggerDefaultDefinition'; -import { COMMAND_MENU_DEFAULT_ICON } from '@/workflow/workflow-trigger/constants/CommandMenuDefaultIcon'; describe('getTriggerDefaultDefinition', () => { it('throws if the activeNonSystemObjectMetadataItems list is empty', () => { @@ -23,7 +23,7 @@ describe('getTriggerDefaultDefinition', () => { }), ).toStrictEqual({ type: 'DATABASE_EVENT', - name: 'Record is Created', + name: 'Record is created', settings: { eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.created`, outputSchema: {}, @@ -40,7 +40,7 @@ describe('getTriggerDefaultDefinition', () => { }), ).toStrictEqual({ type: 'DATABASE_EVENT', - name: 'Record is Updated', + name: 'Record is updated', settings: { eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.updated`, outputSchema: {}, @@ -57,7 +57,7 @@ describe('getTriggerDefaultDefinition', () => { }), ).toStrictEqual({ type: 'DATABASE_EVENT', - name: 'Record is Deleted', + name: 'Record is deleted', settings: { eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.deleted`, outputSchema: {}, @@ -74,7 +74,7 @@ describe('getTriggerDefaultDefinition', () => { }), ).toStrictEqual({ type: 'DATABASE_EVENT', - name: 'Record is Created', + name: 'Record is created', settings: { eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.created`, outputSchema: {}, diff --git a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultLabel.test.ts b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultLabel.test.ts index 3e2094afe..0a80f46f8 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultLabel.test.ts +++ b/packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultLabel.test.ts @@ -4,7 +4,7 @@ import { getTriggerDefaultLabel } from '../getTriggerLabel'; describe('getTriggerDefaultLabel', () => { describe('DATABASE_EVENT triggers', () => { - it('returns "Record is Created" for created event', () => { + it('returns "Record is created" for created event', () => { const trigger: WorkflowTrigger = { type: 'DATABASE_EVENT', name: 'Company Created', @@ -19,7 +19,7 @@ describe('getTriggerDefaultLabel', () => { expect(result).toBe(DatabaseTriggerDefaultLabel.RECORD_IS_CREATED); }); - it('returns "Record is Updated" for updated event', () => { + it('returns "Record is updated" for updated event', () => { const trigger: WorkflowTrigger = { type: 'DATABASE_EVENT', name: 'Company Updated', @@ -34,7 +34,7 @@ describe('getTriggerDefaultLabel', () => { expect(result).toBe(DatabaseTriggerDefaultLabel.RECORD_IS_UPDATED); }); - it('returns "Record is Deleted" for deleted event', () => { + it('returns "Record is deleted" for deleted event', () => { const trigger: WorkflowTrigger = { type: 'DATABASE_EVENT', name: 'Company Deleted', @@ -99,7 +99,7 @@ describe('getTriggerDefaultLabel', () => { }); describe('CRON triggers', () => { - it('returns "On a Schedule" for cron trigger', () => { + it('returns "On a schedule" for cron trigger', () => { const trigger: WorkflowTrigger = { type: 'CRON', name: 'Scheduled Trigger', @@ -116,7 +116,7 @@ describe('getTriggerDefaultLabel', () => { const result = getTriggerDefaultLabel(trigger); - expect(result).toBe('On a Schedule'); + expect(result).toBe('On a schedule'); }); }); diff --git a/packages/twenty-front/src/modules/workflow/workflow-variables/utils/__tests__/getTriggerStepName.test.ts b/packages/twenty-front/src/modules/workflow/workflow-variables/utils/__tests__/getTriggerStepName.test.ts index 377d182f4..9e855ae34 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-variables/utils/__tests__/getTriggerStepName.test.ts +++ b/packages/twenty-front/src/modules/workflow/workflow-variables/utils/__tests__/getTriggerStepName.test.ts @@ -10,7 +10,7 @@ it('returns the expected name for a DATABASE_EVENT trigger', () => { outputSchema: {}, }, }), - ).toBe('Record is Created'); + ).toBe('Record is created'); }); it('returns the expected name for a MANUAL trigger without a defined objectType', () => { diff --git a/packages/twenty-front/src/modules/workflow/workflow-variables/utils/getTriggerStepName.ts b/packages/twenty-front/src/modules/workflow/workflow-variables/utils/getTriggerStepName.ts index 3d189ea73..887b9cc82 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-variables/utils/getTriggerStepName.ts +++ b/packages/twenty-front/src/modules/workflow/workflow-variables/utils/getTriggerStepName.ts @@ -11,7 +11,7 @@ export const getTriggerStepName = (trigger: WorkflowTrigger): string => { case 'DATABASE_EVENT': return getDatabaseEventTriggerStepName(trigger); case 'CRON': - return 'On a Schedule'; + return 'On a schedule'; case 'WEBHOOK': return 'Webhook'; case 'MANUAL':