Commit Graph

153 Commits

Author SHA1 Message Date
ed86cec1e8 Fix design EditableCell 'Hover', 'Focus' and 'Edit Mode' #1663 (#1740)
* fixed styling  EditableCell

* adding same solution

* removing shadow to cover top and bottom

* fixing with outline

* fixing width

---------

Co-authored-by: kramer <david.kramer@gmail.com>
2023-09-29 10:02:54 +02:00
485bc64b4f POC: Save view as url param (#1710)
* - save view as url param

* - fix tests
2023-09-28 11:50:44 +02:00
cbadcba188 FieldDisplay & FieldInput (#1708)
* Removed view field duplicate types

* wip

* wip 2

* wip 3

* Unified state for fields

* Renaming

* Wip

* Post merge

* Post post merge

* wip

* Delete unused file

* Boolean and Probability

* Finished InlineCell

* Renamed EditableCell to TableCell

* Finished double texts

* Finished MoneyField

* Fixed bug inline cell click outside

* Fixed hotkey scope

* Final fixes

* Phone

* Fix url and number input validation

* Fix

* Fix position

* wip refactor activity editor

* Fixed activity editor

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-27 18:18:02 +02:00
46ad36061e feat: reorder kanban columns (#1699)
* kaban header options

* gql codegn

* moveColumn hook refactor

* BoardColumnContext addition

* saved board columns state

* db call hook update

* lint fix

* state change first db call second

* handleMoveTableColumn call

* codegen lint fix

* useMoveViewColumns hook

* useBoardColumns db call addition

* boardColumns state change from BoardHeader

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-27 15:59:44 +02:00
9282885233 Fix cmd menu tests (#1739)
* - fix tests

* -  fixed header

* - lint
- fixed catalog menuitemcommand

* - fix prop destructuring in test

* - combine  single/multiple create and goto commands
2023-09-27 15:19:33 +02:00
8639cb921e Chore: corrects syntax for type only imports (#1716)
* chore: removes replaces 'import type xxx from 'xxx'' with 'import { type xxx} from 'xxx'''

* chore: remove typed imports

* chore: remove typed imports

* chore: cleanup

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
2023-09-26 11:47:35 +02:00
ba86be2c5b Remove the {...props} pattern and props coupling, and create an eslint rule for that (#1733)
* Remove the {...props} pattern and props coupling, and create an eslint rule for that

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>

* Add another test to the new rule

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
2023-09-26 11:05:33 +02:00
fabbe7ddf2 Chore: First table column should not be hideable (#1711)
* First table column should not be hideable

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: chiazokam <chiazokamecheta@gmail.com>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: chiazokam <chiazokamecheta@gmail.com>

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: chiazokam <chiazokamecheta@gmail.com>
2023-09-25 12:26:41 +02:00
0ce11b6908 fix: adds cursor pointer to table column header (#1715)
* fix: adds cursro pointer to table column header

* fix: lifts up the onclick handler to header not tag making consistent with other tables
2023-09-25 12:25:03 +02:00
f777fa22e9 Create consistent ui/input and ui/display for Cell and Fields type : … (#1658)
* Create consistent ui/input and ui/display for Cell and Fields type : Probability, DoubleText, DoubleTextChip

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Move components to `ui/input`

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Update imports in ProbabilityEditableFieldEditMode

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Create consistent ui/input and ui/display for Cell and Fields type : Probability, DoubleText, DoubleTextChip

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Add more refactors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
2023-09-25 11:10:14 +02:00
1c3897848f fix: fix table columns resize glitches on slow network (#1707)
Fixes #1580
2023-09-22 19:45:29 +02:00
54042a7d8f Fix drag to select in dropdowns, context menu and action bar (#1704)
- fix drag to select disable at many locations
2023-09-21 14:22:13 -07:00
ab0cdbf960 feat: persist table columns on change (#1697)
* feat: persist table columns on change

Closes #1580

* fix: fix drag-and-select on Table Options dropdown toggle
2023-09-21 13:15:57 -07:00
772d54d29f feat: add DropdownMenuInput and use as view name input in board (#1680)
Closes #1510
2023-09-20 12:53:35 -07:00
78b666f457 Fix front end (#1678)
* Fix front

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Fix according to PR

* Fix tests

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-20 12:46:40 -07:00
8c21dc8bba Refactor fast follow on column move feature (#1665)
* Refactor fast follow on column move feature

* Fix lint
2023-09-19 16:42:11 -07:00
cb05b1fbc9 feat: reorder columns from table options (#1636)
* draggable prop addition

* draggable component addition

* state modification

* drag select state addition

* changed state name

* main merged

* lint fix

---------

Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
2023-09-19 15:31:21 -07:00
321488ad3c feat: Column title menus (#1616)
* view field index to float

* gql codegen and package.json

* list implementation

* db call

* reposition logic

* lint fix

* edge case fix

* review changes

* handleColumnMove refactor

* dropdown recoil scope

* rename props

* Update server/src/database/migrations/20230727124244_add_view_fields_table/migration.sql

---------

Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
2023-09-19 15:27:02 -07:00
00a3c8ca2b Change to using arrow functions (#1603)
* Change to using arrow functions

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Add lint rule

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-15 18:41:10 -07:00
0a7a0ac6cb Refactor/context and scopes (#1602)
* Put onImport in a context

* Refactored RecoilScopeContexts

* Refactored naming

* Fix tests

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-15 12:51:46 -07:00
55ead78fbf Fix: Bug with auto scroll (#1599)
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
2023-09-15 17:52:43 +02:00
955deaf878 feat: improve table options dropdown view name input (#1604)
- Always show view name input in dropdown
- Edit current view name by default
- Add focus style
- Reset view edit mode on dropdown close

Closes #1540
2023-09-15 17:26:00 +02:00
2461a387ce feat: persist board card fields (#1566)
Closes #1538
2023-09-14 15:06:15 -07:00
8627416d60 Refator/sorts dropdown (#1568)
* WIP

* Fixed lint

* Ok for sorts

* Fixed on dropdown toggle

* Fix lint
2023-09-13 16:38:11 -07:00
a392a81994 fix: hover behaviour on table cells (#1557)
* edit button focus fix

* cell feedback fix

* using theme prop

* isHovered prop drill

* edit button component

* refactor editable cell

* import fix

* index fix (merge issue)
2023-09-13 16:31:59 -07:00
28e12d492c feat: toggle board field visibilities (#1547)
Closes #1537, Closes #1539
2023-09-13 11:58:52 +02:00
84b474c3cc Number display formatting (#1556)
* number display formatting

* - add tests
2023-09-13 10:12:25 +02:00
9b5e24105b Refactor/display input part 2 (#1555)
* Email - Money - Number

* Date
2023-09-12 11:04:26 -07:00
564a7c97b1 refactor: improve SingleEntitySelect empty option (#1543)
Closes #1331

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-11 17:27:17 -07:00
a766c60aa5 Reafactor/UI input and displays (#1544)
* WIP

* Text field

* URL

* Finished PhoneInput

* Refactored input sub-folders

* Boolean

* Fix lint

* Fix lint

* Fix useOutsideClick

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-11 17:11:20 -07:00
9be069bedc Fixed bug for refectch activities and create activity on the currently filtered user. (#1493)
* Fixed bug for refectch activities and create activity on the currently filtered user.

* Refactor optimistif effect

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-10 23:02:51 -07:00
88c6d0da2a feat: add Opportunities Views dropdown (#1503)
* feat: add Opportunities Views dropdown

Closes #1454

* feat: persist Opportunities view filters and sorts

Closes #1456

* feat: create/edit/delete Opportunities views

Closes #1455, Closes #1457

* fix: add missing Opportunities view mock

---------

Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
2023-09-10 19:07:14 -07:00
8ea4e6a51c feat: reset table column resizing on ViewBar Cancel button click (#1520)
* feat: reset table column resizing on ViewBar Cancel button click

Closes #1500

* Fix according to PR

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-10 18:51:24 -07:00
fb737e2021 Refactor icons passed as props with the new way (#1492)
* Refactor icons passed as props with the new way

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Update more files

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Fix according to review

* Fix according to review

* Fix according to review

* Fix chromatic regressions

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-10 11:39:17 -07:00
df17da80fc refactor: add ViewBar and move view components to ui/view-bar (#1495)
Closes #1494
2023-09-08 11:57:16 +02:00
ccb57c91a3 refactor: move view recoil states to ui/view-bar folder (#1482)
* refactor: move view recoil states to ui/view-bar folder

Closes #1481

* refactor: rename some view related Recoil states and selectors
2023-09-08 11:26:15 +02:00
392c8052b2 Fixed Table view dropdown (#1497) 2023-09-07 22:39:53 +02:00
d6b89359f5 refactor: rename ui/filter-n-sort to ui/view-bar (#1475)
Closes #1473

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
2023-09-06 16:46:02 +02:00
28ca9a9e49 Refactor/new menu item (#1448)
* wip

* finished

* Added disabled

* Fixed disabled

* Finished cleaning

* Minor fixes from merge

* Added docs

* Added PascalCase

* Fix from review

* Fixes from merge

* Fix lint

* Fixed storybook tests
2023-09-06 16:41:26 +02:00
08b56ec7e2 fix: can't set ARR of company to empty (#1474) 2023-09-06 11:22:42 +02:00
f332c3bee2 Fix View update button not being displayed in View Bar (#1469) 2023-09-06 10:37:29 +02:00
c05d24d249 fix: table view dropdown should have a minimum width (#1467) 2023-09-06 10:37:02 +02:00
85c8139c05 fix: double text chip show null value (#1460) 2023-09-05 17:55:29 +02:00
aad4f99f52 fix: view dropdown incorrect button position and floating icon button doesn't match design (#1458)
* fix: view dropdown incorrect button position

* fix: className instead of style drill down

* fix: view drop down width
2023-09-05 17:45:05 +02:00
878302dd31 [ESLint rule]: recoil value and setter should be named after their at… (#1402)
* Override unwanted changes

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>

* Fix the tests

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>
Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
2023-09-05 10:34:11 +02:00
7bced2b49b Unselect table rows using esc key or click outside (#1420)
* unselect table rows by esc or clickoutside of tablebody

* exclude action-bar

* exclude context-menu

* added enums, handled touch listener
2023-09-05 09:56:07 +02:00
d04c661ffd Fix buttons and z-index (#1438)
* Fix buttons

* Remove useless code
2023-09-04 17:52:03 +02:00
2eac5df05b fix: big view name is not handled (#1439)
* fix: big view name is not handled

* fix: smaller max size
2023-09-04 17:47:32 +02:00
a1e6e46388 fix: allow access to the Update View button when a table column can be persisted (#1433)
Closes #1432
2023-09-04 17:08:04 +02:00
1a71f61d24 Fix column not being saved properly (#1429)
* Fix email column not being saved

* Fix URL fields not being clearable

* Fix phone number clearing
2023-09-04 15:42:10 +02:00