mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
4,426 Commits 2 Branches 0 Tags
9e7b90a551f071437db75306e66d12fa29b68828
Commit Graph
642 Commits
Author SHA1 Message Date
Harshit SinghandDevessier 9e7b90a551 fix: Added keyboard functionality for esc and Ctrl + a (#8282) 
## Description

- This PR fixes 
#8247 
#8206 
- Adds keyboard functionality for esc (deselect all records) and Ctrl +
a (select records)

## Changes

https://github.com/user-attachments/assets/7b2718d6-dbe5-4cd8-8ead-b6baed1fc357

Merged during stream 🎉 

---------

Co-authored-by: Devessier <baptiste@devessier.fr>
 2024-11-15 17:15:39 +01:00
Hitarth ShethThomas des FrancsLucas Bordeau
 		4db0d0f8c1 Improve phone input UI (#8266) 
[FIX] #8251 

Changes made as suggested by @Bonapara. 


![image](https://github.com/user-attachments/assets/4ba6db50-f122-4f66-9361-8a0a0da0b6a0)

![image](https://github.com/user-attachments/assets/f0f1e1f4-d354-4461-9929-cd171d95835e)

![image](https://github.com/user-attachments/assets/b6b9fdef-d6fa-4e4b-aa8b-c8c3ef8b8c57)

![image](https://github.com/user-attachments/assets/7e68bf25-aff9-428f-a084-0b0631eeecef)

For the `The country code should be Tertiary instead of Primary ` task,
the library "react-phone-number-input" doesn't provide any out of the
box functionality to style the country code.

If the feature **needs** to be implemented here are the possible
solution/workarounds:

1. Finding a more customizable library that allows to change the style
of the country code

OR 

2. Implement custom country selection (😰...)

OR

3. The lib allows a custom input element and a provides a function
(onCountryChange) that triggers whenever the country changes (a country
can be changed in two ways- 1. When the user deliberately chooses it
from dropdown OR 2. Changes the code in the input)

We'll have to get the length of the country code and then style the
first X digits in the custom input field...


![image](https://github.com/user-attachments/assets/21b09c4d-fb5b-4efe-8204-aea4c9040587)

![image](https://github.com/user-attachments/assets/007c2791-a640-4bc9-b852-0f9b597679f1)

Let me know if someone has a better approach.

---------

Co-authored-by: Thomas des Francs <tdesfrancs@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-11-15 16:03:48 +01:00
Félix Malfait 34a3a66451 Improve flaky storybook test (#8515) 
I don't think that will solve the flaky test but at least it will
cleanup the error message to avoid confusion
 2024-11-15 14:29:39 +01:00
martmull 4f99b8eea1 8495 workflow display relevant columns in workflow related tables (#8502) 
## After
### Workflows

![image](https://github.com/user-attachments/assets/535e0ff5-1276-41b9-aa52-d66150cd85ae)
### WorkflowRuns

![image](https://github.com/user-attachments/assets/8a7e076b-53ec-4b72-97d8-41bd77ed59ac)
### WorkflowVersions

![image](https://github.com/user-attachments/assets/7d2566b2-e6ea-4a3a-8e88-0f6850203219)

## Change Created By into Executed By in workflowRuns

![image](https://github.com/user-attachments/assets/b90b7a07-a4bc-4bd2-b7f5-ab7d2ae6ee45)
 2024-11-15 10:13:36 +00:00
Charles Bochet 5384b4aba5 Fix record board export not taking filters into account (#8505) 
Fix Export CSV action not taking into account the filters applied on the
Kanban index view
 2024-11-14 23:28:53 +01:00
Harsh SinghandFélix Malfait c966533f26 fix: search error in filter & sort dropdowns (#8493) 
Fixes: #8483

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-11-14 17:51:54 +01:00
Guillimandguillim 15b8b9b158 Feature : Adding percentage option to Input Number (#8481) 
fixing #7375

---------

Co-authored-by: guillim <guillaume@twenty.com>
 2024-11-14 14:23:25 +01:00
Harsh SinghandFélix Malfait 29d92abaff fix: bookmarkIcon flash on hover exit (#8448) 
Fixes: #8447

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-11-11 09:30:03 +01:00
nitinandFélix Malfait c19e54f24b Hide tabs (#7841) 
@FelixMalfait WDYT?
We can refactor shouldDisplay Files/Tasks/Notes Tab etc into a hook.

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-11-11 09:26:27 +01:00
Harshit SinghandLucas Bordeau 0381996fb9 fix: dropdown menu doesn't close and remains open (#8302) 
## Description

- Fixes #8285 
- Added fix for both Currency and PhoneCountry dropdown

## Changes



https://github.com/user-attachments/assets/cbf85100-7791-40da-a676-2c87c6a32976

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-11-08 16:13:15 +00:00
Raphaël Bosi 5a53ef1ade Make filters work on export csv action (#8389) 
- Create a new component state `contextStoreFiltersComponentState` and
refactor `contextStoreTargetedRecordsRuleComponentState`
- Refactor `computeContextStoreFilters` to use filters when no records
are selected
 2024-11-08 15:38:45 +01:00
Harshit SinghandThomas des Francs d44f7a46b6 fix: Misalignment and Excessive Padding in Relation Card (#8292) 
## Description

- This PR solves the issue #8249 
- Maintained the overall padding, aligned content to left matching and
decreased Spacing between the card title and content should be smaller

## Changes

<img width="346" alt="Screenshot 2024-11-03 at 2 37 13 AM"
src="https://github.com/user-attachments/assets/91ba35bb-ff25-4001-af15-1fa10e5e1772">

---------

Co-authored-by: Thomas des Francs <tdesfrancs@gmail.com>
 2024-11-08 14:10:15 +00:00
Harsh Singhandehconitin 61cdc0e6da fix: kanban column margin should extend to bottom (#8394) 
Fixes: #7868 

[Screencast from 2024-11-08
13-33-47.webm](https://github.com/user-attachments/assets/1de620d8-8f05-43f8-bde9-a2c9cbea4b9f)

---------

Co-authored-by: ehconitin <nitinkoche03@gmail.com>
 2024-11-08 14:55:45 +01:00
gitstart-app[bot]gitstart-twentygitstart-twentyLucas Bordeau
 		6264d509bd Migrate to twenty-ui - navigation/menu-item (#8213) 
This PR was created by [GitStart](https://gitstart.com/) to address the
requirements from this ticket:
[TWNTY-7536](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7536).

 --- 

### Description

Migrate all menu items components to twenty ui and update imports.

```typescript
MenuItem
MenuItemAvata
MenuItemCommand
MenuItemCommandHotKeys
MenuItemDraggable
MenuItemMultiSelect
MenuItemMultiSelectAvatar
MenuItemMultiSelectTag
MenuItemNavigate
MenuItemSelect
MenuItemSelectAvatar
MenuItemSelectColor
MenuItemSelectTag
MenuItemSuggestion
MenuItemToggle
```

\
Also migrate all other dependent components and utilities like
`Checkbox` & `Toggle`\
\
Fixes twentyhq/private-issues#82

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-11-07 16:51:39 +00:00
MarieandLucas Bordeau ac233b771c Simplify multi-object picker logic with search (#8010) 
Simplifying the logic around multi-object pickers and search by getting
rid of the behaviour that keeped selected elements even when they did
not match the search filter (eg keeping selected record "Brian Chesky"
in dropdown even when search input is "Qonto"). This allows us to
simplify the fetch queries around the search to only do one query.

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-11-07 17:09:19 +01:00
Harshit SinghandLucas Bordeau 4f2b055ee0 fix: Minor bugs in UI (#7891) 
## Description

- This PR fixed #7890

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-11-07 14:04:33 +00:00
Marie 60349d0989 Fix broken relation picker in Kanban (#8377) 
Fixes https://github.com/twentyhq/twenty/issues/8233

Typing a search input was triggering a re-render of the whole
RecordBoardCard, resetting the search input to its initial value, an
empty string, making it impossible to actually type anything.
useRelationPicker had (legacy?) useless dependencies to recoil states
that caused the rerenders.
 2024-11-07 13:55:21 +00:00
prathameshpatil5181 3be30651b7 fix : 7223 Clicking Outside Fields domain link email phone Close Them (#7804) 
fixes #7223

https://github.com/user-attachments/assets/1150e96f-4fb5-40ba-ac17-89d8b2ab16e7
 2024-11-07 12:40:28 +00:00
Raphaël Bosi a6007d4376 Fix action menu dropdown (#8368) 
Fix action menu dropdown not closing when clicking outside the table or
board and introduce helper functions to get the action menu component
ids.
 2024-11-06 16:11:31 +01:00
Félix Malfait b627c55b9a Add blue focus on text inputs (#8343) 
We removed the blue focus on phone/domain/array/email floating inputs
but we want to keep it in the app settings.

<img width="644" alt="Screenshot 2024-11-05 at 15 55 04"
src="https://github.com/user-attachments/assets/afcbe6b2-2d6b-4e0d-8397-4268d529127c">
<img width="606" alt="Screenshot 2024-11-05 at 15 55 23"
src="https://github.com/user-attachments/assets/004becf8-41e7-45d6-9ad9-9e487b8db8f3">
<img width="351" alt="Screenshot 2024-11-05 at 15 55 33"
src="https://github.com/user-attachments/assets/6a4c06e6-04d3-46bf-940b-9fd61ee91995">
<img width="330" alt="Screenshot 2024-11-05 at 15 55 41"
src="https://github.com/user-attachments/assets/e6fc8bbd-eca3-47bc-93f1-d6ff8d3d8a13">
<img width="588" alt="Screenshot 2024-11-05 at 15 56 07"
src="https://github.com/user-attachments/assets/0d0f5e80-3501-4346-94a1-6ea4b77ee7ba">
<img width="211" alt="Screenshot 2024-11-05 at 15 56 31"
src="https://github.com/user-attachments/assets/9cd85f4d-8052-4c6b-a694-84c691c6217d">
 2024-11-06 14:23:34 +01:00
Harshit SinghbosiraphaelLucas Bordeau
 		18d04de676 fix: RightDrawer doesn't save context values when clickedOutside (#7729) 
## Description

- This PR fixes #7728 

## Changes


https://github.com/user-attachments/assets/1e66cab3-9009-4c01-9ac6-22651b0ff5e7

---------

Co-authored-by: bosiraphael <raphael.bosi@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-11-06 11:46:30 +01:00
Jérémy MandCharles Bochet ac7d740135 fix: when field metadata SELECT type is edited update view groups (#8344) 
Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-11-06 11:41:44 +01:00
Lucas Bordeau e36363fe15 Fix scroll wrapper (#8349) 
Fixed scroll wrapper with conditionnal rendering
 2024-11-06 10:05:17 +01:00
Charles Bochet 88ba057b2c Fix 0.32 bis (#8346) 
Various UI fixes according to discussions with Design team
 2024-11-05 18:14:44 +01:00
Nabhag MotivarasandLucas Bordeau 3793f6c451 fix: content getting hide on drag and drop in stage view cards (#7621) 
## ISSUE

-  Closes #7388 

## Demo



https://github.com/user-attachments/assets/193813aa-def9-406b-9fe7-397627bb1242

- [ ] Table Row Drag WIP

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
 2024-11-05 16:03:24 +01:00
Charles Bochet 84b0b78b6f Refactor kanban new card creation (#8339) 
On the kanban page, the record creation was changed a few weeks ago to
enable creation on top / bottom of the columns.

However, this introduced a glitch (missing background opacity). While
fixing it, I have refactored the component structure to:
- separate "New" button from the Empty record card
 2024-11-05 15:16:38 +01:00
Raphaël Bosi d1531aa1b6 8191 command k workflow trigger for selected record (#8315) 
Closes #8191 


https://github.com/user-attachments/assets/694da229-cc91-4df2-97a0-49cd5dabcf12
 2024-11-05 13:37:29 +01:00
ZiaCodes 66c0aa5e52 feat: improved table scrolling (#7731) 
This PR fixes #7515

Demo:


https://github.com/user-attachments/assets/8181cda0-3b77-43bf-b605-ba43f2290b84
 2024-11-04 16:55:13 +00:00
Charles Bochet 52e5f7daeb Unselect record table records on table body click (#8306) 
We have previously fixed the unselection of table records on click
outside. However, the ref was mispositioned as it selected the full
height table. In the case of low record numbers, we also want the
unselection to happen on table body click
 2024-11-04 17:44:50 +01:00
Marie 76e8bf33ac Fix relation picker for activity target (#8303) 
[This PR](https://github.com/twentyhq/twenty/pull/8210) introduced a
regression, causing noteId or taskId (respectively for noteTarget or
taskTarget creation) to be overwritten with an undefined value in the
input for noteTarget or taskTarget creation.
This is because in ActivityTargetInlineCellEditMode, in addition to the
noteId and taskId we are declaring, we are looking into the object
(noteTarget or taskTarget)'s fields and prefilling the record-to-create
with a value, potentially undefined, for all of the object fields.
So when looping over noteTarget's fields, we would find the `note`
relation field, and eventually add `note: undefined` to the
record-to-create input, in addition to the non-empty and valid existing
`noteId`.
Then in sanitizeRecordInput, from the note added right above, we add an
empty noteId to the input from node, overwriting the "good" noteId.

There are several ways to fix this, I chose to update prefillRecord not
to add an empty "note" object that makes no sense in addition to the
"noteId" we already have at this stage.
It is also possible to update `sanitizeRecordInput` not to overwrite a
value from a relation (noteId from note relation) if there is already a
value in the input.
 2024-11-04 14:39:48 +01:00
Jérémy M 258fd07839 feat: use new component state api for record table (#8143) 
This PR drop the use of the old component state api in favour of the new
component state api V2.
 2024-11-04 12:07:07 +01:00
Hitarth ShethandFélix Malfait b66bdd9de5 [FIX] remove blue outline for Phones, Emails, and Domains fields (#8268) 
FIX: #8252

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-11-04 08:32:27 +01:00
Félix Malfait 558cc6810e Fix assignee not displayed on tasks (#8280) 
Fix an issue where the assignee of a task wasn't displayed on the task
record's show page
 2024-11-01 18:26:56 +01:00
Lucas Bordeau c93d2bcd5e Fixed many dropdown bugs (#8256) 
Many dropdown bugs have been fixed, more refactoring is needed.

Dropdown fixed : 
- Filter select
- Sort select
- Visible field select
- Hidden field select
- Multi item picker (phones, links, emails, etc.)
- Phone country select
 2024-11-01 09:23:01 +01:00
Charles Bochet a287edd91b Kanban full name (#8261) 2024-11-01 09:19:55 +01:00
Harshit Singh c9fcce6590 fix: Emails input field stays in errored state (#8243) 
## Description

- This PR fixes the issue #8235 
- Error state resets when error state is removed

## Changes



https://github.com/user-attachments/assets/0aeb99fe-56c8-437a-ad2c-97e245a44158
 2024-10-31 13:26:59 +01:00
Charles Bochet 034e558758 Deprecate useListenClickOutsideByClassNameListener (#8242) 2024-10-31 12:46:21 +01:00
Raphaël Bosi b1e9922660 Fix context store filters (#8236) 
Fix context store filters
 2024-10-31 11:51:51 +01:00
Baptiste Devessier d0dc8bae4f Fix save record table cell when clicking outside table (#8230) 2024-10-31 11:45:40 +01:00
Marie e5d492d09f Fix empty option selected in single entity select (#8208) 
SingleEntitySelect was wrongfully showing the empty option (eg "No
company") as selected if the selected option was not showing in the
list, because of a search filter for instance (eg selected option is
"Linkedin" but search filter is "a").

Fixing this and removing misleading prop selectedEntity from components
where it is never passed.
 2024-10-31 09:41:44 +01:00
martmull 7f90ac2df8 Handle case where fieldValue is null (#8210) 
Allow null values when updating relation to fix detach action
 2024-10-30 16:53:02 +01:00
Charles Bochet b7d5c05a74 Fix front tests (#8207) 2024-10-30 15:50:56 +01:00
Félix MalfaitandWeiko 50c912d57f Delete unused objects (#7823) 
Fixes #7113

---------

Co-authored-by: Weiko <corentin@twenty.com>
 2024-10-30 13:35:43 +01:00
Lucas Bordeau 1782865ff8 Added feature flag for advanced filter (#8194) 
Added feature flag for advanced filter
 2024-10-30 12:06:46 +01:00
Raphaël Bosi fe2c8bb43b 7339 implement contextual actions inside the commandmenu (#8000) 
Closes #7339


https://github.com/user-attachments/assets/b623caa4-c1b3-448e-8880-4a8301802ba8
 2024-10-29 15:10:45 +01:00
Sanskar JainandFélix Malfait 95b475c855 Fixes "No Result" flash and add a separator (#8140) 
Fix for #8137

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
 2024-10-29 11:36:25 +01:00
gitstart-app[bot]gitstart-twentyCharles Bochet
 		fc8c9d9167 Migrate to twenty-ui - input components (#7914) 
### Description

Migrate Input components: 

- CardPicker
- Radio
- RadioGroup
- Checkbox
- Toggle
- IconListViewGrip

### Demo

Radio Component on Storybook


![](https://assets-service.gitstart.com/4814/2d0c7436-9fab-4f3d-a5c4-be874e885789.png)

Checkbox component on Storybook


![](https://assets-service.gitstart.com/4814/07bcc040-cc92-4c7e-9be8-ca1a5f454993.png)

###### Fixes twentyhq/private-issues#92

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
 2024-10-28 15:36:58 +01:00
gitstart-app[bot]andgitstart-twenty fa0933b292 Migrate to twenty-ui - layout/section (#8068) 
This PR was created by [GitStart](https://gitstart.com/) to address the
requirements from this ticket:
[TWNTY-7533](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7533).

 --- 

Description \
\
Move Section component from twenty-front to twenty-ui and update
imports\
\
\
Fixes twentyhq/private-issues#85

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
 2024-10-28 13:08:55 +01:00
Igor Kowalski 3ae987be92 folderStructure.json refactor (#8088) 
#7911 

If you encounter any issues or have any questions regarding the library,
feel free to write
[here](https://github.com/Igorkowalski94/eslint-plugin-project-structure/discussions/new?category=help),
I’d be happy to help.
 2024-10-28 12:06:58 +01:00
Marie d51a797d91 Replace shouldSyncNameAndLabel with isLabelSyncedWithName (#8067) 
For consistency. 
This was not deployed yet so allowing myself just to rename everything,
meaning developers will need to reset their db.
 2024-10-25 18:28:58 +02:00