In this huge (sorry!) PR: - introducing objectMetadataItem in contextStore instead of objectMetadataId which is more convenient - splitting some big hooks into smaller parts to avoid re-renders - removing Effects to avoid re-renders (especially onViewChange) - making the view prefetch separate from favorites to avoid re-renders - making the view prefetch load a state and add selectors on top of it to avoir re-renders As a result, the performance is WAY better (I suspect the favorite implementation to trigger a lot of re-renders unfortunately). However, we are still facing a random app freeze on view creation. I could not investigate the root cause. As this seems to be already there in the precedent release, we can move forward but this seems a urgent follow up to me ==> EDIT: I've found the root cause after a few ours of deep dive... an infinite loop in RecordTableNoRecordGroupBodyEffect... prastoin edit: close https://github.com/twentyhq/twenty/issues/10253 --------- Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> Co-authored-by: prastoin <paul@twenty.com>
96 lines
3.4 KiB
TypeScript
96 lines
3.4 KiB
TypeScript
import { ReactNode } from 'react';
|
|
import { useParams } from 'react-router-dom';
|
|
|
|
import { ObjectFilterDropdownButton } from '@/object-record/object-filter-dropdown/components/ObjectFilterDropdownButton';
|
|
import { ObjectSortDropdownButton } from '@/object-record/object-sort-dropdown/components/ObjectSortDropdownButton';
|
|
|
|
import { useIsPrefetchLoading } from '@/prefetch/hooks/useIsPrefetchLoading';
|
|
import { TopBar } from '@/ui/layout/top-bar/components/TopBar';
|
|
import { QueryParamsFiltersEffect } from '@/views/components/QueryParamsFiltersEffect';
|
|
import { ViewBarFilterEffect } from '@/views/components/ViewBarFilterEffect';
|
|
import { ViewBarPageTitle } from '@/views/components/ViewBarPageTitle';
|
|
import { ViewBarSkeletonLoader } from '@/views/components/ViewBarSkeletonLoader';
|
|
import { ViewBarSortEffect } from '@/views/components/ViewBarSortEffect';
|
|
import { ViewPickerDropdown } from '@/views/view-picker/components/ViewPickerDropdown';
|
|
|
|
import { ViewsHotkeyScope } from '../types/ViewsHotkeyScope';
|
|
|
|
import { FiltersHotkeyScope } from '@/object-record/object-filter-dropdown/types/FiltersHotkeyScope';
|
|
import { VIEW_SORT_DROPDOWN_ID } from '@/object-record/object-sort-dropdown/constants/ViewSortDropdownId';
|
|
import { ObjectSortDropdownComponentInstanceContext } from '@/object-record/object-sort-dropdown/states/context/ObjectSortDropdownComponentInstanceContext';
|
|
import { ViewBarRecordFilterEffect } from '@/views/components/ViewBarRecordFilterEffect';
|
|
import { UpdateViewButtonGroup } from './UpdateViewButtonGroup';
|
|
import { ViewBarDetails } from './ViewBarDetails';
|
|
|
|
export type ViewBarProps = {
|
|
viewBarId: string;
|
|
className?: string;
|
|
optionsDropdownButton: ReactNode;
|
|
};
|
|
|
|
export const ViewBar = ({
|
|
viewBarId,
|
|
className,
|
|
optionsDropdownButton,
|
|
}: ViewBarProps) => {
|
|
const { objectNamePlural } = useParams();
|
|
|
|
const filterDropdownId = 'view-filter';
|
|
|
|
const loading = useIsPrefetchLoading();
|
|
|
|
if (!objectNamePlural) {
|
|
return;
|
|
}
|
|
|
|
return (
|
|
<ObjectSortDropdownComponentInstanceContext.Provider
|
|
value={{ instanceId: VIEW_SORT_DROPDOWN_ID }}
|
|
>
|
|
<ViewBarRecordFilterEffect />
|
|
<ViewBarFilterEffect filterDropdownId={filterDropdownId} />
|
|
<ViewBarSortEffect />
|
|
<QueryParamsFiltersEffect />
|
|
|
|
<ViewBarPageTitle viewBarId={viewBarId} />
|
|
<TopBar
|
|
className={className}
|
|
leftComponent={
|
|
loading ? <ViewBarSkeletonLoader /> : <ViewPickerDropdown />
|
|
}
|
|
rightComponent={
|
|
<>
|
|
<ObjectFilterDropdownButton
|
|
filterDropdownId={filterDropdownId}
|
|
hotkeyScope={{
|
|
scope: FiltersHotkeyScope.ObjectFilterDropdownButton,
|
|
}}
|
|
/>
|
|
<ObjectSortDropdownButton
|
|
hotkeyScope={{
|
|
scope: FiltersHotkeyScope.ObjectSortDropdownButton,
|
|
}}
|
|
/>
|
|
{optionsDropdownButton}
|
|
</>
|
|
}
|
|
bottomComponent={
|
|
<ViewBarDetails
|
|
filterDropdownId={filterDropdownId}
|
|
hasFilterButton
|
|
viewBarId={viewBarId}
|
|
objectNamePlural={objectNamePlural}
|
|
rightComponent={
|
|
<UpdateViewButtonGroup
|
|
hotkeyScope={{
|
|
scope: ViewsHotkeyScope.UpdateViewButtonDropdown,
|
|
}}
|
|
/>
|
|
}
|
|
/>
|
|
}
|
|
/>
|
|
</ObjectSortDropdownComponentInstanceContext.Provider>
|
|
);
|
|
};
|