# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
114 lines
3.4 KiB
TypeScript
114 lines
3.4 KiB
TypeScript
import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
|
|
import { getRecordFromCache } from '@/object-record/cache/utils/getRecordFromCache';
|
|
import { updateRecordFromCache } from '@/object-record/cache/utils/updateRecordFromCache';
|
|
import { computeDepthOneRecordGqlFieldsFromRecord } from '@/object-record/graphql/utils/computeDepthOneRecordGqlFieldsFromRecord';
|
|
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
|
|
import { InMemoryCache, NormalizedCacheObject } from '@apollo/client';
|
|
import { expect } from '@storybook/jest';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
type ObjectMetadataItemAndRecordId = {
|
|
recordId: string;
|
|
objectMetadataItem: ObjectMetadataItem;
|
|
};
|
|
type RecordsWithObjectMetadataItem = {
|
|
records: ObjectRecord[];
|
|
objectMetadataItem: ObjectMetadataItem;
|
|
}[];
|
|
|
|
type GetMockCachedRecord = {
|
|
recordId: string;
|
|
objectMetadataItem: ObjectMetadataItem;
|
|
matchObject?: Record<string, unknown>;
|
|
snapshotPropertyMatchers?: {
|
|
deletedAt?: any;
|
|
updatedAt?: any;
|
|
createdAt?: any;
|
|
};
|
|
};
|
|
type InMemoryTestingCacheInstanceArgs = {
|
|
objectMetadataItems: ObjectMetadataItem[];
|
|
initialRecordsInCache?: RecordsWithObjectMetadataItem;
|
|
};
|
|
|
|
export class InMemoryTestingCacheInstance {
|
|
private _cache: InMemoryCache;
|
|
private objectMetadataItems: ObjectMetadataItem[];
|
|
private initialStateExtract: NormalizedCacheObject;
|
|
|
|
constructor({
|
|
objectMetadataItems,
|
|
initialRecordsInCache = [],
|
|
}: InMemoryTestingCacheInstanceArgs) {
|
|
this.objectMetadataItems = objectMetadataItems;
|
|
this._cache = new InMemoryCache();
|
|
|
|
this.populateRecordsInCache(initialRecordsInCache);
|
|
this.initialStateExtract = this._cache.extract();
|
|
}
|
|
|
|
public populateRecordsInCache = (
|
|
recordsWithObjectMetadataItem: RecordsWithObjectMetadataItem,
|
|
) => {
|
|
recordsWithObjectMetadataItem.forEach(({ objectMetadataItem, records }) =>
|
|
records.forEach((record) =>
|
|
updateRecordFromCache({
|
|
cache: this._cache,
|
|
objectMetadataItem,
|
|
objectMetadataItems: this.objectMetadataItems,
|
|
record,
|
|
recordGqlFields: computeDepthOneRecordGqlFieldsFromRecord({
|
|
objectMetadataItem,
|
|
record,
|
|
}),
|
|
}),
|
|
),
|
|
);
|
|
};
|
|
|
|
public assertCachedRecordIsNull = ({
|
|
objectMetadataItem,
|
|
recordId,
|
|
}: ObjectMetadataItemAndRecordId) => {
|
|
const cachedRecord = getRecordFromCache({
|
|
cache: this._cache,
|
|
objectMetadataItem,
|
|
objectMetadataItems: this.objectMetadataItems,
|
|
recordId,
|
|
});
|
|
expect(cachedRecord).toBeNull();
|
|
};
|
|
|
|
public assertCachedRecordMatchSnapshot = ({
|
|
objectMetadataItem,
|
|
recordId,
|
|
matchObject,
|
|
snapshotPropertyMatchers,
|
|
}: GetMockCachedRecord) => {
|
|
const cachedRecord = getRecordFromCache({
|
|
cache: this._cache,
|
|
objectMetadataItem,
|
|
objectMetadataItems: this.objectMetadataItems,
|
|
recordId,
|
|
});
|
|
expect(cachedRecord).not.toBeNull();
|
|
|
|
if (cachedRecord === null) {
|
|
throw new Error('Should never occurs, cachedRecord is null');
|
|
}
|
|
|
|
if (isDefined(matchObject)) {
|
|
expect(cachedRecord).toMatchObject(matchObject);
|
|
}
|
|
expect(cachedRecord).toMatchSnapshot(snapshotPropertyMatchers ?? {});
|
|
};
|
|
|
|
public restoreCacheToInitialState = async () => {
|
|
return this._cache.restore(this.initialStateExtract);
|
|
};
|
|
|
|
public get cache() {
|
|
return this._cache;
|
|
}
|
|
}
|