9c2b88870f
This PR attemps at improving sentry grouping and filtering by - Using the exceptionCode as the fingerprint when the error is a customException. For this to work in this PR we are now throwing customExceptions instead of internalServerError deprived of their code. They will still be converted to Internal server errors when sent back as response - Filtering 4xx issues where it was missing (for emailVerification because errors were not handled, for invalid captcha and billing errors because they are httpErrors and not graphqlErrors) --------- Co-authored-by: Félix Malfait <felix@twenty.com>
53 lines
1.3 KiB
TypeScript
53 lines
1.3 KiB
TypeScript
import camelCase from 'lodash.camelcase';
|
|
import { slugify } from 'transliteration';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
import {
|
|
InvalidMetadataException,
|
|
InvalidMetadataExceptionCode,
|
|
} from 'src/engine/metadata-modules/utils/exceptions/invalid-metadata.exception';
|
|
|
|
export const validateNameAndLabelAreSyncOrThrow = (
|
|
label: string,
|
|
name: string,
|
|
) => {
|
|
const computedName = computeMetadataNameFromLabel(label);
|
|
|
|
if (name !== computedName) {
|
|
throw new InvalidMetadataException(
|
|
`Name is not synced with label. Expected name: "${computedName}", got ${name}`,
|
|
InvalidMetadataExceptionCode.NAME_NOT_SYNCED_WITH_LABEL,
|
|
);
|
|
}
|
|
};
|
|
|
|
export const computeMetadataNameFromLabel = (label: string): string => {
|
|
if (!isDefined(label)) {
|
|
throw new InvalidMetadataException(
|
|
'Label is required',
|
|
InvalidMetadataExceptionCode.LABEL_REQUIRED,
|
|
);
|
|
}
|
|
|
|
const prefixedLabel = /^\d/.test(label) ? `n${label}` : label;
|
|
|
|
if (prefixedLabel === '') {
|
|
return '';
|
|
}
|
|
|
|
const formattedString = slugify(prefixedLabel, {
|
|
trim: true,
|
|
separator: '_',
|
|
allowedChars: 'a-zA-Z0-9',
|
|
});
|
|
|
|
if (formattedString === '') {
|
|
throw new InvalidMetadataException(
|
|
`Invalid label: "${label}"`,
|
|
InvalidMetadataExceptionCode.INVALID_LABEL,
|
|
);
|
|
}
|
|
|
|
return camelCase(formattedString);
|
|
};
|