admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Deleting an opportunity from the relation detail section deletes a person (#12137)

Browse Source 
Fixes https://github.com/twentyhq/twenty/issues/12131

All instances of RecordDetailRelationRecordsListItem are sharing the
same DELETE_RELATION_MODAL_ID, this PR makes the modal ID unique for
each item.
This commit is contained in:
Weiko
2025-05-20 11:38:16 +02:00
committed by GitHub
parent d6215cad46
commit 203d4fc84f
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx
View File

@ -87,7 +87,8 @@ const StyledClickableZone = styled.div`
const MotionIconChevronDown = motion.create(IconChevronDown); const MotionIconChevronDown = motion.create(IconChevronDown);
const DELETE_RELATION_MODAL_ID = 'delete-relation-modal'; const getDeleteRelationModalId = (recordId: string) =>
`delete-relation-modal-${recordId}`;
type RecordDetailRelationRecordsListItemProps = { type RecordDetailRelationRecordsListItemProps = {
isExpanded: boolean; isExpanded: boolean;
@ -175,7 +176,7 @@ export const RecordDetailRelationRecordsListItem = ({
const handleDelete = async () => { const handleDelete = async () => {
closeDropdown(); closeDropdown();
openModal(DELETE_RELATION_MODAL_ID); openModal(getDeleteRelationModalId(relationRecord.id));
}; };
const handleConfirmDelete = async () => { const handleConfirmDelete = async () => {
@ -305,7 +306,7 @@ export const RecordDetailRelationRecordsListItem = ({
</AnimatedEaseInOut> </AnimatedEaseInOut>
{createPortal( {createPortal(
<ConfirmationModal <ConfirmationModal
modalId={DELETE_RELATION_MODAL_ID} modalId={getDeleteRelationModalId(relationRecord.id)}
title={`Delete Related ${relationObjectTypeName}`} title={`Delete Related ${relationObjectTypeName}`}
subtitle={ subtitle={
<> <>