admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix field empty value check for Person standard object (#10533)

Browse Source 
The previous code was not correct if labelIdentifier is a FULL_NAME.
We already have an util for this

Fixes: https://github.com/twentyhq/twenty/issues/10532
This commit is contained in:
Charles Bochet
2025-02-27 10:08:47 +01:00
committed by GitHub
parent 4189ce2a9e
commit 2f048201ad
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCardHeader.tsx
View File

@ -17,6 +17,7 @@ import {
} from '@/object-record/record-field/contexts/FieldContext'; } from '@/object-record/record-field/contexts/FieldContext';
import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata'; import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
import { getFieldButtonIcon } from '@/object-record/record-field/utils/getFieldButtonIcon'; import { getFieldButtonIcon } from '@/object-record/record-field/utils/getFieldButtonIcon';
import { isFieldValueEmpty } from '@/object-record/record-field/utils/isFieldValueEmpty';
import { useRecordIndexContextOrThrow } from '@/object-record/record-index/contexts/RecordIndexContext'; import { useRecordIndexContextOrThrow } from '@/object-record/record-index/contexts/RecordIndexContext';
import { recordIndexOpenRecordInSelector } from '@/object-record/record-index/states/selectors/recordIndexOpenRecordInSelector'; import { recordIndexOpenRecordInSelector } from '@/object-record/record-index/states/selectors/recordIndexOpenRecordInSelector';
import { RecordInlineCell } from '@/object-record/record-inline-cell/components/RecordInlineCell'; import { RecordInlineCell } from '@/object-record/record-inline-cell/components/RecordInlineCell';
@ -99,9 +100,10 @@ export const RecordBoardCardHeader = ({
isRecordBoardCompactModeActiveComponentState, isRecordBoardCompactModeActiveComponentState,
); );
const isIdentifierEmpty = const isIdentifierEmpty = isFieldValueEmpty({
(record?.[identifierFieldDefinition.metadata.fieldName] || '').trim() === fieldDefinition: identifierFieldDefinition,
''; fieldValue: record?.[identifierFieldDefinition.metadata.fieldName],
});
const { checkIfLastUnselectAndCloseDropdown } = const { checkIfLastUnselectAndCloseDropdown } =
useRecordBoardSelection(recordBoardId); useRecordBoardSelection(recordBoardId);