admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed non advanced filter creation from table header dropdown (#12369)

Browse Source 
This PR fixes a edge case where the user tries to create a non-advanced
filter that already exists in advanced filters, from the table header
drodpown.

This was because the hook that handles the creation was checking for
duplicate filters but without discerning between advanced and
non-advanced, and we want to be able to create non-advanced filters no
matter what we have in advanced filters.

Fixes https://github.com/twentyhq/twenty/issues/12316
This commit is contained in:
Lucas Bordeau
2025-05-30 12:16:55 +02:00
committed by GitHub
parent 4dea441168
commit 35a4b07bc2
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-front/src/modules/object-record/record-table/record-table-header/hooks/useOpenRecordFilterChipFromTableHeader.ts
View File

@ -37,13 +37,15 @@ export const useOpenRecordFilterChipFromTableHeader = () => {
);
}
const existingRecordFilter = currentRecordFilters.find(
(recordFilter) => recordFilter.fieldMetadataId === fieldMetadataItemId,
const existingNonAdvancedRecordFilter = currentRecordFilters.find(
(recordFilter) =>
recordFilter.fieldMetadataId === fieldMetadataItemId &&
!isDefined(recordFilter.recordFilterGroupId),
);
if (isDefined(existingRecordFilter)) {
setEditableFilterChipDropdownStates(existingRecordFilter);
openDropdownFromOutside(existingRecordFilter.id);
if (isDefined(existingNonAdvancedRecordFilter)) {
setEditableFilterChipDropdownStates(existingNonAdvancedRecordFilter);
openDropdownFromOutside(existingNonAdvancedRecordFilter.id);
return;
}